* [PATCH] maple_tree: Fix potential out of range offset on mas_next()/mas_prev()
@ 2022-05-19 15:03 Liam Howlett
0 siblings, 0 replies; only message in thread
From: Liam Howlett @ 2022-05-19 15:03 UTC (permalink / raw)
To: maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Andrew Morton
When going between next/prev, be more careful to stay within the nodes
range.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 8cde2edcb4f8..9f8d3ee792d1 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -4628,8 +4628,10 @@ static inline void *mas_next_entry(struct ma_state *mas, unsigned long limit)
node = mas_mn(mas);
mt = mte_node_type(mas->node);
mas->offset++;
- if (unlikely(mas->offset >= mt_slots[mt]))
+ if (unlikely(mas->offset >= mt_slots[mt])) {
+ mas->offset = mt_slots[mt] - 1;
goto next_node;
+ }
while (!mas_is_none(mas)) {
entry = mas_next_nentry(mas, node, limit, mt);
@@ -4687,6 +4689,9 @@ static inline void *mas_prev_nentry(struct ma_state *mas, unsigned long limit,
mn = mas_mn(mas);
mt = mte_node_type(mas->node);
offset = mas->offset - 1;
+ if (offset >= mt_slots[mt])
+ offset = mt_slots[mt] - 1;
+
slots = ma_slots(mn, mt);
pivots = ma_pivots(mn, mt);
if (offset == mt_pivots[mt])
--
2.35.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-19 15:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-19 15:03 [PATCH] maple_tree: Fix potential out of range offset on mas_next()/mas_prev() Liam Howlett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).