From: Liam Howlett <liam.howlett@oracle.com>
To: "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] mm/mmap: Fix do_brk_munmap() when munmapping multiple mappings
Date: Thu, 19 May 2022 15:05:22 +0000 [thread overview]
Message-ID: <20220519150509.1290067-1-Liam.Howlett@oracle.com> (raw)
If the newbrk is less than the last brk vma start, then munmap entire
VMA(s).
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
mm/mmap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index f1fc9c5c068b..c065a3d9b5da 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2942,8 +2942,7 @@ static int do_brk_munmap(struct ma_state *mas, struct vm_area_struct *vma,
arch_unmap(mm, newbrk, oldbrk);
- if (likely((vma->vm_end < oldbrk) ||
- ((vma->vm_start == newbrk) && (vma->vm_end == oldbrk)))) {
+ if (likely((vma->vm_end < oldbrk) || (vma->vm_start >= newbrk))) {
/* remove entire mapping(s) */
ret = do_mas_align_munmap(mas, vma, mm, newbrk, oldbrk, uf,
true);
--
2.35.1
reply other threads:[~2022-05-19 15:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519150509.1290067-1-Liam.Howlett@oracle.com \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).