From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E81C433F5 for ; Fri, 20 May 2022 01:57:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCE6E8D0001; Thu, 19 May 2022 21:57:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7F366B0073; Thu, 19 May 2022 21:57:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A46488D0001; Thu, 19 May 2022 21:57:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 97EAE6B0072 for ; Thu, 19 May 2022 21:57:56 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3AAF521773 for ; Fri, 20 May 2022 01:57:56 +0000 (UTC) X-FDA: 79484460552.12.A267CD8 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf01.hostedemail.com (Postfix) with ESMTP id 1F13A40011 for ; Fri, 20 May 2022 01:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653011875; x=1684547875; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Pi588XLvq+mQ0AgwxIsoSjkMIdYQhApnFrYgEjsZBLY=; b=lDxuuVs+eTKZvzEnxNCa7sj04mQfO8NHvVC/mOOZg7qxWAeha4yNXWYi SLVKpOwudv0jYL3uU8iAyDF5zq8AMYLgsKj8eVPjnNOxUsImhXSnjVGop aSma8z8tEgQpfiIen6/I7eX+8xLU+r2meARIlcd33lOmVSySB50qeW/Na cYKM4lpsF2AUqeA39IHW9toEPDkC7HNmRu3j+VTlxBig2TqSAgJJuRkHG T3ZWV4l2kektU6WzOkvoB9GnegXQ6f3JokX21cpbbvQi9dmyLe37Ge7B/ uKo3VANZ/ycaCnSzpusXUxTOQ1ojyqY40TaqavEQyx55/pIde9L4CRCmU Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="297758895" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="297758895" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 18:57:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="627908126" Received: from lkp-server02.sh.intel.com (HELO 242b25809ac7) ([10.239.97.151]) by fmsmga008.fm.intel.com with ESMTP; 19 May 2022 18:57:49 -0700 Received: from kbuild by 242b25809ac7 with local (Exim 4.95) (envelope-from ) id 1nrrtk-00049x-MV; Fri, 20 May 2022 01:57:48 +0000 Date: Fri, 20 May 2022 09:57:40 +0800 From: kernel test robot To: Song Liu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Cc: kbuild-all@lists.01.org, ast@kernel.org, daniel@iogearbox.net, mcgrof@kernel.org, torvalds@linux-foundation.org, rick.p.edgecombe@intel.com, kernel-team@fb.com, Song Liu Subject: Re: [PATCH v2 bpf-next 8/8] bpf: simplify select_bpf_prog_pack_size Message-ID: <202205200913.DnvvOaAw-lkp@intel.com> References: <20220519202037.2401584-9-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220519202037.2401584-9-song@kernel.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1F13A40011 X-Stat-Signature: ebeado7kffo4m3ce7b4uungfaxk91jck Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lDxuuVs+; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf01.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=lkp@intel.com X-Rspam-User: X-HE-Tag: 1653011873-687996 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Song, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Song-Liu/bpf_prog_pack-followup/20220520-043417 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220520/202205200913.DnvvOaAw-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/2d5d4beb45be09f3130b694f49ab1b1fd1aa4470 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Song-Liu/bpf_prog_pack-followup/20220520-043417 git checkout 2d5d4beb45be09f3130b694f49ab1b1fd1aa4470 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash kernel/bpf/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): kernel/bpf/core.c: In function 'select_bpf_prog_pack_size': >> kernel/bpf/core.c:857:15: warning: unused variable 'ptr' [-Wunused-variable] 857 | void *ptr; | ^~~ vim +/ptr +857 kernel/bpf/core.c e581094167beb6 Song Liu 2022-03-21 853 ef078600eec20f Song Liu 2022-03-11 854 static size_t select_bpf_prog_pack_size(void) ef078600eec20f Song Liu 2022-03-11 855 { ef078600eec20f Song Liu 2022-03-11 856 size_t size; ef078600eec20f Song Liu 2022-03-11 @857 void *ptr; ef078600eec20f Song Liu 2022-03-11 858 2d5d4beb45be09 Song Liu 2022-05-19 859 if (huge_vmalloc_supported()) { e581094167beb6 Song Liu 2022-03-21 860 size = BPF_HPAGE_SIZE * num_online_nodes(); 2d5d4beb45be09 Song Liu 2022-05-19 861 bpf_prog_pack_mask = BPF_HPAGE_MASK; 2d5d4beb45be09 Song Liu 2022-05-19 862 } else { ef078600eec20f Song Liu 2022-03-11 863 size = PAGE_SIZE; 96805674e5624b Song Liu 2022-03-21 864 bpf_prog_pack_mask = PAGE_MASK; 96805674e5624b Song Liu 2022-03-21 865 } ef078600eec20f Song Liu 2022-03-11 866 ef078600eec20f Song Liu 2022-03-11 867 return size; ef078600eec20f Song Liu 2022-03-11 868 } ef078600eec20f Song Liu 2022-03-11 869 -- 0-DAY CI Kernel Test Service https://01.org/lkp