From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14349C433F5 for ; Fri, 20 May 2022 18:37:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CA096B0071; Fri, 20 May 2022 14:37:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84FD46B0072; Fri, 20 May 2022 14:37:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A2756B0073; Fri, 20 May 2022 14:37:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 53B5C6B0071 for ; Fri, 20 May 2022 14:37:25 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2582935226 for ; Fri, 20 May 2022 18:37:25 +0000 (UTC) X-FDA: 79486979250.23.4088B75 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf25.hostedemail.com (Postfix) with ESMTP id 1A3B3A0017 for ; Fri, 20 May 2022 18:36:58 +0000 (UTC) Received: from pps.filterd (m0109334.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24KHSPmr018150 for ; Fri, 20 May 2022 11:37:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=JmNWcJ9S5BuVrDagcKBT8mAi6jQ8Go8fzpG+AeBXTsU=; b=qUZzpfK27enxbJD8TbCXOSUkdo1jEz02hR2C3TBvdksrMSz99UxRgez26GTav6E7cqw3 hX9IIvDPxZwqHQMdsEwgYhTQd9x5MiVa3Q98fZQHM/1cLrEqFBEU0tv/JHtBkrHu8XK3 hmnN4ljOPLE18Rah/iBdaPiKJVNZzyJI3Rs= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3g5xexdvw8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 20 May 2022 11:37:22 -0700 Received: from twshared24024.25.frc3.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:83::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 20 May 2022 11:37:21 -0700 Received: by devvm225.atn0.facebook.com (Postfix, from userid 425415) id 64B10F5E5B23; Fri, 20 May 2022 11:37:16 -0700 (PDT) From: Stefan Roesch To: , , , , CC: , , , Subject: [RFC PATCH v4 02/17] mm: Move updates of dirty_exceeded into one place Date: Fri, 20 May 2022 11:36:31 -0700 Message-ID: <20220520183646.2002023-3-shr@fb.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220520183646.2002023-1-shr@fb.com> References: <20220520183646.2002023-1-shr@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-ORIG-GUID: u5CjVyJlv9358gOCN1Kpa3GXzUNl5lwQ X-Proofpoint-GUID: u5CjVyJlv9358gOCN1Kpa3GXzUNl5lwQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-20_05,2022-05-20_02,2022-02-23_01 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1A3B3A0017 X-Stat-Signature: p8sdhipype3t1mkfnuoc55d6jexkzpcx X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=qUZzpfK2; dmarc=pass (policy=reject) header.from=fb.com; spf=none (imf25.hostedemail.com: domain of "prvs=6139886598=shr@fb.com" has no SPF policy when checking 67.231.145.42) smtp.mailfrom="prvs=6139886598=shr@fb.com" X-HE-Tag: 1653071818-728188 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jan Kara Transition of wb->dirty_exceeded from 0 to 1 happens before we go to sleep in balance_dirty_pages() while transition from 1 to 0 happens when exiting from balance_dirty_pages(), possibly based on old values. This does not make a lot of sense since wb->dirty_exceeded should simply reflect whether wb is over dirty limit and so we should ratelimit entering to balance_dirty_pages() less. Move the two updates together. Signed-off-by: Jan Kara Signed-off-by: Stefan Roesch --- mm/page-writeback.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 8e5e003f0093..89dcc7d8395a 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1720,8 +1720,8 @@ static void balance_dirty_pages(struct bdi_writebac= k *wb, sdtc =3D mdtc; } =20 - if (dirty_exceeded && !wb->dirty_exceeded) - wb->dirty_exceeded =3D 1; + if (dirty_exceeded !=3D wb->dirty_exceeded) + wb->dirty_exceeded =3D dirty_exceeded; =20 if (time_is_before_jiffies(READ_ONCE(wb->bw_time_stamp) + BANDWIDTH_INTERVAL)) @@ -1825,9 +1825,6 @@ static void balance_dirty_pages(struct bdi_writebac= k *wb, if (fatal_signal_pending(current)) break; } - - if (!dirty_exceeded && wb->dirty_exceeded) - wb->dirty_exceeded =3D 0; } =20 static DEFINE_PER_CPU(int, bdp_ratelimits); --=20 2.30.2