From: SeongJae Park <sj@kernel.org>
To: Khalid Masum <khalid.masum.92@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>,
SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/daemon: describe NR_DAMON_OPS in damon_ops_id
Date: Mon, 23 May 2022 14:12:25 -0700 [thread overview]
Message-ID: <20220523211225.32500-1-sj@kernel.org> (raw)
In-Reply-To: <20220523205336.2435-1-khalid.masum.92@gmail.com>
Hi Khalid,
On Tue, 24 May 2022 02:53:36 +0600 Khalid Masum <khalid.masum.92@gmail.com> wrote:
> NR_DAMON_OPS in the enum damon_ops_id is not described. Describe it for
> better readability and also to fix a warning generated by make docs.
>
> "NR" is described as "Total Number" and "DAMON_OPS" is described as
> "Monitoring operations" in the same file. Hence describe NR_DAMON_OPS
> as "Total number of damon operations".
Thank you for this patch! However, same patch has already posted by other and
merged in mm-stable[1], sorry. Looking forward to your next patches, though!
[1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-stable&id=d4a157f5a26fbf1f1fd5da47a4772a738306348f
Thanks,
SJ
>
> Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
> ---
> include/linux/damon.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index f23cbfa42..9e9fb4d78 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -262,6 +262,7 @@ struct damos {
> *
> * @DAMON_OPS_VADDR: Monitoring operations for virtual address spaces
> * @DAMON_OPS_PADDR: Monitoring operations for the physical address space
> + * @NR_DAMON_OPS: Total number of monitoring operations
> */
> enum damon_ops_id {
> DAMON_OPS_VADDR,
> --
> 2.25.1
>
prev parent reply other threads:[~2022-05-23 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 20:53 [PATCH] mm/daemon: describe NR_DAMON_OPS in damon_ops_id Khalid Masum
2022-05-23 21:12 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523211225.32500-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=damon@lists.linux.dev \
--cc=khalid.masum.92@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).