From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60AA5C433EF for ; Tue, 24 May 2022 11:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE6A18D0002; Tue, 24 May 2022 07:55:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D95DF8D0001; Tue, 24 May 2022 07:55:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAB5A8D0002; Tue, 24 May 2022 07:55:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BAC3F8D0001 for ; Tue, 24 May 2022 07:55:47 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 956CB34B01 for ; Tue, 24 May 2022 11:55:47 +0000 (UTC) X-FDA: 79500482334.05.852BF15 Received: from outbound-smtp07.blacknight.com (outbound-smtp07.blacknight.com [46.22.139.12]) by imf10.hostedemail.com (Postfix) with ESMTP id 3C735C0030 for ; Tue, 24 May 2022 11:55:11 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp07.blacknight.com (Postfix) with ESMTPS id 949581C5646 for ; Tue, 24 May 2022 12:55:45 +0100 (IST) Received: (qmail 17315 invoked from network); 24 May 2022 11:55:45 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 24 May 2022 11:55:45 -0000 Date: Tue, 24 May 2022 12:55:43 +0100 From: Mel Gorman To: Qais Yousef Cc: Andrew Morton , Nicolas Saenz Julienne , Marcelo Tosatti , Vlastimil Babka , Michal Hocko , LKML , Linux-MM Subject: Re: [PATCH 3/6] mm/page_alloc: Split out buddy removal code from rmqueue into separate helper Message-ID: <20220524115543.GX3441@techsingularity.net> References: <20220512085043.5234-1-mgorman@techsingularity.net> <20220512085043.5234-4-mgorman@techsingularity.net> <20220523160921.k34jjbpd62bmc7fj@wubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20220523160921.k34jjbpd62bmc7fj@wubuntu> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Queue-Id: 3C735C0030 X-Stat-Signature: tactarmct3hwcbhysnmnxr7bpj3e1p4c Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.12 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none X-Rspamd-Server: rspam03 X-HE-Tag: 1653393311-939367 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 23, 2022 at 05:09:21PM +0100, Qais Yousef wrote: > On 05/12/22 09:50, Mel Gorman wrote: > > This is a preparation page to allow the buddy removal code to be reused > > in a later patch. > > > > No functional change. > > > > Signed-off-by: Mel Gorman > > Tested-by: Minchan Kim > > Acked-by: Minchan Kim > > --- > > I see this splat when this patch is applied on 5.10.107 kernel: > > I could resolve it by applying this patch: > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 80c1e0a0f094e..92fb0c08296ef 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -957,11 +957,11 @@ void __inc_numa_state(struct zone *zone, > u16 __percpu *p = pcp->vm_numa_stat_diff + item; > u16 v; > > - v = __this_cpu_inc_return(*p); > + v = this_cpu_inc_return(*p); > > if (unlikely(v > NUMA_STATS_THRESHOLD)) { > zone_numa_state_add(v, zone, item); > - __this_cpu_write(*p, 0); > + this_cpu_write(*p, 0); > } > } > 5.18 does not have __inc_numa_state() so it's likely you are missing backports, probably f19298b9516c1a031b34b4147773457e3efe743b at minimum. -- Mel Gorman SUSE Labs