From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17497C433F5 for ; Tue, 24 May 2022 15:59:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 941A88D0003; Tue, 24 May 2022 11:59:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F0518D0001; Tue, 24 May 2022 11:59:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DD2C8D0003; Tue, 24 May 2022 11:59:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6D9508D0001 for ; Tue, 24 May 2022 11:59:53 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 10AC8120188 for ; Tue, 24 May 2022 15:59:53 +0000 (UTC) X-FDA: 79501097466.24.67A1EB9 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf23.hostedemail.com (Postfix) with ESMTP id 8B451140035 for ; Tue, 24 May 2022 15:59:31 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 207A6B81A4F; Tue, 24 May 2022 15:59:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7580FC34113; Tue, 24 May 2022 15:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653407989; bh=003EFPVAWAtkcipXIjXUvRz6XdQ5O2kKi9sJjDH1Xkc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mpocOByTlKqY852Hdyx107R7UdAKKRferxhLvE01kUa+MeYEymm9EfhY0nRaCIuwo KpIAtaWRAH5bPXok6/v2pGKYDKGYmSOb1qXXaX34so2itYCo+zPGxsmQBguolITPt1 T36X4Mt33X4Kt5pQtqY/bC2qFXovTcLRMw5a2FOcP/Jfe8PpxJV5EkWVpV2SJd6WC5 Ro0DeavtBOe1d+Ju1rwVS0XpoQ4qnUJzKOATXOibKtp5Hlud0kRWK2sRNW5a76RHeu +vn+szlmAm7TRD1QJf7AXO1eYaLwZnaKiOW/7p2OZNJ+PbuxnAVFOlnDrmqD6tUGKw ixqKh0ztwWXag== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Al Viro , syzbot+5b1e53987f858500ec00@syzkaller.appspotmail.com, Sasha Levin , dennis@kernel.org, tj@kernel.org, cl@linux.com, linux-mm@kvack.org Subject: [PATCH AUTOSEL 5.17 07/12] percpu_ref_init(): clean ->percpu_count_ref on failure Date: Tue, 24 May 2022 11:59:21 -0400 Message-Id: <20220524155929.826793-7-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220524155929.826793-1-sashal@kernel.org> References: <20220524155929.826793-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8B451140035 X-Stat-Signature: w1xbf7brip3zuxijp3hc43nefkbjqme4 X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mpocOByT; spf=pass (imf23.hostedemail.com: domain of sashal@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sashal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1653407971-311822 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Al Viro [ Upstream commit a91714312eb16f9ecd1f7f8b3efe1380075f28d4 ] That way percpu_ref_exit() is safe after failing percpu_ref_init(). At least one user (cgroup_create()) had a double-free that way; there might be other similar bugs. Easier to fix in percpu_ref_init(), rather than playing whack-a-mole in sloppy users... Usual symptoms look like a messed refcounting in one of subsystems that use percpu allocations (might be percpu-refcount, might be something else). Having refcounts for two different objects share memory is Not Nice(tm)... Reported-by: syzbot+5b1e53987f858500ec00@syzkaller.appspotmail.com Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- lib/percpu-refcount.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/percpu-refcount.c b/lib/percpu-refcount.c index af9302141bcf..e5c5315da274 100644 --- a/lib/percpu-refcount.c +++ b/lib/percpu-refcount.c @@ -76,6 +76,7 @@ int percpu_ref_init(struct percpu_ref *ref, percpu_ref_func_t *release, data = kzalloc(sizeof(*ref->data), gfp); if (!data) { free_percpu((void __percpu *)ref->percpu_count_ptr); + ref->percpu_count_ptr = 0; return -ENOMEM; } -- 2.35.1