From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CEAFC433FE for ; Tue, 24 May 2022 18:17:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2A658D0003; Tue, 24 May 2022 14:17:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD9A08D0002; Tue, 24 May 2022 14:17:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEAD08D0003; Tue, 24 May 2022 14:17:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A01A38D0002 for ; Tue, 24 May 2022 14:17:13 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 70E2A33EE3 for ; Tue, 24 May 2022 18:17:13 +0000 (UTC) X-FDA: 79501443546.13.7D2446D Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf12.hostedemail.com (Postfix) with ESMTP id 384D0400C0 for ; Tue, 24 May 2022 18:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653416232; x=1684952232; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EBnyAxgG8VMP5VnxxAr+i+RhOOaMEQkB+M7uuFYWkuc=; b=jfF7APktXMP9Otc3ZBldSqwW3aJEl18nafuEW2ro072jGzIq/DPnM7mt 6YuohDvFpnRSFIBdUCggHowDMLqmCTU1XyaIrrg8kzuOEwa3ysV4gv/za gWN5zg7bJUAszt9LR1VumjuUjOH7KdlLtxvh0kxMZYTQ/e8sbI+l6WmWo b3aQpolvC1FCCM6wfEu/DtgAYizrxLwHZ8Kimy5NZHHBtPzXfLKny+b9L L+SddcCJdM0m11NWCLnPj0O/qytUac/qxLGrJFDBXqe3yLjqN7T0/2CQH UdOZWqhDJSs1PWfik859oTkMShc5RAJv9VzqxnD59nrZ4bp+ud+SfcIFo Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="254118235" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="254118235" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 11:17:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="717281728" Received: from lkp-server01.sh.intel.com (HELO db63a1be7222) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 24 May 2022 11:17:05 -0700 Received: from kbuild by db63a1be7222 with local (Exim 4.95) (envelope-from ) id 1ntZ5d-0002KY-4x; Tue, 24 May 2022 18:17:05 +0000 Date: Wed, 25 May 2022 02:16:47 +0800 From: kernel test robot To: Muchun Song , hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com, Muchun Song Subject: Re: [PATCH v4 09/11] mm: memcontrol: use obj_cgroup APIs to charge the LRU pages Message-ID: <202205250202.1JanYiVZ-lkp@intel.com> References: <20220524060551.80037-10-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220524060551.80037-10-songmuchun@bytedance.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 384D0400C0 X-Stat-Signature: o57zqt6zsaytzbhsyihkniafdaoc794a X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jfF7APkt; spf=none (imf12.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.151) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1653416197-77877 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Muchun, Thank you for the patch! Yet something to improve: [auto build test ERROR on 4b0986a3613c92f4ec1bdc7f60ec66fea135991f] url: https://github.com/intel-lab-lkp/linux/commits/Muchun-Song/Use-obj_cgroup-APIs-to-charge-the-LRU-pages/20220524-143056 base: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f config: arm64-buildonly-randconfig-r005-20220524 (https://download.01.org/0day-ci/archive/20220525/202205250202.1JanYiVZ-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 10c9ecce9f6096e18222a331c5e7d085bd813f75) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/bec0ae12106e0cf12dd4e0e21eb0754b99be0ba2 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Muchun-Song/Use-obj_cgroup-APIs-to-charge-the-LRU-pages/20220524-143056 git checkout bec0ae12106e0cf12dd4e0e21eb0754b99be0ba2 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): >> mm/memcontrol.c:6826:10: error: call to undeclared function '__get_obj_cgroup_from_memcg'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] objcg = __get_obj_cgroup_from_memcg(memcg); ^ >> mm/memcontrol.c:6826:8: warning: incompatible integer to pointer conversion assigning to 'struct obj_cgroup *' from 'int' [-Wint-conversion] objcg = __get_obj_cgroup_from_memcg(memcg); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning and 1 error generated. vim +/__get_obj_cgroup_from_memcg +6826 mm/memcontrol.c 6818 6819 static int charge_memcg(struct folio *folio, struct mem_cgroup *memcg, 6820 gfp_t gfp) 6821 { 6822 struct obj_cgroup *objcg; 6823 long nr_pages = folio_nr_pages(folio); 6824 int ret = 0; 6825 > 6826 objcg = __get_obj_cgroup_from_memcg(memcg); 6827 /* Do not account at the root objcg level. */ 6828 if (!obj_cgroup_is_root(objcg)) 6829 ret = try_charge(memcg, gfp, nr_pages); 6830 if (ret) 6831 goto out; 6832 6833 obj_cgroup_get(objcg); 6834 commit_charge(folio, objcg); 6835 6836 local_irq_disable(); 6837 mem_cgroup_charge_statistics(memcg, nr_pages); 6838 memcg_check_events(memcg, folio_nid(folio)); 6839 local_irq_enable(); 6840 out: 6841 obj_cgroup_put(objcg); 6842 return ret; 6843 } 6844 -- 0-DAY CI Kernel Test Service https://01.org/lkp