From: "hch@lst.de" <hch@lst.de>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"hch@lst.de" <hch@lst.de>,
"dave@stgolabs.net" <dave@stgolabs.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"peterz@infradead.org" <peterz@infradead.org>,
"ast@kernel.org" <ast@kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"kernel-team@fb.com" <kernel-team@fb.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"song@kernel.org" <song@kernel.org>,
"Torvalds, Linus" <torvalds@linux-foundation.org>,
"arnd@arndb.de" <arnd@arndb.de>,
Adam Manzanares <a.manzanares@samsung.com>
Subject: Re: [PATCH v3 bpf-next 5/8] bpf: use module_alloc_huge for bpf_prog_pack
Date: Wed, 25 May 2022 08:01:42 +0200 [thread overview]
Message-ID: <20220525060142.GB10762@lst.de> (raw)
In-Reply-To: <Yo1XTN441qbNTLGR@bombadil.infradead.org>
On Tue, May 24, 2022 at 03:08:12PM -0700, Luis Chamberlain wrote:
> > A rename seems good to me. Module space is really just dynamically
> > allocated text space now. There used to be a vmalloc_exec() that
> > allocated text in vmalloc space,
>
> Yes I saw that but it was generic and it did not do the arch-specific
> override, and so that is why Christoph ripped it out and open coded
> it on the only user, on module_alloc().
It it also because random code does not have any business allocating
executable memory. Executable memory in kernel is basically for
modules and module-like code like eBPF, and no one else has any business
allocating pages with the execute bit set (or the NX bit not set).
next prev parent reply other threads:[~2022-05-25 6:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 3:15 [PATCH v3 bpf-next 0/8] bpf_prog_pack followup Song Liu
2022-05-20 3:15 ` [PATCH v3 bpf-next 1/8] bpf: fill new bpf_prog_pack with illegal instructions Song Liu
2022-05-20 3:15 ` [PATCH v3 bpf-next 2/8] x86/alternative: introduce text_poke_set Song Liu
2022-05-22 5:38 ` Hyeonggon Yoo
2022-05-20 3:15 ` [PATCH v3 bpf-next 3/8] bpf: introduce bpf_arch_text_invalidate for bpf_prog_pack Song Liu
2022-05-20 3:15 ` [PATCH v3 bpf-next 4/8] module: introduce module_alloc_huge Song Liu
2022-05-20 3:15 ` [PATCH v3 bpf-next 5/8] bpf: use module_alloc_huge for bpf_prog_pack Song Liu
2022-05-21 1:00 ` Luis Chamberlain
2022-05-21 1:20 ` Luis Chamberlain
2022-05-21 3:20 ` Edgecombe, Rick P
2022-05-21 20:06 ` Luis Chamberlain
2022-05-24 17:40 ` Edgecombe, Rick P
2022-05-24 22:08 ` Luis Chamberlain
2022-05-25 6:01 ` hch [this message]
2022-05-20 3:15 ` [PATCH v3 bpf-next 6/8] vmalloc: WARN for set_vm_flush_reset_perms() on huge pages Song Liu
2022-05-20 3:15 ` [PATCH v3 bpf-next 7/8] vmalloc: introduce huge_vmalloc_supported Song Liu
2022-05-20 3:15 ` [PATCH v3 bpf-next 8/8] bpf: simplify select_bpf_prog_pack_size Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525060142.GB10762@lst.de \
--to=hch@lst.de \
--cc=a.manzanares@samsung.com \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@iogearbox.net \
--cc=dave@stgolabs.net \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=song@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).