From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 989C5C433EF for ; Fri, 27 May 2022 15:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93BAF8D002C; Fri, 27 May 2022 11:50:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 808488D0031; Fri, 27 May 2022 11:50:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 563C18D002F; Fri, 27 May 2022 11:50:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EFD308D002C for ; Fri, 27 May 2022 11:50:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D1A7534767 for ; Fri, 27 May 2022 15:50:53 +0000 (UTC) X-FDA: 79511961186.23.A2F1BFE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id C369514003F for ; Fri, 27 May 2022 15:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=qQEqXPIAXhUgwxBQ6QCQQiUDHFUM6Ol8abPdc//PdiU=; b=AEvZLXAZaZa8elyEnFJg5ybISg NLks/WO1fkcraDEOC20sRV53DbHf/RH9vvAuBNrFaN9Vde28KDKOyQmaadzu4ZMkaH4ri6WmsUWOZ +R5vkEjpecbxOrtxX0qC8mIY1FQ549yEy0L4UD40sWuv6Qc6sRDr7LeuBm1scC1MVXhk0paclE9O1 iR9QC/W+b98Zy/za24PRlyDawBJrAmPxDpQUxX8f13MPSFMzmwVDu1BJV9pN/KFfdUmPy/mnKHZQm rmlqqaCKmYQxe4atKaquqgAe+nCN1+vYYUuBJlCdRmKfgs7p6KSIAYwTrsFDt9mpYaDqm8JWs8NJF KP2IGpSA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEa-002CWe-W6; Fri, 27 May 2022 15:50:41 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 10/24] ntfs: Remove check for PageError Date: Fri, 27 May 2022 16:50:22 +0100 Message-Id: <20220527155036.524743-11-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C369514003F X-Stat-Signature: bgjrihwfmuc9ztfep3rhgfzas383ksuf Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AEvZLXAZ; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1653666630-912438 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If read_mapping_page() encounters an error, it returns an errno, not a page with PageError set, so this is dead code. Signed-off-by: Matthew Wilcox (Oracle) --- fs/ntfs/aops.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/ntfs/aops.h b/fs/ntfs/aops.h index 934d5f79b9e7..0cac5458c023 100644 --- a/fs/ntfs/aops.h +++ b/fs/ntfs/aops.h @@ -74,13 +74,8 @@ static inline struct page *ntfs_map_page(struct address_space *mapping, { struct page *page = read_mapping_page(mapping, index, NULL); - if (!IS_ERR(page)) { + if (!IS_ERR(page)) kmap(page); - if (!PageError(page)) - return page; - ntfs_unmap_page(page); - return ERR_PTR(-EIO); - } return page; } -- 2.34.1