From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C569BC43217 for ; Fri, 27 May 2022 15:50:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17AA78D0021; Fri, 27 May 2022 11:50:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFD838D001E; Fri, 27 May 2022 11:50:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 867148D0024; Fri, 27 May 2022 11:50:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 48F318D0025 for ; Fri, 27 May 2022 11:50:44 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 1876C808DF for ; Fri, 27 May 2022 15:50:44 +0000 (UTC) X-FDA: 79511960808.17.A9853C6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id E03951C003B for ; Fri, 27 May 2022 15:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=i2t/qLSgdmu/wJjlxbx86LZigla0S50FB+rJa/7oTp4=; b=HCcffH2/971xsM0+d7Gy9W0H/B iPootp9x8eswPq0Kv4uWn/Qk1XU1UEl63BQMinB1PphPvm9o51q8hhzdZR9QR66bHgFlSPGcT1dio yH1kBWZNcgdTkPaHJmlUO8qBPrxtlD9VlqozZdwPu0n75kzO+XJvEjZqS8MGj4tgSy1VyZt8jQPiT o+imv1RHzwTsBsxZ+VVlk7Jzf+JxP5t/RzBhBOlONxtggzLj5UzcdeLxxbJE3mlMaus6437664xgp yFAofy5Ce1vUeAUC5YoraA05b711s5O2FHcdn6NUgpj7wyoSXb9wvLerkXr/chh7l06BZy6wCPlZk eigNaKZQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEb-002CWi-4C; Fri, 27 May 2022 15:50:41 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 12/24] reiserfs: Remove check for PageError Date: Fri, 27 May 2022 16:50:24 +0100 Message-Id: <20220527155036.524743-13-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E03951C003B X-Stat-Signature: 3u3h5czabcntmcbtrqmsi7w4zxsmed5q Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="HCcffH2/"; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-HE-Tag: 1653666626-474354 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If read_mapping_page() encounters an error, it returns an errno, not a page with PageError set, so this is dead code. Signed-off-by: Matthew Wilcox (Oracle) --- fs/reiserfs/xattr.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c index bd073836e141..436641369283 100644 --- a/fs/reiserfs/xattr.c +++ b/fs/reiserfs/xattr.c @@ -440,16 +440,9 @@ static struct page *reiserfs_get_page(struct inode *dir, size_t n) */ mapping_set_gfp_mask(mapping, GFP_NOFS); page = read_mapping_page(mapping, n >> PAGE_SHIFT, NULL); - if (!IS_ERR(page)) { + if (!IS_ERR(page)) kmap(page); - if (PageError(page)) - goto fail; - } return page; - -fail: - reiserfs_put_page(page); - return ERR_PTR(-EIO); } static inline __u32 xattr_hash(const char *msg, int len) -- 2.34.1