From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F82C433EF for ; Fri, 27 May 2022 15:51:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6411B8D0032; Fri, 27 May 2022 11:50:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59FFE8D002F; Fri, 27 May 2022 11:50:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C7958D0032; Fri, 27 May 2022 11:50:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 19B538D002F for ; Fri, 27 May 2022 11:50:55 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D583F20B64 for ; Fri, 27 May 2022 15:50:54 +0000 (UTC) X-FDA: 79511961228.09.B48FDE3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 4E54F1C0042 for ; Fri, 27 May 2022 15:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=1XtQLdO3zOMxoYZ7MTiciQTgmwPX4hfSHC2XnCRgCrU=; b=X/ZfjynB0l9ZCO9PgWj9JR/tEI KX9iyayFZddcJmbIOlrS8L4dBKI18TzPRWdWSnyamzfwA8tsLyYTe3TUQrgDj9wIwmvpR6VUQhIo8 gBr43W7SfYhmLi4pC9D1tw99Y1qO9u2r93NmNIWXN6atsvBH7x5L6A+wIfUY+4cOFLuQbk4XQr352 grt/fRP3Dm5vxU7Ac7kbQhLQVknZWJcLLMXzeqgdEEBQKmmhGvFGuWPlrmobBFS/CtDeOdcHrv1A/ u2Ccb56wnii1BS8E7LctrJYT7lbSrp1WvrFq9PTaoLuBcUDZaXBXU4RqpnSyYnrl2AOYULDielCgt KWrb5mnA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEa-002CWM-A8; Fri, 27 May 2022 15:50:40 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 01/24] block: Remove check of PageError Date: Fri, 27 May 2022 16:50:13 +0100 Message-Id: <20220527155036.524743-2-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4E54F1C0042 X-Stat-Signature: rw6mko1j46369e7uchmtgimjx63s98ze X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="X/ZfjynB"; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1653666638-222548 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If read_mapping_page() sees a page with PageError set, it returns a PTR_ERR(). Checking PageError again is simply dead code. Signed-off-by: Matthew Wilcox (Oracle) --- block/partitions/core.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/block/partitions/core.c b/block/partitions/core.c index 8a0ec929023b..a9a51bac42df 100644 --- a/block/partitions/core.c +++ b/block/partitions/core.c @@ -716,14 +716,10 @@ void *read_part_sector(struct parsed_partitions *state, sector_t n, Sector *p) (pgoff_t)(n >> (PAGE_SHIFT - 9)), NULL); if (IS_ERR(page)) goto out; - if (PageError(page)) - goto out_put_page; p->v = page; return (unsigned char *)page_address(page) + ((n & ((1 << (PAGE_SHIFT - 9)) - 1)) << SECTOR_SHIFT); -out_put_page: - put_page(page); out: p->v = NULL; return NULL; -- 2.34.1