From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3AAFC4332F for ; Fri, 27 May 2022 15:51:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D7B58D002A; Fri, 27 May 2022 11:50:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D42C38D0028; Fri, 27 May 2022 11:50:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CAD88D0024; Fri, 27 May 2022 11:50:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 581BE8D0029 for ; Fri, 27 May 2022 11:50:45 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3A05734597 for ; Fri, 27 May 2022 15:50:45 +0000 (UTC) X-FDA: 79511960850.06.F5C9F37 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id C4E2E140030 for ; Fri, 27 May 2022 15:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=ZlD1f57qhy3ShckNt2ffGbjpwicKrzxeuKEcj2HaQLE=; b=J7MR+u6/CPeU1QJ0awNd2gCTAB AnARRGIoWkbN6QR3J2/xC7547fBeLMrTXQnDjTsUuZJ3FoF/pUx64CyHQ8b5ydP+Xqv/4II8sLx3+ UjwMCWgnjJeVZjS1qeHVgcjOV+IQn0/6CekxY1w6DdvgK8C05LBEyaU+MsaPy13s827NUme5mx850 PSntvqp8bh6ydbalKBDkUjvnbqKpXhTRLcgy5sVs60DIcQsbHqygLyKi5Mv97EnWmGNQhVvQmnQg8 Ip71oOQPUv5eHF5vSCHpAAjugNvTw16AxuZzKjwrkpRujX0OX1XEPu3luDMAl6rVFBp42CwuqaCkk 2Jp5ybVg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEa-002CWO-Cb; Fri, 27 May 2022 15:50:40 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 02/24] afs: Remove check of PageError Date: Fri, 27 May 2022 16:50:14 +0100 Message-Id: <20220527155036.524743-3-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C4E2E140030 X-Stat-Signature: k3fn7b91jnstndo1pcrj6x9nh4rgu1ae Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="J7MR+u6/"; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1653666640-967559 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If read_mapping_page() encounters an error, it returns an errno, not a page with PageError set, so this is dead code. Signed-off-by: Matthew Wilcox (Oracle) --- fs/afs/mntpt.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fs/afs/mntpt.c b/fs/afs/mntpt.c index bbb2c210d139..97f50e9fd9eb 100644 --- a/fs/afs/mntpt.c +++ b/fs/afs/mntpt.c @@ -132,12 +132,6 @@ static int afs_mntpt_set_params(struct fs_context *fc, struct dentry *mntpt) if (IS_ERR(page)) return PTR_ERR(page); - if (PageError(page)) { - ret = afs_bad(AFS_FS_I(d_inode(mntpt)), afs_file_error_mntpt); - put_page(page); - return ret; - } - buf = kmap(page); ret = -EINVAL; if (buf[size - 1] == '.') -- 2.34.1