From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2708C433FE for ; Fri, 27 May 2022 15:51:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC4618D003B; Fri, 27 May 2022 11:51:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4C9B8D002F; Fri, 27 May 2022 11:51:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 913C58D003B; Fri, 27 May 2022 11:51:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7E4558D002F for ; Fri, 27 May 2022 11:51:13 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5552F3528D for ; Fri, 27 May 2022 15:51:13 +0000 (UTC) X-FDA: 79511962026.22.65E9127 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 47205A0035 for ; Fri, 27 May 2022 15:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=Jx21YCMfVRPPtzra5uUZP9j4fCW3PrPAxum0BhgJe/Q=; b=HUSlDZ11G9WQp367CVuD3LEo4i iR4xSq+OazPUd9RZVT/cqwsKeSKL8qg99HmawCwbLR7jc4Svq48NZRi8thVsEdpzcKNRZo1rfxFc6 emAfCyGAJ955R9nDtu0RSvbPap9XWZqAtb3KbUs36NIhvlSEgFaIhXrpTlhENx+Z1a6hdMWAx2sR7 Tg4x88kpmgNcuwVJ34ldHzIh09ZH2MKNsgmPOnEhSDvofx32+pNJH7U4fVqsWs9YbnxuIC4Viu2PT /5VD8qPbOMEPP3ZGRxTZ6EhAd+Amz87NFUhoIMz1ppzhvL/Yd7NoC8JARCJdJbW/Ko1/EEwYfxLKh Dg9AIWVQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEa-002CWQ-Fa; Fri, 27 May 2022 15:50:40 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 03/24] freevxfs: Remove check of PageError Date: Fri, 27 May 2022 16:50:15 +0100 Message-Id: <20220527155036.524743-4-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 47205A0035 X-Stat-Signature: 8gdj88i8o98pkxa1j5netxe5cmzyi84w Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HUSlDZ11; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam09 X-HE-Tag: 1653666642-909607 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If read_mapping_page() encounters an error, it returns an errno, not a page with PageError set, so this is dead code. Signed-off-by: Matthew Wilcox (Oracle) --- fs/freevxfs/vxfs_subr.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fs/freevxfs/vxfs_subr.c b/fs/freevxfs/vxfs_subr.c index 6143ebab940d..041e818c4577 100644 --- a/fs/freevxfs/vxfs_subr.c +++ b/fs/freevxfs/vxfs_subr.c @@ -75,15 +75,9 @@ vxfs_get_page(struct address_space *mapping, u_long n) kmap(pp); /** if (!PageChecked(pp)) **/ /** vxfs_check_page(pp); **/ - if (PageError(pp)) - goto fail; } return (pp); - -fail: - vxfs_put_page(pp); - return ERR_PTR(-EIO); } /** -- 2.34.1