From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C63CC43217 for ; Fri, 27 May 2022 15:51:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 712038D0035; Fri, 27 May 2022 11:51:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69A558D002F; Fri, 27 May 2022 11:51:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55F5C8D0035; Fri, 27 May 2022 11:51:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 32FBE8D002F for ; Fri, 27 May 2022 11:51:05 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F294B3530E for ; Fri, 27 May 2022 15:51:04 +0000 (UTC) X-FDA: 79511961648.15.FE253B7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 95CF3A0049 for ; Fri, 27 May 2022 15:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=4wMMq3g5aM81AzKOoyA+PVFh218cMXjUSmWn3svbOQM=; b=r2pTcvZX9BEVvMkSidk0tFblVG f+AA4nFpaarqlyspVcUMydPbuLIMUCtWHuk9UVuTDME0BJ44GxqwxQPXIQWsTkfY80k8bSVOLs/Qy F3n2Qd1hCSrAvDM/QvBiL2her0e+X7l/I4ybmzzOxPGH6ZIRxaQOwcpKvdjoQ1keD+LpKdLX1cZk4 RL4U5mOk4sdzWyjgR/vURpJRk8dHhZMJcyYRsl4xyGFH/pMCVtELyP6I0Tv5UotlR4MZ9JHSmrvjp 5JTcKDL6jnInPZtChUb94vqvw9hC5rykH4Fj03aDq1olr6AetuiQkL8a8eaHpRi2xGUF4uByu1N8l UhWyWCyg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEa-002CWW-Mv; Fri, 27 May 2022 15:50:40 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 06/24] hfsplus: Remove check for PageError Date: Fri, 27 May 2022 16:50:18 +0100 Message-Id: <20220527155036.524743-7-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=r2pTcvZX; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 95CF3A0049 X-Stat-Signature: fynqfic4i8ur1uyr7ik41r83enwj3ecn X-HE-Tag: 1653666633-447141 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If read_mapping_page() encounters an error, it returns an errno, not a page with PageError set, so this is dead code. Signed-off-by: Matthew Wilcox (Oracle) --- fs/hfsplus/bnode.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/hfsplus/bnode.c b/fs/hfsplus/bnode.c index 177fae4e6581..a5ab00e54220 100644 --- a/fs/hfsplus/bnode.c +++ b/fs/hfsplus/bnode.c @@ -447,10 +447,6 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid) page = read_mapping_page(mapping, block, NULL); if (IS_ERR(page)) goto fail; - if (PageError(page)) { - put_page(page); - goto fail; - } node->page[i] = page; } -- 2.34.1