From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44C5C433EF for ; Fri, 27 May 2022 15:51:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42E8E8D0037; Fri, 27 May 2022 11:51:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 391398D002F; Fri, 27 May 2022 11:51:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B6918D0037; Fri, 27 May 2022 11:51:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 03BB38D002F for ; Fri, 27 May 2022 11:51:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D321620B70 for ; Fri, 27 May 2022 15:51:09 +0000 (UTC) X-FDA: 79511961858.30.B97183E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 74BEA180062 for ; Fri, 27 May 2022 15:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=XjQP/FhIMNNRCHBvtTQpbw+sDJqqK43i6MI8xDK6ue4=; b=s/SNQOmeia3GYJViS3bMI/vt9F p1fx2sT3rnf6oVTVudcF+/ZPI83MYVnblbDR7d5iALZpV5fYuEmP75M9lQZCp+7F+MjBu+MKTU8Kr KMp5kmB8yCJiyKsSUrW1OVq5qWgE+eHSsRIDmvTMtBwqL3ZCP1yJmUNZu7eies+fgLLh1r4jmxJh4 MDGzcYx1T8GVus8gV7jHg+wzVvFtDNmJgoy78NGA1sj+U4HlTpuKiUKBNH0tumD+fCW3s5Eim5ipe O6abP0bvbUG1oZ8EddBj7G0qjrRc3gqNvyGVt9swuAckGmfALxap68pRqBLMAoXy9hPGONDpxdzLX ijeunrQQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEa-002CWa-RE; Fri, 27 May 2022 15:50:40 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 08/24] ext2: Remove check for PageError Date: Fri, 27 May 2022 16:50:20 +0100 Message-Id: <20220527155036.524743-9-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: hjhgufwpzng45twejnfb4emaa8wzoobh Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="s/SNQOme"; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 74BEA180062 X-HE-Tag: 1653666654-826166 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If read_mapping_page() encounters an error, it returns an errno, not a page with PageError set, so this test is not needed. Signed-off-by: Matthew Wilcox (Oracle) --- fs/ext2/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c index 2c2f179b6977..3410e4132405 100644 --- a/fs/ext2/dir.c +++ b/fs/ext2/dir.c @@ -204,8 +204,7 @@ static struct page * ext2_get_page(struct inode *dir, unsigned long n, if (!IS_ERR(page)) { *page_addr = kmap_local_page(page); if (unlikely(!PageChecked(page))) { - if (PageError(page) || !ext2_check_page(page, quiet, - *page_addr)) + if (!ext2_check_page(page, quiet, *page_addr)) goto fail; } } -- 2.34.1