From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F035C433EF for ; Mon, 30 May 2022 21:17:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F26246B0072; Mon, 30 May 2022 17:17:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDA146B0073; Mon, 30 May 2022 17:17:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC3F36B0074; Mon, 30 May 2022 17:17:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CF6666B0072 for ; Mon, 30 May 2022 17:17:14 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A2C0F6013A for ; Mon, 30 May 2022 21:17:14 +0000 (UTC) X-FDA: 79523669988.21.4110BB5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 07C96C004B for ; Mon, 30 May 2022 21:16:31 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C84F60F77; Mon, 30 May 2022 21:17:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C217C385B8; Mon, 30 May 2022 21:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1653945432; bh=aXsj1AN3iBU3BXc0wD+tbUHvcr/SpDhRS0i5ip2Fcl8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q3B/aOrqXsxw/hc5+6ZVsej/3uJqaMiGaW+7fR+NImiQeu4ORuUaQQE8mOE9NDECH lxW5h+8c7Rqvbtz53LzjdCSZ9LK4CMcNT8D5zIlUOxI2ybjChjYcFYfpFtbYpQYSJn Gyi9yVtiJxVuHdQBYMqy4NfacbOFu1m7vQ/NURxw= Date: Mon, 30 May 2022 14:17:11 -0700 From: Andrew Morton To: Muchun Song Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v5 00/11] Use obj_cgroup APIs to charge the LRU pages Message-Id: <20220530141711.6cf70dcf200e28aa40407f6e@linux-foundation.org> In-Reply-To: <20220530074919.46352-1-songmuchun@bytedance.com> References: <20220530074919.46352-1-songmuchun@bytedance.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 07C96C004B X-Rspam-User: X-Stat-Signature: u3iorzkyxcgcd86tmw9tytp5k9f8fhba Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="q3B/aOrq"; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1653945391-298927 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 30 May 2022 15:49:08 +0800 Muchun Song wrote: > This version is rebased on v5.18. Not a great choice of base, really. mm-stable or mm-unstable or linux-next or even linus-of-the-day are all much more up to date. Although the memcg reviewer tags are pretty thin, I was going to give it a run. But after fixing a bunch of conflicts I got about halfway through then gave up on a big snarl in get_obj_cgroup_from_current(). > RFC v1: https://lore.kernel.org/all/20210330101531.82752-1-songmuchun@bytedance.com/ Surprising, that was over a year ago. Why has is taken so long?