From: kernel test robot <lkp@intel.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: [linux-next:master 13472/14198] include/linux/workqueue.h:610:2: error: call to __warn_flushing_systemwide_wq declared with 'warning' attribute: Please avoid flushing system-wide workqueues.
Date: Mon, 30 May 2022 14:59:52 +0800 [thread overview]
Message-ID: <202205301443.2n5yYq7Y-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: d3fde8ff50ab265749704bd7fbcf70d35235421f
commit: e449c388913ccd36641f7cc0c335029a7cc161f4 [13472/14198] workqueue: Wrap flush_workqueue() using an inline function
config: x86_64-randconfig-a014-20220530 (https://download.01.org/0day-ci/archive/20220530/202205301443.2n5yYq7Y-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0776c48f9b7e69fa447bee57c7c0985caa856be9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=e449c388913ccd36641f7cc0c335029a7cc161f4
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout e449c388913ccd36641f7cc0c335029a7cc161f4
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/display/intel_display.c:28:
In file included from include/linux/i2c.h:13:
In file included from include/linux/acpi.h:13:
In file included from include/linux/irqdomain.h:35:
In file included from include/linux/of.h:17:
In file included from include/linux/kobject.h:20:
In file included from include/linux/sysfs.h:16:
In file included from include/linux/kernfs.h:12:
In file included from include/linux/idr.h:15:
In file included from include/linux/radix-tree.h:12:
In file included from include/linux/gfp.h:6:
In file included from include/linux/mmzone.h:21:
In file included from include/linux/mm_types.h:18:
>> include/linux/workqueue.h:610:2: error: call to __warn_flushing_systemwide_wq declared with 'warning' attribute: Please avoid flushing system-wide workqueues. [-Werror,-Wattribute-warning]
__warn_flushing_systemwide_wq();
^
1 error generated.
vim +/warning +610 include/linux/workqueue.h
565
566 /*
567 * Detect attempt to flush system-wide workqueues at compile time when possible.
568 *
569 * See https://lkml.kernel.org/r/49925af7-78a8-a3dd-bce6-cfc02e1a9236@I-love.SAKURA.ne.jp
570 * for reasons and steps for converting system-wide workqueues into local workqueues.
571 */
572 extern void __warn_flushing_systemwide_wq(void)
573 __compiletime_warning("Please avoid flushing system-wide workqueues.");
574
575 /**
576 * flush_scheduled_work - ensure that any scheduled work has run to completion.
577 *
578 * Forces execution of the kernel-global workqueue and blocks until its
579 * completion.
580 *
581 * It's very easy to get into trouble if you don't take great care.
582 * Either of the following situations will lead to deadlock:
583 *
584 * One of the work items currently on the workqueue needs to acquire
585 * a lock held by your code or its caller.
586 *
587 * Your code is running in the context of a work routine.
588 *
589 * They will be detected by lockdep when they occur, but the first might not
590 * occur very often. It depends on what work items are on the workqueue and
591 * what locks they need, which you have no control over.
592 *
593 * In most situations flushing the entire workqueue is overkill; you merely
594 * need to know that a particular work item isn't queued and isn't running.
595 * In such cases you should use cancel_delayed_work_sync() or
596 * cancel_work_sync() instead.
597 *
598 * Please stop calling this function! A conversion to stop flushing system-wide
599 * workqueues is in progress. This function will be removed after all in-tree
600 * users stopped calling this function.
601 */
602 static inline void flush_scheduled_work(void)
603 {
604 #if !defined(CONFIG_WERROR) && defined(CONFIG_PROVE_LOCKING)
605 /*
606 * Warn only if emitting warning message does not cause build failure
607 * and the developer wants warning about possibility of deadlock, for
608 * there are currently in-tree flush_scheduled_work() users.
609 */
> 610 __warn_flushing_systemwide_wq();
611 #endif
612 __flush_workqueue(system_wq);
613 }
614
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-05-30 7:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205301443.2n5yYq7Y-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).