From: Andrew Morton <akpm@linux-foundation.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Phillip Lougher <phillip@squashfs.org.uk>,
Matthew Wilcox <willy@infradead.org>,
Xiongwei Song <Xiongwei.Song@windriver.com>,
Zheng Liang <zhengliang6@huawei.com>,
Zhang Yi <yi.zhang@huawei.com>, Hou Tao <houtao1@huawei.com>,
Miao Xie <miaoxie@huawei.com>,
"linux-mm @ kvack . org" <linux-mm@kvack.org>,
"squashfs-devel @ lists . sourceforge . net"
<squashfs-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] squashfs: implement readahead
Date: Tue, 31 May 2022 13:48:09 -0700 [thread overview]
Message-ID: <20220531134809.c69b711dc8cd584b3a5163f7@linux-foundation.org> (raw)
In-Reply-To: <CAJMQK-isVhkhGu3=QAWaDvOd9sXgNep3ZrZ6jjoa2j+h6Uc45w@mail.gmail.com>
On Tue, 31 May 2022 17:51:11 +0800 Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> On Mon, May 23, 2022 at 3:00 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> >
> > Implement readahead callback for squashfs. It will read datablocks
> > which cover pages in readahead request. For a few cases it will
> > not mark page as uptodate, including:
> > - file end is 0.
> > - zero filled blocks.
> > - current batch of pages isn't in the same datablock or not enough in a
> > datablock.
> > - decompressor error.
> > Otherwise pages will be marked as uptodate. The unhandled pages will be
> > updated by readpage later.
> >
> > Suggested-by: Matthew Wilcox <willy@infradead.org>
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > Reported-by: Matthew Wilcox <willy@infradead.org>
> > Reported-by: Phillip Lougher <phillip@squashfs.org.uk>
> > Reported-by: Xiongwei Song <Xiongwei.Song@windriver.com>
> > ---
>
> Kindly ping on the thread. Conversations on v2:
> https://patchwork.kernel.org/project/linux-mm/patch/20220517082650.2005840-4-hsinyi@chromium.org/#24869037
> This version mainly addressed the error handling.
Yes, some reviewer input would be helpful please.
next prev parent reply other threads:[~2022-05-31 20:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 6:59 [PATCH v3 0/3] Implement readahead for squashfs Hsin-Yi Wang
2022-05-23 6:59 ` [PATCH v3 1/3] Revert "squashfs: provide backing_dev_info in order to disable read-ahead" Hsin-Yi Wang
2022-05-23 6:59 ` [PATCH v3 2/3] squashfs: always build "file direct" version of page actor Hsin-Yi Wang
2022-05-23 6:59 ` [PATCH v3 3/3] squashfs: implement readahead Hsin-Yi Wang
2022-05-31 9:51 ` Hsin-Yi Wang
2022-05-31 20:48 ` Andrew Morton [this message]
2022-05-31 20:47 ` Andrew Morton
2022-05-31 20:56 ` Matthew Wilcox
2022-06-01 1:08 ` Phillip Lougher
2022-06-01 8:36 ` Hsin-Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531134809.c69b711dc8cd584b3a5163f7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Xiongwei.Song@windriver.com \
--cc=houtao1@huawei.com \
--cc=hsinyi@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miaoxie@huawei.com \
--cc=phillip@squashfs.org.uk \
--cc=squashfs-devel@lists.sourceforge.net \
--cc=willy@infradead.org \
--cc=yi.zhang@huawei.com \
--cc=zhengliang6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).