From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E47A9C433EF for ; Tue, 31 May 2022 20:48:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62FDD6B0073; Tue, 31 May 2022 16:48:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E2136B0074; Tue, 31 May 2022 16:48:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F3CA6B0075; Tue, 31 May 2022 16:48:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4076C6B0073 for ; Tue, 31 May 2022 16:48:14 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1579A34D10 for ; Tue, 31 May 2022 20:48:14 +0000 (UTC) X-FDA: 79527225708.24.614DC16 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id A78DB4005D for ; Tue, 31 May 2022 20:48:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8E242B8111E; Tue, 31 May 2022 20:48:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7333C385A9; Tue, 31 May 2022 20:48:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1654030090; bh=ysy0TefitjEGZN/cpuj1jy1DC0AsC3nMzkC1TZQoJA0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mI3a0M2JvTvh3EKbICw3GdfOV/NwYO3Wuzq3OPGLHFYTVOoom6OAoKDIvN63xzYWp qZG8Yb3djUJRrmNZXwSRlSUqyaCr54hm9rs3Bo64ao7QhWFZ037eetzoLl9uRTWwSp kcqTUtym8YOCtTjk0+Y0MViqyTFFUO4xhFQpvdYU= Date: Tue, 31 May 2022 13:48:09 -0700 From: Andrew Morton To: Hsin-Yi Wang Cc: Phillip Lougher , Matthew Wilcox , Xiongwei Song , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , "linux-mm @ kvack . org" , "squashfs-devel @ lists . sourceforge . net" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] squashfs: implement readahead Message-Id: <20220531134809.c69b711dc8cd584b3a5163f7@linux-foundation.org> In-Reply-To: References: <20220523065909.883444-1-hsinyi@chromium.org> <20220523065909.883444-4-hsinyi@chromium.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 6erwweebheoetmgxkoqte931i4x6pnq3 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mI3a0M2J; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A78DB4005D X-HE-Tag: 1654030089-514673 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 31 May 2022 17:51:11 +0800 Hsin-Yi Wang wrote: > On Mon, May 23, 2022 at 3:00 PM Hsin-Yi Wang wrote: > > > > Implement readahead callback for squashfs. It will read datablocks > > which cover pages in readahead request. For a few cases it will > > not mark page as uptodate, including: > > - file end is 0. > > - zero filled blocks. > > - current batch of pages isn't in the same datablock or not enough in a > > datablock. > > - decompressor error. > > Otherwise pages will be marked as uptodate. The unhandled pages will be > > updated by readpage later. > > > > Suggested-by: Matthew Wilcox > > Signed-off-by: Hsin-Yi Wang > > Reported-by: Matthew Wilcox > > Reported-by: Phillip Lougher > > Reported-by: Xiongwei Song > > --- > > Kindly ping on the thread. Conversations on v2: > https://patchwork.kernel.org/project/linux-mm/patch/20220517082650.2005840-4-hsinyi@chromium.org/#24869037 > This version mainly addressed the error handling. Yes, some reviewer input would be helpful please.