From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE43BC43334 for ; Mon, 6 Jun 2022 22:23:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02B1A6B0072; Mon, 6 Jun 2022 18:23:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1C8C6B0073; Mon, 6 Jun 2022 18:23:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0C7E6B0074; Mon, 6 Jun 2022 18:23:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D33256B0072 for ; Mon, 6 Jun 2022 18:23:37 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A631120B56 for ; Mon, 6 Jun 2022 22:23:37 +0000 (UTC) X-FDA: 79549238874.19.C551297 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 880824004E for ; Mon, 6 Jun 2022 22:23:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CCACB60AC9; Mon, 6 Jun 2022 22:23:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42BC9C385A9; Mon, 6 Jun 2022 22:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1654554215; bh=JZ0UpJtHHjla2Dq2f0QkMMByOOYz1XZOSWxRugg/TfQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mjrIrsn/7emy1a0dMZIwXVghr21T4LgYBrLp2VVu3dlKYB2V+/IaVyFY+ggJ7hp2m IgihDET1DJoEIiLe6l1ucqHQANzb/HWWpoJXGjMC6pWIadQHQfz1L4TPcERCpZ/XeG GKXtUk8dYlwES1tgJ+/7tqAHMv9jV96VbYXRgE2M= Date: Mon, 6 Jun 2022 15:23:33 -0700 From: Andrew Morton To: "Zach O'Keefe" Cc: kernel test robot , Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, kbuild-all@lists.01.org, Andrea Arcangeli , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin Subject: Re: [PATCH v6 03/15] mm/khugepaged: add struct collapse_control Message-Id: <20220606152333.6f06f2e23a1161e444fa0f8d@linux-foundation.org> In-Reply-To: References: <20220604004004.954674-4-zokeefe@google.com> <202206060911.I8rRqGwC-lkp@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="mjrIrsn/"; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 880824004E X-Rspam-User: X-Stat-Signature: ooegmj9ytxjot8rbq6n1sptqc5yqhkfr X-HE-Tag: 1654554195-360243 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 6 Jun 2022 09:40:20 -0700 "Zach O'Keefe" wrote: > On Sun, Jun 5, 2022 at 7:42 PM kernel test robot wrote: > > > > Hi Zach, > > > > Thank you for the patch! Perhaps something to improve: > > > > [auto build test WARNING on akpm-mm/mm-everything] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-userspace-hugepage-collapse/20220606-012953 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20220606/202206060911.I8rRqGwC-lkp@intel.com/config) > > compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 > > reproduce (this is a W=1 build): > > # https://github.com/intel-lab-lkp/linux/commit/d87b6065d6050b89930cca0814921aca7c269286 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review Zach-O-Keefe/mm-userspace-hugepage-collapse/20220606-012953 > > git checkout d87b6065d6050b89930cca0814921aca7c269286 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > mm/khugepaged.c: In function 'khugepaged': > > >> mm/khugepaged.c:2284:1: warning: the frame size of 4160 bytes is larger than 2048 bytes [-Wframe-larger-than=] > > 2284 | } > > | ^ > > Thanks lkp@intel.com. > > This is due to config with: > > CONFIG_FRAME_WARN=2048 > CONFIG_NODES_SHIFT=10 > > Where struct collapse_control has a member int > node_load[MAX_NUMNODES], and we stack allocate one. > > Is this a configuration that needs to be supported? 1024 nodes seems > like a lot and I'm not sure if these configs are randomly generated or > are reminiscent of real systems. Adding 4k to the stack isn't a good thing to do. It's trivial to kmalloc the thing, so why not do that? I'll await some reviewer input (hopefully positive ;)) before merging this series.