From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE0CC433EF for ; Wed, 8 Jun 2022 00:01:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04E8F6B0071; Tue, 7 Jun 2022 20:01:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 026C96B0072; Tue, 7 Jun 2022 20:01:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E56B66B0073; Tue, 7 Jun 2022 20:01:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D56D26B0071 for ; Tue, 7 Jun 2022 20:01:30 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id A1773120EDF for ; Wed, 8 Jun 2022 00:01:30 +0000 (UTC) X-FDA: 79553114340.06.3352461 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf13.hostedemail.com (Postfix) with ESMTP id 4605220077 for ; Wed, 8 Jun 2022 00:01:28 +0000 (UTC) Received: by mail-ej1-f47.google.com with SMTP id v1so27567864ejg.13 for ; Tue, 07 Jun 2022 17:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BbtiLiOJU0rTXaLM0hDshg4m31VYD4/CJhwA3wxcIfY=; b=UEbSN7CqnGLPUgHOCHUnxVgvcwwH5fIjCRkDU1hMHEOw3O6Crn+zFT4cHbt26zWAIE 8N37tZnKa2IQm97YWALddX+9sX5+eUdSGgLUjTzkUqGjd8eF/munkHc/iMXNVyIQulDr RzbvLPuA7QuYsQ2rp6uFK7J90q2o99MR/JxvoP1OAXLS/i1XFkjUHB5dMmTRPvkqrKN1 GVlnO15zjvzdRH/a9AZT92GfOjEnw3KTd/XmxNJvNtOd6X7CXsn2ckNAviyYg0+ZlzRg 9Ks+ItmnXrzSqHobsOovoV7ncr9CtW9Vq3iZguF++zTcNjSYE725THejD4ccN1rYOdeo eKIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BbtiLiOJU0rTXaLM0hDshg4m31VYD4/CJhwA3wxcIfY=; b=EAghi/BW0bONoUNoCkMR4DsBKcGR1GJRJduBlpBknhW60xSdBFaS5AsaR6CXVw+x1Z bw2hQ8CJDB9/Yd4UGocqPd9ZiLkV64SBV0cHtn1u6YdBUhPD5ngZU0JEebnxDYXsXGue tMW95IxSYdKxs+SokaQscAcmBsMMP/0Kiu4h2HXF50Dp5Pd7d5MTXb+XQXRbWF+L05nL tpJ0OwPHUmu2frJZ6lz1fn4t46ryGsDYhTPqM4cjgzt/3GfTGw6dYcj/cjNa9R7fxvS6 ky112jcV4Qajc252JXDBTgT+M5cNIf/DwNZJh3/MpQ0fif1YAqRG59b4GIwmTSQqskCX HCoQ== X-Gm-Message-State: AOAM5327sBgkz7jx2pmIKCUG/+bfnV0wnlmmf24dA5aA9wg2T/eKv8QH O8cYedTIU41dqg59fEcQX/Y= X-Google-Smtp-Source: ABdhPJy47AJ9g+udmP2NQVg/F+sAWua/3HNM6FM8/NI+MyAJiUqdrDek1YV+kEU4eBlEYg5lhWQe1Q== X-Received: by 2002:a17:906:99c5:b0:6fe:b069:4ab6 with SMTP id s5-20020a17090699c500b006feb0694ab6mr29042371ejn.436.1654646487635; Tue, 07 Jun 2022 17:01:27 -0700 (PDT) Received: from mail (239.125-180-91.adsl-dyn.isp.belgacom.be. [91.180.125.239]) by smtp.gmail.com with ESMTPSA id z11-20020a05640240cb00b0042e17781fc5sm9790817edb.49.2022.06.07.17.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 17:01:26 -0700 (PDT) Date: Wed, 8 Jun 2022 02:01:25 +0200 From: Luc Van Oostenryck To: Ankur Arora Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, mingo@kernel.org, luto@kernel.org, tglx@linutronix.de, bp@alien8.de, peterz@infradead.org, ak@linux.intel.com, arnd@arndb.de, jgg@nvidia.com, jon.grimm@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, joao.m.martins@oracle.com Subject: Re: [PATCH v3 13/21] clear_page: add generic clear_user_pages_incoherent() Message-ID: <20220608000125.na6z3niyv4ty7xn7@mail> References: <20220606202109.1306034-1-ankur.a.arora@oracle.com> <20220606203725.1313715-9-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220606203725.1313715-9-ankur.a.arora@oracle.com> X-Rspamd-Queue-Id: 4605220077 X-Stat-Signature: uegoj9byddpez7ci887ugb1kohsqd115 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=UEbSN7Cq; spf=pass (imf13.hostedemail.com: domain of luc.vanoostenryck@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=luc.vanoostenryck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam08 X-HE-Tag: 1654646488-944575 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 06, 2022 at 08:37:17PM +0000, Ankur Arora wrote: > +static inline void clear_user_pages_incoherent(__incoherent void *page, > + unsigned long vaddr, > + struct page *pg, > + unsigned int npages) > +{ > + clear_user_pages((__force void *)page, vaddr, pg, npages); > +} Hi, Please use 'void __incoherent *' and 'void __force *', as it's done elsewhere for __force and address spaces. -- Luc