From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 478E5C43334 for ; Mon, 20 Jun 2022 09:18:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D28FF6B0089; Mon, 20 Jun 2022 05:18:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB2E48E0006; Mon, 20 Jun 2022 05:18:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B525C8E0005; Mon, 20 Jun 2022 05:18:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9F4FD6B0089 for ; Mon, 20 Jun 2022 05:18:17 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6E0E633445 for ; Mon, 20 Jun 2022 09:18:17 +0000 (UTC) X-FDA: 79598063034.28.6F98577 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf01.hostedemail.com (Postfix) with ESMTP id B6E2C40017 for ; Mon, 20 Jun 2022 09:18:16 +0000 (UTC) Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LRP9D6GQHz687RF; Mon, 20 Jun 2022 17:14:24 +0800 (CST) Received: from lhreml751-chm.china.huawei.com (10.201.108.201) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 20 Jun 2022 11:18:14 +0200 Received: from localhost (10.202.227.118) by lhreml751-chm.china.huawei.com (10.201.108.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 20 Jun 2022 10:18:13 +0100 Date: Mon, 20 Jun 2022 10:18:12 +0100 From: Hesham Almatary To: Aneesh Kumar K.V CC: , , Wei Xu , Huang Ying , Greg Thelen , Yang Shi , Davidlohr Bueso , Tim C Chen , Brice Goglin , Michal Hocko , "Linux Kernel Mailing List" , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Feng Tang , Jagdish Gediya , Baolin Wang , "David Rientjes" Subject: Re: [PATCH v6 00/13] mm/demotion: Memory tiers and demotion Message-ID: <20220620101812.000010ee@huawei.com> In-Reply-To: <20220610135006.182507-1-aneesh.kumar@linux.ibm.com> References: <20220610135006.182507-1-aneesh.kumar@linux.ibm.com> Organization: Huawei UK R&D X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.118] X-ClientProxiedBy: lhreml733-chm.china.huawei.com (10.201.108.84) To lhreml751-chm.china.huawei.com (10.201.108.201) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655716697; a=rsa-sha256; cv=none; b=qVmjVRpc7/gO6mQHJpQaEwfgoQ4bTRQoxVCwb8QnZ0OXGGBTWfemrRsjlArrq/uhJqkGph PhCFA2S0GoLKvjH/xRTbK5lkV3My8ey6jNza7xiC2dOgZBD6z0zgx9ImdLPjn+KKZH17Cj 7w9hqjBXLg1wloPxZOQQ390q+UGuqss= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of hesham.almatary@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=hesham.almatary@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655716697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T9zj1hLAb5MYb20krAX/akUYvTHCvFEIe3F1rMenvbE=; b=wmrRrT3JuqXjgvNIz/MsFoZs8C1LyIetT75BXsiXMgqEzwY0MCJ5obUhlIPW83/z36YYAi IVNhpSW40WhPwTDLNTmiXpwIywZVqUA10JN0EhssmJu4RtBeLMj5lnjtB9ucTxtVnlJwNC 2kuG1Sw2h32VvFh90KtNUj895VPQmcI= Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of hesham.almatary@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=hesham.almatary@huawei.com X-Stat-Signature: o5b1f35aa5kb5ozbdxdfdgb1yfmefp93 X-Rspamd-Queue-Id: B6E2C40017 X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1655716696-870774 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 10 Jun 2022 19:19:53 +0530 "Aneesh Kumar K.V" wrote: > The current kernel has the basic memory tiering support: Inactive > pages on a higher tier NUMA node can be migrated (demoted) to a lower > tier NUMA node to make room for new allocations on the higher tier > NUMA node. Frequently accessed pages on a lower tier NUMA node can be > migrated (promoted) to a higher tier NUMA node to improve the > performance. > > In the current kernel, memory tiers are defined implicitly via a > demotion path relationship between NUMA nodes, which is created during > the kernel initialization and updated when a NUMA node is hot-added or > hot-removed. The current implementation puts all nodes with CPU into > the top tier, and builds the tier hierarchy tier-by-tier by > establishing the per-node demotion targets based on the distances > between nodes. > > This current memory tier kernel interface needs to be improved for > several important use cases: > > * The current tier initialization code always initializes > each memory-only NUMA node into a lower tier. But a memory-only > NUMA node may have a high performance memory device (e.g. a DRAM > device attached via CXL.mem or a DRAM-backed memory-only node on > a virtual machine) and should be put into a higher tier. > > * The current tier hierarchy always puts CPU nodes into the top > tier. But on a system with HBM (e.g. GPU memory) devices, these > memory-only HBM NUMA nodes should be in the top tier, and DRAM nodes > with CPUs are better to be placed into the next lower tier. > > * Also because the current tier hierarchy always puts CPU nodes > into the top tier, when a CPU is hot-added (or hot-removed) and > triggers a memory node from CPU-less into a CPU node (or vice > versa), the memory tier hierarchy gets changed, even though no > memory node is added or removed. This can make the tier > hierarchy unstable and make it difficult to support tier-based > memory accounting. > > * A higher tier node can only be demoted to selected nodes on the > next lower tier as defined by the demotion path, not any other > node from any lower tier. This strict, hard-coded demotion order > does not work in all use cases (e.g. some use cases may want to > allow cross-socket demotion to another node in the same demotion > tier as a fallback when the preferred demotion node is out of > space), and has resulted in the feature request for an interface to > override the system-wide, per-node demotion order from the > userspace. This demotion order is also inconsistent with the page > allocation fallback order when all the nodes in a higher tier are > out of space: The page allocation can fall back to any node from > any lower tier, whereas the demotion order doesn't allow that. > > * There are no interfaces for the userspace to learn about the memory > tier hierarchy in order to optimize its memory allocations. > > This patch series make the creation of memory tiers explicit under > the control of userspace or device driver. > > Memory Tier Initialization > ========================== > > By default, all memory nodes are assigned to the default tier (1). > The default tier device has a rank value (200). > > A device driver can move up or down its memory nodes from the default > tier. For example, PMEM can move down its memory nodes below the > default tier, whereas GPU can move up its memory nodes above the > default tier. > > The kernel initialization code makes the decision on which exact tier > a memory node should be assigned to based on the requests from the > device drivers as well as the memory device hardware information > provided by the firmware. > > Hot-adding/removing CPUs doesn't affect memory tier hierarchy. > > Memory Allocation for Demotion > ============================== > This patch series keep the demotion target page allocation logic same. > The demotion page allocation pick the closest NUMA node in the > next lower tier to the current NUMA node allocating pages from. > > This will be later improved to use the same page allocation strategy > using fallback list. > > Sysfs Interface: > ======================= > Listing current list of memory tiers and rank details: > > :/sys/devices/system/memtier$ ls > default_tier max_tier memtier1 power uevent > :/sys/devices/system/memtier$ cat default_tier > memtier1 > :/sys/devices/system/memtier$ cat max_tier > 3 Should this be renamed to max_tiers or tiers_count? Otherwise one might confuse max_tier as the highest allowed tier ID. > :/sys/devices/system/memtier$ > > Per node memory tier details: > > For a cpu only NUMA node: > > :/sys/devices/system/node# cat node0/memtier > :/sys/devices/system/node# echo 1 > node0/memtier > :/sys/devices/system/node# cat node0/memtier > :/sys/devices/system/node# > > For a NUMA node with memory: > :/sys/devices/system/node# cat node1/memtier > 1 > :/sys/devices/system/node# ls ../memtier/ > default_tier max_tier memtier1 power uevent > :/sys/devices/system/node# echo 2 > node1/memtier > :/sys/devices/system/node# > :/sys/devices/system/node# ls ../memtier/ > default_tier max_tier memtier1 memtier2 power uevent > :/sys/devices/system/node# cat node1/memtier > 2 > :/sys/devices/system/node# > :/sys/devices/system/node# cat ../memtier/memtier2/rank > 100 > :/sys/devices/system/node# > :/sys/devices/system/node# cat ../memtier/memtier1/rank > 200 > :/sys/devices/system/node# > > Removing a NUMA node from demotion: > :/sys/devices/system/node# cat node1/memtier > 2 > :/sys/devices/system/node# echo none > node1/memtier > :/sys/devices/system/node# > :/sys/devices/system/node# cat node1/memtier > :/sys/devices/system/node# > :/sys/devices/system/node# ls ../memtier/ > default_tier max_tier memtier1 power uevent > :/sys/devices/system/node# > > The above also resulted in removal of memtier2 which was created in > the earlier step. > > > Changes from v5: > * Remove patch supporting N_MEMORY node removal from memory tiers. > memory tiers are going to be used for features other than demotion. > Hence keep all N_MEMORY nodes in memory tiers irrespective of whether > they want to participate in promotion or demotion. > * Add NODE_DATA->memtier > * Rearrage patches to add sysfs files later. > * Add support to create memory tiers from userspace. > * Address other review feedback. > > > Changes from v4: > * Address review feedback. > * Reverse the meaning of "rank": higher rank value means higher tier. > * Add "/sys/devices/system/memtier/default_tier". > * Add node_is_toptier > > v4: > Add support for explicit memory tiers and ranks. > > v3: > - Modify patch 1 subject to make it more specific > - Remove /sys/kernel/mm/numa/demotion_targets interface, use > /sys/devices/system/node/demotion_targets instead and make > it writable to override node_states[N_DEMOTION_TARGETS]. > - Add support to view per node demotion targets via sysfs > > v2: > In v1, only 1st patch of this patch series was sent, which was > implemented to avoid some of the limitations on the demotion > target sharing, however for certain numa topology, the demotion > targets found by that patch was not most optimal, so 1st patch > in this series is modified according to suggestions from Huang > and Baolin. Different examples of demotion list comparasion > between existing implementation and changed implementation can > be found in the commit message of 1st patch. > > > Aneesh Kumar K.V (11): > mm/demotion: Add support for explicit memory tiers > mm/demotion: Move memory demotion related code > mm/demotion: Return error on write to numa_demotion sysfs > mm/demotion/dax/kmem: Set node's memory tier to MEMORY_TIER_PMEM > mm/demotion: Build demotion targets based on explicit memory tiers > mm/demotion: Expose memory tier details via sysfs > mm/demotion: Add per node memory tier attribute to sysfs > mm/demotion: Add support for memory tier creation from userspace > mm/demotion: Add pg_data_t member to track node memory tier details > mm/demotion: Update node_is_toptier to work with memory tiers > mm/demotion: Add sysfs ABI documentation > > Jagdish Gediya (2): > mm/demotion: Demote pages according to allocation fallback order > mm/demotion: Add documentation for memory tiering > > .../ABI/testing/sysfs-kernel-mm-memory-tiers | 87 ++ > Documentation/admin-guide/mm/index.rst | 1 + > .../admin-guide/mm/memory-tiering.rst | 181 ++++ > drivers/base/node.c | 39 + > drivers/dax/kmem.c | 4 + > include/linux/memory-tiers.h | 63 ++ > include/linux/migrate.h | 15 - > include/linux/mmzone.h | 3 + > include/linux/node.h | 5 - > mm/Kconfig | 3 + > mm/Makefile | 1 + > mm/huge_memory.c | 1 + > mm/memory-tiers.c | 888 > ++++++++++++++++++ mm/migrate.c | > 453 +-------- mm/mprotect.c | 1 + > mm/vmscan.c | 57 +- > mm/vmstat.c | 4 - > 17 files changed, 1316 insertions(+), 490 deletions(-) > create mode 100644 > Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers create mode > 100644 Documentation/admin-guide/mm/memory-tiering.rst create mode > 100644 include/linux/memory-tiers.h create mode 100644 > mm/memory-tiers.c >