From: Gautam <gautammenghani201@gmail.com>
To: sj@kernel.org, shuah@kernel.org
Cc: Gautam <gautammenghani201@gmail.com>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] kselftests/damon: add support for cases where debugfs cannot be read
Date: Sat, 25 Jun 2022 11:26:08 +0530 [thread overview]
Message-ID: <20220625055608.12812-1-gautammenghani201@gmail.com> (raw)
In-Reply-To: <20220624202921.80867-1-sj@kernel.org>
The kernel is in lockdown mode when secureboot is enabled and hence
debugfs cannot be used. Add support for this and other general cases
where debugfs cannot be read and communicate the same to the user before
running tests.
Signed-off-by: Gautam <gautammenghani201@gmail.com>
---
Changes in v2:
1. Modify the error message to account for general cases.
2. Change the return code so that the test is skipped.
tools/testing/selftests/damon/_chk_dependency.sh | 10 ++++++++++
1 file changed, 10 insertions(+)
mode change 100644 => 100755 tools/testing/selftests/damon/_chk_dependency.sh
diff --git a/tools/testing/selftests/damon/_chk_dependency.sh b/tools/testing/selftests/damon/_chk_dependency.sh
old mode 100644
new mode 100755
index 0189db81550b..aae7ff8c2080
--- a/tools/testing/selftests/damon/_chk_dependency.sh
+++ b/tools/testing/selftests/damon/_chk_dependency.sh
@@ -26,3 +26,13 @@ do
exit 1
fi
done
+
+secureboot_error="Operation not permitted"
+for f in attrs target_ids monitor_on
+do
+ status=$( cat "$DBGFS/$f" 2>&1 )
+ if [ "${status#*$secureboot_error}" != "$status" ]; then
+ echo "Permission for reading $DBGFS/$f denied; maybe secureboot enabled?"
+ exit $ksft_skip
+ fi
+done
--
2.36.1
next prev parent reply other threads:[~2022-06-25 5:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 19:52 [PATCH] kselftests/damon: add support for checking secureboot status Gautam
2022-06-24 20:29 ` SeongJae Park
2022-06-25 5:56 ` Gautam [this message]
2022-06-25 8:35 ` [PATCH v3] kselftests/damon: add support for cases where debugfs cannot be read Gautam
2022-06-25 18:55 ` SeongJae Park
2022-06-25 19:52 ` [PATCH v4] " Gautam
2022-06-25 20:03 ` SeongJae Park
2022-06-27 17:00 ` Shuah Khan
2022-06-27 18:57 ` SeongJae Park
2022-06-27 19:46 ` Shuah Khan
[not found] ` <Yrn6BxU298rzjiak@fedora>
2022-06-28 3:37 ` Gautam Menghani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220625055608.12812-1-gautammenghani201@gmail.com \
--to=gautammenghani201@gmail.com \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).