From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A827C433EF for ; Sat, 25 Jun 2022 23:59:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BA606B0071; Sat, 25 Jun 2022 19:59:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46A6C6B0072; Sat, 25 Jun 2022 19:59:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 333476B0073; Sat, 25 Jun 2022 19:59:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 205F66B0071 for ; Sat, 25 Jun 2022 19:59:08 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DBA8D327EE for ; Sat, 25 Jun 2022 23:59:07 +0000 (UTC) X-FDA: 79618426734.05.A946AA9 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf04.hostedemail.com (Postfix) with ESMTP id 6B91E40021 for ; Sat, 25 Jun 2022 23:59:07 +0000 (UTC) Received: by mail-qv1-f52.google.com with SMTP id t16so10023119qvh.1 for ; Sat, 25 Jun 2022 16:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OIkvZSCfU1CjrPejBudrIGntnY32egXHLdKIcmmN0pg=; b=duH504ulYOnzBaVTLyLo1maWRZER3UvuJOkl8g0W5A7EYWwmU7JLyVVOeVm/mzY6jz wEQqHqotXWBM9p2+EAvrZPlBnGf0wIXCNnyoHFxr5zjGsKVcLPXHkfQVwIGTrVZFfHJg E4e8lZiIn8rsAZTGPhWBTHBxWkOp5DngPB1Az8BgpizpK4wZTN68kKTCIq1n4SCn6Y5V 56K05ugA1OyB3vJpg7045S8yLgufcX3ypvS9ZGEs793kJzwt2Pp/5EpQpLRLJ0SmkWOO 9J5MhDH6Dt3+awMXHKsUxbuCGMHLj/OPr3AwVMHf2ZWmG4UVE5Y1CWHYNDj00yZt0DW0 kIiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OIkvZSCfU1CjrPejBudrIGntnY32egXHLdKIcmmN0pg=; b=ZOCAcWnpVElXUteqr+PgL76w95IPdOUSTcT+eNQ02utewPUNUXcRf3XKIe5dcpzqCV K0Hc14agWWgHdQTImfCuRNs7JI9W7IMbbciy+Ii8BXjvjbU2GFR2AjL7tm7z/V/XnDeh zjDMRxai/LdvlieikMGuQQ/1b2xJtcdUhVwkMLpA0huRuyRm+G9lKpZ66+2oy7aCjnYb 5pkTNVNU61YGCIuB8UqbTxT0rqQDCjj55syQtJnpkY4ShJIOOOFcg90lOu00xA++rUaO JMIWYMQlwaa0+faO2tb0DwLJWjGIGvD5Mcl9WJOzmKxD7fsFkmghCfYN67l75fOxvTi9 RJ+Q== X-Gm-Message-State: AJIora/WN4PMzoIw5URhB5K8Rg8cIuUAvRuJR7FFML9C17ZlF9/4/X39 U2GytSGTTvWUU4pSaIi6qVOaMA== X-Google-Smtp-Source: AGRyM1vkSR+fkkuzlMpkZs/yPAV/CYQBTRY/CutcwMiNTqboWAwrJeP6fXDvYF6KEeySkwQaI+gI6w== X-Received: by 2002:a05:622a:13c8:b0:317:7862:6b45 with SMTP id p8-20020a05622a13c800b0031778626b45mr4688676qtk.266.1656201546699; Sat, 25 Jun 2022 16:59:06 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id l2-20020a05620a28c200b006a6cadd89efsm5717888qkp.82.2022.06.25.16.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jun 2022 16:59:05 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1o5Fg8-001ry7-9l; Sat, 25 Jun 2022 20:59:04 -0300 Date: Sat, 25 Jun 2022 20:59:04 -0300 From: Jason Gunthorpe To: Peter Xu Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List , Sean Christopherson Subject: Re: [PATCH 1/4] mm/gup: Add FOLL_INTERRUPTIBLE Message-ID: <20220625235904.GK23621@ziepe.ca> References: <20220622213656.81546-1-peterx@redhat.com> <20220622213656.81546-2-peterx@redhat.com> <20220625003554.GJ23621@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656201547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OIkvZSCfU1CjrPejBudrIGntnY32egXHLdKIcmmN0pg=; b=BHU9Kzs++ob6dLYTMpd1IfFJwAOjugNBHAzzPbZZ1Fx2nDLof89JJJxX/TqmkFeFG2MWSO o6JdrjssIrsdPnUdi5VaTE55dRspjkw4gzMp3RItpaciAwMwFC3cgO4sRA/iUiB0YaHKnE 7gGoGOtyEkMy1vKv2+nj6ZmvZ/PCZvI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=duH504ul; spf=pass (imf04.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.52 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656201547; a=rsa-sha256; cv=none; b=6uvKKjOAWPyCov3i7qwOBlCZqtPn2anvsirjEIV/IFpo+P/Z/rGXdhnukKIYbOXjHKKFNJ hCdRxoL7vods34dHf4Lyo+fa8sifh95XA/yfvaquZIUfjOtHypaRtTruWRqoVFs9zW1e1z wx+wl5QzFecVydxHGnPgP4TOgAXW+xc= Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=duH504ul; spf=pass (imf04.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.52 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: aq76jnkn45q87jm49r7qy7tht3m7ey4c X-Rspamd-Queue-Id: 6B91E40021 X-HE-Tag: 1656201547-733636 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 24, 2022 at 09:23:04PM -0400, Peter Xu wrote: > If to go back to the original question with a shorter answer: if the ioctl > context that GUP upon a page that will never be with a uffd context, then > it's probably not gonna help at all.. at least not before we use > FAULT_FLAG_INTERRUPTIBLE outside uffd page fault handling. I think I would be more interested in this if it could abort a swap in, for instance. Doesn't this happen if it flows the interruptible flag into the VMA's fault handler? Jason