From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BCF8C43334 for ; Mon, 27 Jun 2022 15:55:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A321D6B0071; Mon, 27 Jun 2022 11:55:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B90B8E0002; Mon, 27 Jun 2022 11:55:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 833048E0001; Mon, 27 Jun 2022 11:55:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7090E6B0071 for ; Mon, 27 Jun 2022 11:55:40 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 4433F120141 for ; Mon, 27 Jun 2022 15:55:40 +0000 (UTC) X-FDA: 79624466040.29.5D74FB3 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf14.hostedemail.com (Postfix) with ESMTP id 49427100030 for ; Mon, 27 Jun 2022 15:55:39 +0000 (UTC) Received: by mail-ej1-f42.google.com with SMTP id pk21so20150501ejb.2 for ; Mon, 27 Jun 2022 08:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wowsignal-io.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PQbjFEiwtCXanNM8YCbqW7LJnZ8h4bm5L6S+VGSkq2M=; b=GlGJdnggUBr8Q11uF8/0yqOHQsSAJtaONpuENkNHXH8YeWS6IKiu29oGiHrSNpzJWy AChTVuJP8gWjB8Ani8bcYiQxsKSSxKFYVTWfsuRa2bVUT7/bOeakLFi9LDnFTd3g/lV8 8WuOV40t5TanI0nrBY0tQ85jG2icp3blzMOxPGuMct4pZJLOSiGFwuCD2mOqrdnOepR2 /Z58slnPsWErTSzC4PGqubcyXaSHHiboRCDnyzbkRqRyj815sPSPYAO2NKMnf8mAC/X8 YUlgn6mU1YtnTzsj8neC6Sm5nAKxfvZJ9tEdqRmRbicy0V8/b7UWqY66kPcMEvo+cmx2 6okg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PQbjFEiwtCXanNM8YCbqW7LJnZ8h4bm5L6S+VGSkq2M=; b=fd1l+sXP6qm/BNwHJTpgF9PxFI+jqHPLSCUKOzZEs2A6xwp/d2+8DOnSL2H7dDiwvK Y6v+s6Q9oLBmtQ6DadOGjzk9UmS1Q8Bc6qQhDm1MDC1NJxdUtOqSy7is6P0DZ4wsdcT2 67X0meOAyFgcpJ3U3aCzBVjhAu7Y4YbP60wok15i8jJgtvUe53e57vIA5NUEekfac0IF K5ALF9UcqhviuquCXfubjVp6Ggr9W/7ihDcTJ1ahU7GG1wzQ8MSkkYokaa6uUSo06qvM AH4ILFCvrFjDUtGHc7RN8T6OFYzyheJPPKowdZqFYOX3IIvvPovbegjSqDL/NYD8UY+g +oZw== X-Gm-Message-State: AJIora8LS3ebxO2mOlkya8b7F16WxbbQf8Of0G+2W3/3UbHg4ZElgOyr K1eJFlhttZ3PBDO/qE66sagdcg== X-Google-Smtp-Source: AGRyM1tMUi2LVP5XuEgwNrSnbixeqOkOR5m5ay1+Oar+7rtdZT4kwC+FBQZQVS9zXjlwLKOh7/e9GA== X-Received: by 2002:a17:907:9490:b0:722:e9ee:fbc7 with SMTP id dm16-20020a170907949000b00722e9eefbc7mr13558648ejc.338.1656345338065; Mon, 27 Jun 2022 08:55:38 -0700 (PDT) Received: from localhost (212-51-140-210.fiber7.init7.net. [212.51.140.210]) by smtp.gmail.com with ESMTPSA id lj20-20020a170906f9d400b00722e771007fsm5148591ejb.37.2022.06.27.08.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 08:55:37 -0700 (PDT) From: Adam Sindelar To: Andrew Morton Cc: linux-mm@kvack.org, Adam Sindelar , Adam Sindelar , David Vernet , kernel-team@fb.com Subject: [PATCH] selftests/vm: Only run 128TBswitch with 5-level paging Date: Mon, 27 Jun 2022 17:55:30 +0200 Message-Id: <20220627155530.2272-1-adam@wowsignal.io> X-Mailer: git-send-email 2.35.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=wowsignal-io.20210112.gappssmtp.com header.s=20210112 header.b=GlGJdngg; dmarc=none; spf=none (imf14.hostedemail.com: domain of adam@wowsignal.io has no SPF policy when checking 209.85.218.42) smtp.mailfrom=adam@wowsignal.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656345339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PQbjFEiwtCXanNM8YCbqW7LJnZ8h4bm5L6S+VGSkq2M=; b=ks8CEwrPPWWy5QxLb/aXJAKyhNz25ibmmIe7qKxGzB5Cpsw52b7lLhzXqSda6cD5groS3G jYpe0b4l8hAuUYjYPae8v9HUzOoiIzGO4ERmQYcEwJnwTTACgugkp3TmvdLX42qtjK8hQl kEx45l6iVTuR7BgyiKheTyT+9MRx8/0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656345339; a=rsa-sha256; cv=none; b=mapjZGJqfsCGeWjWCuJjjDih7D0dG7KoB+Fm+H0NrifIWkCnOcEhJmZTBvGR+WHW6wixdP IJpQk4RKBINqJZmCB39AZeQsjHnsh9izTTU8TEkcLj9GYGYIns5J5Xj8KZsFDkfUZUgdnY 4+YTnEiKu1/GLQnsq4btm12d1e2yyXs= X-Stat-Signature: rio8t5x3ypjshroa8d48gdgh6uf1cks1 X-Rspamd-Queue-Id: 49427100030 X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=wowsignal-io.20210112.gappssmtp.com header.s=20210112 header.b=GlGJdngg; dmarc=none; spf=none (imf14.hostedemail.com: domain of adam@wowsignal.io has no SPF policy when checking 209.85.218.42) smtp.mailfrom=adam@wowsignal.io X-Rspamd-Server: rspam12 X-HE-Tag: 1656345339-576001 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002709, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The test va_128TBswitch.c expects to be able to pass mmap an address hint and length that cross the address 1<<47. This is not possible without 5-level page tables, so the test fails. The test is already only run on 64-bit powerpc and x86 archs, but this patch adds an additional check that skips the test if PG_TABLE_LEVELS < 5. There is precedent for checking /proc/config.gz in selftests, e.g. in selftests/firmware. Running `sudo make -C tools/testing/selftests TARGETS=vm run_tests` produces the desired output: ``` --------------------------- running ./va_128TBswitch.sh --------------------------- ./va_128TBswitch.sh: PG_TABLE_LEVELS=4, must be >= 5 to run this test [SKIP] ------------------------------- ``` Signed-off-by: Adam Sindelar --- tools/testing/selftests/vm/Makefile | 1 + tools/testing/selftests/vm/run_vmtests.sh | 2 +- tools/testing/selftests/vm/va_128TBswitch.sh | 39 ++++++++++++++++++++ 3 files changed, 41 insertions(+), 1 deletion(-) create mode 100755 tools/testing/selftests/vm/va_128TBswitch.sh diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index c45e535ff4b8..7860d0969888 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -91,6 +91,7 @@ endif TEST_PROGS := run_vmtests.sh TEST_FILES := test_vmalloc.sh +TEST_FILES += va_128TBswitch.sh KSFT_KHDR_INSTALL := 1 include ../lib.mk diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh index a2302b5faaf2..edda7350ccca 100755 --- a/tools/testing/selftests/vm/run_vmtests.sh +++ b/tools/testing/selftests/vm/run_vmtests.sh @@ -149,7 +149,7 @@ if [ $VADDR64 -ne 0 ]; then run_test ./virtual_address_range # virtual address 128TB switch test - run_test ./va_128TBswitch + run_test ./va_128TBswitch.sh fi # VADDR64 # vmalloc stability smoke test diff --git a/tools/testing/selftests/vm/va_128TBswitch.sh b/tools/testing/selftests/vm/va_128TBswitch.sh new file mode 100755 index 000000000000..767a6465b5d2 --- /dev/null +++ b/tools/testing/selftests/vm/va_128TBswitch.sh @@ -0,0 +1,39 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 +# +# Copyright (C) 2022 Adam Sindelar (Meta) +# +# This is a test for mmap behavior with 5-level paging. This script wraps the +# real test to check that the kernel is configured to support at least 5 +# pagetable levels. + +# 1 means the test failed +exitcode=1 + +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +die() +{ + echo "$1" + exit $exitcode +} + +check_test_requirements() +{ + local config="/proc/config.gz" + [[ -f "${config}" ]] || config="/boot/config-$(uname -r)" + [[ -f "${config}" ]] || die "Cannot find kernel config in /proc or /boot" + + # gzip -dcfq automatically handles both compressed and plaintext input. + # See man 1 gzip under '-f'. + local pg_table_levels=$(gzip -dcfq "${config}" | grep PGTABLE_LEVELS | cut -d'=' -f 2) + + if [[ "${pg_table_levels}" -lt 5 ]]; then + echo "$0: PG_TABLE_LEVELS=${pg_table_levels}, must be >= 5 to run this test" + exit $ksft_skip + fi +} + +check_test_requirements +./va_128TBswitch -- 2.35.1