From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02DF7C433EF for ; Mon, 27 Jun 2022 16:07:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DA296B0072; Mon, 27 Jun 2022 12:07:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 663646B0073; Mon, 27 Jun 2022 12:07:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DEF48E0001; Mon, 27 Jun 2022 12:07:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3DF296B0072 for ; Mon, 27 Jun 2022 12:07:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 1F579120763 for ; Mon, 27 Jun 2022 16:07:58 +0000 (UTC) X-FDA: 79624497036.04.D5AEC88 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf14.hostedemail.com (Postfix) with ESMTP id BB6CA100023 for ; Mon, 27 Jun 2022 16:07:57 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id pk21so20225827ejb.2 for ; Mon, 27 Jun 2022 09:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wowsignal-io.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5xu9pKdiT8Zuu1kC1mRY1/ZQNVs/rlHvU1SS4PVYjYo=; b=AJc8H6q9vHEVtvjM4UxvcI6406Swu2/HOolGKNqjCgbegG8nV+3eaVC9wH69mrfzWa Hvk9J6KsdP55KN3A8J+5d705aMO21eQsZNVeRUkA1ecJ+SPe5/Ix118rwTDkh1JfyBmh 00BPUIv+s5fFTTGh+2gRvz+X0aAA7G/lfZu8gRmKLVVsKDndbjJZHJHoS2RhimOCnN0u Vq8n8gv/3LgTnNQk9qzQ/5XRx88uTvWhXto6D7o8GOJGvIOlUUehf3uZmRXlrklFImtq 2BGMXdY1aAzV8hPvZZQParTDBc2PK5pKR66ghlStkWoaNZK+iUn91ew1ZItPTS3jRkPu TcJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5xu9pKdiT8Zuu1kC1mRY1/ZQNVs/rlHvU1SS4PVYjYo=; b=fEi/1Np//znln1QAqjtaJptmLacKfk/n2EJuQsfGiJ5pKv5GCd64t9zcusHE9O3FYP gdjCw2zakYQG5YvHcixjhD2BXEoEu3XfKUVwzp5cxdZFjtMRzaKUgNmNcCksao27ysXB fVCujN1APsGE4mNsfIRO5VcTgu6CGSSzU1LsJ+jYKDc0+mnyd20ikCXnNIeY8S/np2Kw 1ZhvYcQAKa7vDrHRKpIghhudZ8qiVfL5zXPjs8s3gCGcwr2XjtTBqFzY1ttzdeWJCxgv mBJaIZXnbJPDFyLnbErmzCbxC1qg8gNSDPuTAlXWLmaZMwC1HCs413o+lM2Y6C6EJpdq YJjw== X-Gm-Message-State: AJIora8UPUqeuQqtw4i2TCqcnPTldzvT4B1ojqlIg56uqih/FsQHA/WV ZoXM3OYJInMHcMM1AR7/f/R74Q== X-Google-Smtp-Source: AGRyM1u0XWtda/hXfGKtQbcqs0LewTh1aiVyI7z7Ii9LN35tfU1OWeAGjv0O25M5Gwfl0wq0MngkqA== X-Received: by 2002:a17:907:1314:b0:722:fc80:3b34 with SMTP id vj20-20020a170907131400b00722fc803b34mr13480481ejb.583.1656346076451; Mon, 27 Jun 2022 09:07:56 -0700 (PDT) Received: from localhost (212-51-140-210.fiber7.init7.net. [212.51.140.210]) by smtp.gmail.com with ESMTPSA id i24-20020a170906251800b007262a1c8d20sm5197754ejb.19.2022.06.27.09.07.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 09:07:56 -0700 (PDT) From: Adam Sindelar To: Andrew Morton Cc: linux-mm@kvack.org, Adam Sindelar , Adam Sindelar , David Vernet , kernel-team@fb.com Subject: [PATCH v2] selftests/vm: Only run 128TBswitch with 5-level paging Date: Mon, 27 Jun 2022 18:07:49 +0200 Message-Id: <20220627160749.3954-1-adam@wowsignal.io> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=wowsignal-io.20210112.gappssmtp.com header.s=20210112 header.b=AJc8H6q9; dmarc=none; spf=none (imf14.hostedemail.com: domain of adam@wowsignal.io has no SPF policy when checking 209.85.218.54) smtp.mailfrom=adam@wowsignal.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656346077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=5xu9pKdiT8Zuu1kC1mRY1/ZQNVs/rlHvU1SS4PVYjYo=; b=RMZSfllmM6UwdP1eTCHMh1cMwR8CLTUyH9VQEaPUCFDoMiRB8C5HkyzWysJNGCdihRxTdV HQBRLmKW2K9nscTxYiRI5/PPlHeCr3Z6nLi8/g0wupYnFLg2OGYFDfkY/pBPEq07ipyKJy NdnyMj6hC5J2TW9TTSKxP9+yeJuMkEw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656346077; a=rsa-sha256; cv=none; b=6H5HPNiornaeN043Rp3uknGvpR6hDqFgk98iAr7I/vdXh0DbcwDwKSECymH2/hVJ5g+z7X 1zVe7SzSln+qmZZl5tut9zmfE/+vI/AvukGVhV1irRIi+1sZ3WY2VahjNTv4X+ul0fJRrQ mrhRNv/r7wh99IS4ebwvh94atLqc00A= X-Stat-Signature: qnqwxinjb7gm9e6arjho8jw6iekn5ug9 X-Rspamd-Queue-Id: BB6CA100023 X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=wowsignal-io.20210112.gappssmtp.com header.s=20210112 header.b=AJc8H6q9; dmarc=none; spf=none (imf14.hostedemail.com: domain of adam@wowsignal.io has no SPF policy when checking 209.85.218.54) smtp.mailfrom=adam@wowsignal.io X-Rspamd-Server: rspam12 X-HE-Tag: 1656346077-991162 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The test va_128TBswitch.c expects to be able to pass mmap an address hint and length that cross the address 1<<47. This is not possible without 5-level page tables, so the test fails. The test is already only run on 64-bit powerpc and x86 archs, but this patch adds an additional check that skips the test if PG_TABLE_LEVELS < 5. There is precedent for checking /proc/config.gz in selftests, e.g. in selftests/firmware. Running `sudo make -C tools/testing/selftests TARGETS=vm run_tests` produces the desired output: ``` --------------------------- running ./va_128TBswitch.sh --------------------------- ./va_128TBswitch.sh: PG_TABLE_LEVELS=4, must be >= 5 to run this test [SKIP] ------------------------------- ``` v2: - Function variables declared local - Fixed variable name typo in Makefile - Comment to explain gzip -dcfq Signed-off-by: Adam Sindelar --- tools/testing/selftests/vm/Makefile | 1 + tools/testing/selftests/vm/run_vmtests.sh | 2 +- tools/testing/selftests/vm/va_128TBswitch.sh | 39 ++++++++++++++++++++ 3 files changed, 41 insertions(+), 1 deletion(-) create mode 100755 tools/testing/selftests/vm/va_128TBswitch.sh diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index c45e535ff4b8..7860d0969888 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -91,6 +91,7 @@ endif TEST_PROGS := run_vmtests.sh TEST_FILES := test_vmalloc.sh +TEST_FILES += va_128TBswitch.sh KSFT_KHDR_INSTALL := 1 include ../lib.mk diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh index a2302b5faaf2..edda7350ccca 100755 --- a/tools/testing/selftests/vm/run_vmtests.sh +++ b/tools/testing/selftests/vm/run_vmtests.sh @@ -149,7 +149,7 @@ if [ $VADDR64 -ne 0 ]; then run_test ./virtual_address_range # virtual address 128TB switch test - run_test ./va_128TBswitch + run_test ./va_128TBswitch.sh fi # VADDR64 # vmalloc stability smoke test diff --git a/tools/testing/selftests/vm/va_128TBswitch.sh b/tools/testing/selftests/vm/va_128TBswitch.sh new file mode 100755 index 000000000000..767a6465b5d2 --- /dev/null +++ b/tools/testing/selftests/vm/va_128TBswitch.sh @@ -0,0 +1,39 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 +# +# Copyright (C) 2022 Adam Sindelar (Meta) +# +# This is a test for mmap behavior with 5-level paging. This script wraps the +# real test to check that the kernel is configured to support at least 5 +# pagetable levels. + +# 1 means the test failed +exitcode=1 + +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +die() +{ + echo "$1" + exit $exitcode +} + +check_test_requirements() +{ + local config="/proc/config.gz" + [[ -f "${config}" ]] || config="/boot/config-$(uname -r)" + [[ -f "${config}" ]] || die "Cannot find kernel config in /proc or /boot" + + # gzip -dcfq automatically handles both compressed and plaintext input. + # See man 1 gzip under '-f'. + local pg_table_levels=$(gzip -dcfq "${config}" | grep PGTABLE_LEVELS | cut -d'=' -f 2) + + if [[ "${pg_table_levels}" -lt 5 ]]; then + echo "$0: PG_TABLE_LEVELS=${pg_table_levels}, must be >= 5 to run this test" + exit $ksft_skip + fi +} + +check_test_requirements +./va_128TBswitch -- 2.35.1