From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 458A7C433EF for ; Mon, 27 Jun 2022 18:57:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAA658E0002; Mon, 27 Jun 2022 14:57:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B59A58E0001; Mon, 27 Jun 2022 14:57:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A218C8E0002; Mon, 27 Jun 2022 14:57:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 946AA8E0001 for ; Mon, 27 Jun 2022 14:57:14 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 66C2D1131 for ; Mon, 27 Jun 2022 18:57:14 +0000 (UTC) X-FDA: 79624923588.11.80BE1E1 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf31.hostedemail.com (Postfix) with ESMTP id 1CA0020013 for ; Mon, 27 Jun 2022 18:57:13 +0000 (UTC) Received: by mail-qv1-f45.google.com with SMTP id t16so16213870qvh.1 for ; Mon, 27 Jun 2022 11:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NOsgPwcDx+OihP7CM9EgDPr6TtruXCYq9aRNj46ysBQ=; b=m2eUHMAtpzvN+Y99ePVbPBQhAiBwfdEMa4sYWEHf2vtSBRaVt/SObAY73NbhrfVRfT bIAQti3EBUREmLes+VGyWRM/whbdbjPFFIuDU/j3NkDwPE/jOD3NueZzE82yw60Vs2Yc 3a8s7Yt92kyWFupcn49IGDFq2DfzziTMaUL/KsaDcRlQ+mv5JEU1/Z8gxzeJP5Mq7INE mZyZpzrs+NVF5UJ38AiWA7JgBQu6LWX5NqeYEMPyHcLd7m4ZvXM1mtntv9xK71DmrCJV 3PLqp6sEguoeleMa70eC8OzsTFBtGVG58Kmve2RhNwey7dXpIv6CFExpLh+oqa94Vqkr UQ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NOsgPwcDx+OihP7CM9EgDPr6TtruXCYq9aRNj46ysBQ=; b=TdEaKA0qEDoDQ1F51VJcaJxlF97G07AbBqU7T0ypPk1/BvlqvuU9ZAWTnSvrFwdc8J 6JhW3d/rip1izxVW+H8PcMPWqdlor5s7vksDKKC9tfW42ceh4WMRCPirqF8YOD9ubR3U brMCoJaWu7ubnkn9y+JVGQcg5q5k+HUKZjJfFurVGrwHWsT3burc2z7T73181aUim+NH YJ/tv+LXarLCESOHOy1kRTjGSFGjdOtDNCa2knJCqbvtfdRTLbI1V6xn8xa6ihmPaUxz lPnzG54aHMyx1FAy0Yq358DkmCEYMrb3G9qWsk+JRJPiKqUyMXTtV6sVjby3+HPEPvuY uRwg== X-Gm-Message-State: AJIora/875XGUujOJ3u17saQ6IYqXrAg9h3ZlknY1C+rTC1x+MyNWPOx wVv0vhwgzQ81flzOJPJ1Atk= X-Google-Smtp-Source: AGRyM1v5DGJwQQuAEAEZGEeHt/yRbP+et2CeJtdJxfhZdyXi1ntL/oaNsKV7SbYf8pRvXiM6V6UuHQ== X-Received: by 2002:a0c:9a0e:0:b0:470:5ffa:ff43 with SMTP id p14-20020a0c9a0e000000b004705ffaff43mr745456qvd.6.1656356233274; Mon, 27 Jun 2022 11:57:13 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id g1-20020ac87f41000000b002f93554c009sm7781826qtk.59.2022.06.27.11.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 11:57:12 -0700 (PDT) From: SeongJae Park To: Shuah Khan Cc: SeongJae Park , Gautam , shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] kselftests/damon: add support for cases where debugfs cannot be read Date: Mon, 27 Jun 2022 18:57:04 +0000 Message-Id: <20220627185704.58902-1-sj38.park@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <7d6b7de6-4609-e6ca-0a88-1f9799c70769@linuxfoundation.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656356234; a=rsa-sha256; cv=none; b=jCWFtQhlfDMVq3Pl2h7JLWz++ezBoexP+p1QVGhRxFmFjqaSYgWs5NXquvRn7MOUsxqsNM ax9a55qU0PK5ykOW7piGMOqK1Rx7LN8z6D8eiAksbT65brCidgAF/NG9jWB02rLooPhqsQ Maupdue30SIDzvdZt4ArhA9qWjkLSSc= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=m2eUHMAt; spf=pass (imf31.hostedemail.com: domain of sj38.park@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=sj38.park@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656356234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NOsgPwcDx+OihP7CM9EgDPr6TtruXCYq9aRNj46ysBQ=; b=LNM/Zx904Zi4aHsRSoFMprH8OBcbJwggV1yFhF+rRDTImwsEBU1/VlhwTXIi4H1YBPDmKu ghukZoLQzZvBhBhadFjYWrEkVLfOtGNccJyUAzv20ogWOi7R3HnZuWuJfNXC8M6g1Ih4Aa FTCRKgEHZfn0FkeECJdwUAR0l7ieeO4= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1CA0020013 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=m2eUHMAt; spf=pass (imf31.hostedemail.com: domain of sj38.park@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=sj38.park@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Stat-Signature: rnqzsz4owtri9i5cr1e4cbd6tw8kj97y X-HE-Tag: 1656356233-425199 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park Hi Shuah, On Mon, 27 Jun 2022 11:00:18 -0600 Shuah Khan wrote: [...] > >> --- a/tools/testing/selftests/damon/_chk_dependency.sh > >> +++ b/tools/testing/selftests/damon/_chk_dependency.sh > >> @@ -26,3 +26,13 @@ do > >> exit 1 > >> fi > >> done > >> + > >> +permission_error="Operation not permitted" > >> +for f in attrs target_ids monitor_on > >> +do > >> + status=$( cat "$DBGFS/$f" 2>&1 ) > >> + if [ "${status#*$permission_error}" != "$status" ]; then > >> + echo "Permission for reading $DBGFS/$f denied; maybe secureboot enabled?" > > btw - does this run as a regular user or does it need root privilege? > If so add a test for that and skip with a message. It needs the root permission, and does the check at the beginning[1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/damon/_chk_dependency.sh?h=v5.19-rc4#n9 Thanks, SJ > >> + exit $ksft_skip > >> + fi > >> +done > >> -- > >> 2.36.1 > > > thanks, > -- Shuah