From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40985C433EF for ; Wed, 29 Jun 2022 06:45:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D29038E0003; Wed, 29 Jun 2022 02:45:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD9128E0002; Wed, 29 Jun 2022 02:45:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEF208E0003; Wed, 29 Jun 2022 02:45:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AF5F38E0002 for ; Wed, 29 Jun 2022 02:45:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 84643354D7 for ; Wed, 29 Jun 2022 06:45:06 +0000 (UTC) X-FDA: 79630336212.18.901461B Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf03.hostedemail.com (Postfix) with ESMTP id C192D2002E for ; Wed, 29 Jun 2022 06:45:05 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D8DF467373; Wed, 29 Jun 2022 08:45:02 +0200 (CEST) Date: Wed, 29 Jun 2022 08:45:02 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell Subject: Re: [PATCH v7 14/21] mm: introduce FOLL_PCI_P2PDMA to gate getting PCI P2PDMA pages Message-ID: <20220629064502.GA17576@lst.de> References: <20220615161233.17527-1-logang@deltatee.com> <20220615161233.17527-15-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615161233.17527-15-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656485105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a65a54vFn27IP9Hkwts42TIGKxFASTy6sg8ls7Qq+Gs=; b=GTwVtrBLtGdOTg3jWbidAD18VJbgAFqhqvGhJ/AX0v7Kiy2tKDE8MZiKj7v6j1n9L0COE7 a2lTviPiN7fEYscsDZPAGQbim1/cBM5VyqI/kFx7Uu44K2UBSgX+e6Udyr/ggR9Lf67zGz 6yPfPalTN+bhCpiFgmYkk8wet2JFDio= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=none; spf=none (imf03.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656485105; a=rsa-sha256; cv=none; b=W2VSN7rYg31jV5WdQ4J1k1k3GbVLoopEAWX6usMs8Vlrq+EaC2DTnX2Rr/fJk4WzTO7WzA SY76FOdf31Zdn1zzVg1ZxRFFgWjh9xuSlflpmN8dYX5xTsPYAF7JbcL/uBKLgcYDEwq1Wm 43Z+AnKbORn9kt+TR9GTeDis9LJzXQY= X-Rspamd-Queue-Id: C192D2002E Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=none (imf03.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4sowhs8kk5dm65jre6q9gfrnoq8i4iw1 X-HE-Tag: 1656485105-214472 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 15, 2022 at 10:12:26AM -0600, Logan Gunthorpe wrote: > GUP Callers that expect PCI P2PDMA pages can now set FOLL_PCI_P2PDMA to > allow obtaining P2PDMA pages. If GUP is called without the flag and a > P2PDMA page is found, it will return an error. > > FOLL_PCI_P2PDMA cannot be set if FOLL_LONGTERM is set. Looks good: Reviewed-by: Christoph Hellwig