From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 843D6C43334 for ; Fri, 8 Jul 2022 10:56:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C52F6B0071; Fri, 8 Jul 2022 06:56:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 072CD6B0073; Fri, 8 Jul 2022 06:56:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA3EA6B0074; Fri, 8 Jul 2022 06:56:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D8DED6B0071 for ; Fri, 8 Jul 2022 06:56:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A3DFB206BF for ; Fri, 8 Jul 2022 10:56:08 +0000 (UTC) X-FDA: 79663628016.20.9DC4868 Received: from outbound-smtp06.blacknight.com (outbound-smtp06.blacknight.com [81.17.249.39]) by imf14.hostedemail.com (Postfix) with ESMTP id 85546100051 for ; Fri, 8 Jul 2022 10:56:07 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp06.blacknight.com (Postfix) with ESMTPS id 0833FC2ADA for ; Fri, 8 Jul 2022 11:56:06 +0100 (IST) Received: (qmail 27842 invoked from network); 8 Jul 2022 10:56:05 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 8 Jul 2022 10:56:05 -0000 Date: Fri, 8 Jul 2022 11:56:03 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Oliver Sang , Andrew Morton , 0day robot , LKML , linux-mm@kvack.org, lkp@lists.01.org, Nicolas Saenz Julienne , Marcelo Tosatti , Michal Hocko , Hugh Dickins Subject: Re: [mm/page_alloc] 2bd8eec68f: BUG:sleeping_function_called_from_invalid_context_at_mm/gup.c Message-ID: <20220708105603.GI27531@techsingularity.net> References: <20220613125622.18628-8-mgorman@techsingularity.net> <20220703132209.875b823d1cb7169a8d51d56d@linux-foundation.org> <1d3a26ac-89b3-0211-f8f2-5165ffa732fd@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1d3a26ac-89b3-0211-f8f2-5165ffa732fd@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657277768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f5SkcqdnWc+zlzTC3cCCDtydzEInluB78IY4tqQhZLA=; b=t/yhDBhXLbrgJ1CN4igMnpMNGNcjoeOTsfrCEsAiItxA/VCrsonAcebJ/TcBZeC1vZAWL7 en8Xwr+C8dgozJGipkX3edFEnud898rFB8XZOfzmM6ptamid/v/6b9W0gMRg7KdMP987+B QvLkZihBzvySpDEYdT5i4O3FW3dGxys= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657277768; a=rsa-sha256; cv=none; b=npZ0boPo681x2JDTHRlOxFU0/xbnXMydfUaZLyg0kcBV3GAsEB/Fib8KsNVcUnLg02TbaN EZzc3LSFb0EWXILxIL51uILayM4CLIkomFZLwUjkw5iWkEG6RzJnBnuVwMbbLyvVYErjIX jbIW/YC78gD16x/4WkzXyPChq3zmgMM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.39 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.39 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 85546100051 X-Stat-Signature: 1bbryqnwyw3t8uttpw444n56inudu8x7 X-Rspam-User: X-HE-Tag: 1657277767-944789 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 07, 2022 at 11:55:35PM +0200, Vlastimil Babka wrote: > On 7/5/22 15:51, Oliver Sang wrote: > > Hi Andrew Morton, > > > > On Sun, Jul 03, 2022 at 01:22:09PM -0700, Andrew Morton wrote: > >> On Sun, 3 Jul 2022 17:44:30 +0800 kernel test robot wrote: > >> > >> > FYI, we noticed the following commit (built with gcc-11): > >> > > >> > commit: 2bd8eec68f740608db5ea58ecff06965228764cb ("[PATCH 7/7] mm/page_alloc: Replace local_lock with normal spinlock") > >> > url: https://github.com/intel-lab-lkp/linux/commits/Mel-Gorman/Drain-remote-per-cpu-directly/20220613-230139 > >> > base: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3 > >> > patch link: https://lore.kernel.org/lkml/20220613125622.18628-8-mgorman@techsingularity.net > >> > > >> > >> Did this test include the followup patch > >> mm-page_alloc-replace-local_lock-with-normal-spinlock-fix.patch? > > > > no, we just fetched original patch set and test upon it. > > It appears you fetched v4, not v5. I noticed it from the threading of your > report that was threaded in the v4 thread, and also the github url: above. > In v4, pcpu_spin_trylock_irqsave() was missing an unpin, and indeed it's > missing in the github branch you were testing: > Thanks Vlastimil! This is my fault, I failed to verify that the code in my tree, Andrew's tree and what Oliver tested were the same so no wonder I could not find where the missing unpin was. I've gone through mm-unstable commits be42c869b8e..4143c9b5266 and can confirm that they are now identical to my own tree which includes Andrew's fix for the smatch warning that Dan reported. # git diff HEAD^..mm-pcpspinnoirq-v6r1-mmunstable | wc -l 0 The only difference between my tree and Andrew's is that there is a head commit for "mm/page_alloc: Do not disable IRQs for per-cpu allocations" which has been put on hold for now. -- Mel Gorman SUSE Labs