linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yury Norov <yury.norov@gmail.com>
To: linux-kernel@vger.kernel.org,
	Alexander Lobakin <alexandr.lobakin@intel.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Alexey Klimov <aklimov@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ben Segall <bsegall@google.com>, Christoph Lameter <cl@linux.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Dennis Zhou <dennis@kernel.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Eric Dumazet <edumazet@google.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Ingo Molnar <mingo@redhat.com>,
	Isabella Basso <isabbasso@riseup.net>,
	John Fastabend <john.fastabend@gmail.com>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Juri Lelli <juri.lelli@redhat.com>, KP Singh <kpsingh@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Martin KaFai Lau <kafai@fb.com>, Mel Gorman <mgorman@suse.de>,
	Miroslav Benes <mbenes@suse.cz>,
	Nathan Chancellor <nathan@kernel.org>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Song Liu <songliubraving@fb.com>,
	Steven Rostedt <rostedt@goodmis.org>, Tejun Heo <tj@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Vlastimil Babka <vbabka@suse.cz>, Yonghong Song <yhs@fb.com>,
	Yury Norov <yury.norov@gmail.com>,
	linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH 13/16] time: optimize tick_setup_device()
Date: Mon, 18 Jul 2022 12:28:41 -0700	[thread overview]
Message-ID: <20220718192844.1805158-14-yury.norov@gmail.com> (raw)
In-Reply-To: <20220718192844.1805158-1-yury.norov@gmail.com>

tick_setup_device() calls cpumask_equal(newdev->cpumask, cpumask)
even if newdev->cpumask == cpumask. Fix it.

Caught with CONFIG_DEBUG_BITMAP:
[    0.070960] Call trace:
[    0.070974]  __bitmap_check_params+0x144/0x250
[    0.071008]  tick_setup_device+0x70/0x1a0
[    0.071040]  tick_check_new_device+0xc0/0x110
[    0.071066]  clockevents_register_device+0x74/0x1c0
[    0.071090]  clockevents_config_and_register+0x2c/0x3c
[    0.071114]  arch_timer_starting_cpu+0x170/0x470
[    0.071147]  cpuhp_invoke_callback+0x104/0x20c
[    0.071180]  cpuhp_invoke_callback_range+0x70/0xf0
[    0.071205]  notify_cpu_starting+0xac/0xcc
[    0.071229]  secondary_start_kernel+0xe4/0x154
[    0.071259]  __secondary_switched+0xa0/0xa4
[    0.071297] ---[ end trace 0000000000000000 ]---
[    0.071328] b1:	ffffa1f27323b890
[    0.071339] b2:	ffffa1f27323b890
[    0.071348] b3:	0
[    0.071356] nbits:	256
[    0.071366] start:	0
[    0.071374] off:	0
[    0.071383] Bitmap: parameters check failed
[    0.071390] include/linux/bitmap.h [419]: bitmap_equal

Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
 kernel/time/tick-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index 7205f76f8d10..7b2da8ef09ef 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -255,7 +255,7 @@ static void tick_setup_device(struct tick_device *td,
 	 * When the device is not per cpu, pin the interrupt to the
 	 * current cpu:
 	 */
-	if (!cpumask_equal(newdev->cpumask, cpumask))
+	if (newdev->cpumask != cpumask && !cpumask_equal(newdev->cpumask, cpumask))
 		irq_set_affinity(newdev->irq, cpumask);
 
 	/*
-- 
2.34.1



  parent reply	other threads:[~2022-07-18 19:29 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 19:28 [PATCH 00/16] Introduce DEBUG_BITMAP config option and bitmap_check_params() Yury Norov
2022-07-18 19:28 ` [PATCH 01/16] lib/bitmap: add bitmap_check_params() Yury Norov
2022-07-18 21:01   ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 02/16] lib/bitmap: don't call bitmap_set() with len == 0 Yury Norov
2022-07-18 21:06   ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 03/16] lib/test_bitmap: don't test bitmap_set if nbits " Yury Norov
2022-07-18 21:08   ` Andy Shevchenko
2022-08-09 12:37   ` Rasmus Villemoes
2022-07-18 19:28 ` [PATCH 04/16] lib/test_bitmap: test test_bitmap_arr{32,64} starting from nbits == 1 Yury Norov
2022-07-18 21:09   ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 05/16] lib/test_bitmap: disable compile-time test if DEBUG_BITMAP() is enabled Yury Norov
2022-07-18 21:10   ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 06/16] lib/test_bitmap: delete meaningless test for bitmap_cut Yury Norov
2022-07-18 21:11   ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 07/16] smp: optimize smp_call_function_many_cond() Yury Norov
2022-07-18 21:26   ` Peter Zijlstra
2022-07-18 21:36   ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 08/16] smp: optimize smp_call_function_many_cond() for more Yury Norov
2022-07-18 21:29   ` Peter Zijlstra
2022-07-20 17:06     ` Yury Norov
2022-07-18 21:37   ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 09/16] irq: don't copy cpu affinity mask if source is equal to destination Yury Norov
2022-07-18 21:30   ` Peter Zijlstra
2022-07-18 19:28 ` [PATCH 10/16] sched: optimize __set_cpus_allowed_ptr_locked() Yury Norov
2022-07-18 21:34   ` Peter Zijlstra
2022-07-18 19:28 ` [PATCH 11/16] time: optimize tick_check_preferred() Yury Norov
2022-08-06  8:30   ` Thomas Gleixner
2022-08-08 11:42     ` Thomas Gleixner
2022-08-08 16:38       ` Yury Norov
2022-08-09 12:29         ` Rasmus Villemoes
2022-07-18 19:28 ` [PATCH 12/16] time: optimize tick_check_percpu() Yury Norov
2022-07-18 19:28 ` Yury Norov [this message]
2022-07-18 21:35   ` [PATCH 13/16] time: optimize tick_setup_device() Peter Zijlstra
2022-07-18 19:28 ` [PATCH 14/16] mm/percpu: optimize pcpu_alloc_area() Yury Norov
2022-07-19  4:25   ` Dennis Zhou
2022-07-18 19:28 ` [PATCH 15/16] sched/topology: optimize topology_span_sane() Yury Norov
2022-07-18 21:37   ` Peter Zijlstra
2022-07-18 19:28 ` [PATCH 16/16] lib: create CONFIG_DEBUG_BITMAP parameter Yury Norov
2022-07-18 21:39   ` Andy Shevchenko
2022-07-20 16:49     ` Yury Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220718192844.1805158-14-yury.norov@gmail.com \
    --to=yury.norov@gmail.com \
    --cc=aklimov@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexandr.lobakin@intel.com \
    --cc=andrii@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ast@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=cl@linux.com \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@iogearbox.net \
    --cc=dennis@kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=isabbasso@riseup.net \
    --cc=jgross@suse.com \
    --cc=john.fastabend@gmail.com \
    --cc=jpoimboe@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=kafai@fb.com \
    --cc=keescook@chromium.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=linux@roeck-us.net \
    --cc=mbenes@suse.cz \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=songliubraving@fb.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).