From: Liam Howlett <liam.howlett@oracle.com>
To: "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>
Cc: Yu Zhao <yuzhao@google.com>
Subject: [PATCH v12 09/69] mm: add VMA iterator
Date: Wed, 20 Jul 2022 02:17:46 +0000 [thread overview]
Message-ID: <20220720021727.17018-10-Liam.Howlett@oracle.com> (raw)
In-Reply-To: <20220720021727.17018-1-Liam.Howlett@oracle.com>
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
This thin layer of abstraction over the maple tree state is for iterating
over VMAs. You can go forwards, go backwards or ask where the iterator
is. Rename the existing vma_next() to __vma_next() -- it will be removed
by the end of this series.
Link: https://lkml.kernel.org/r/20220504010716.661115-11-Liam.Howlett@oracle.com
Link: https://lkml.kernel.org/r/20220621204632.3370049-10-Liam.Howlett@oracle.com
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: SeongJae Park <sj@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/mm.h | 32 ++++++++++++++++++++++++++++++++
include/linux/mm_types.h | 21 +++++++++++++++++++++
mm/mmap.c | 10 +++++-----
3 files changed, 58 insertions(+), 5 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index adc963765d95..dee609fe5c1f 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -658,6 +658,38 @@ static inline bool vma_is_accessible(struct vm_area_struct *vma)
return vma->vm_flags & VM_ACCESS_FLAGS;
}
+static inline
+struct vm_area_struct *vma_find(struct vma_iterator *vmi, unsigned long max)
+{
+ return mas_find(&vmi->mas, max);
+}
+
+static inline struct vm_area_struct *vma_next(struct vma_iterator *vmi)
+{
+ /*
+ * Uses vma_find() to get the first VMA when the iterator starts.
+ * Calling mas_next() could skip the first entry.
+ */
+ return vma_find(vmi, ULONG_MAX);
+}
+
+static inline struct vm_area_struct *vma_prev(struct vma_iterator *vmi)
+{
+ return mas_prev(&vmi->mas, 0);
+}
+
+static inline unsigned long vma_iter_addr(struct vma_iterator *vmi)
+{
+ return vmi->mas.index;
+}
+
+#define for_each_vma(__vmi, __vma) \
+ while (((__vma) = vma_next(&(__vmi))) != NULL)
+
+/* The MM code likes to work with exclusive end addresses */
+#define for_each_vma_range(__vmi, __vma, __end) \
+ while (((__vma) = vma_find(&(__vmi), (__end) - 1)) != NULL)
+
#ifdef CONFIG_SHMEM
/*
* The vma_is_shmem is not inline because it is used only by slow
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index e810aaca6c04..47fbff4d4502 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -696,6 +696,27 @@ static inline cpumask_t *mm_cpumask(struct mm_struct *mm)
return (struct cpumask *)&mm->cpu_bitmap;
}
+struct vma_iterator {
+ struct ma_state mas;
+};
+
+#define VMA_ITERATOR(name, __mm, __addr) \
+ struct vma_iterator name = { \
+ .mas = { \
+ .tree = &(__mm)->mm_mt, \
+ .index = __addr, \
+ .node = MAS_START, \
+ }, \
+ }
+
+static inline void vma_iter_init(struct vma_iterator *vmi,
+ struct mm_struct *mm, unsigned long addr)
+{
+ vmi->mas.tree = &mm->mm_mt;
+ vmi->mas.index = addr;
+ vmi->mas.node = MAS_START;
+}
+
struct mmu_gather;
extern void tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm);
extern void tlb_gather_mmu_fullmm(struct mmu_gather *tlb, struct mm_struct *mm);
diff --git a/mm/mmap.c b/mm/mmap.c
index 0e202b16caf3..ba754a3cfbd8 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -633,7 +633,7 @@ static int find_vma_links(struct mm_struct *mm, unsigned long addr,
}
/*
- * vma_next() - Get the next VMA.
+ * __vma_next() - Get the next VMA.
* @mm: The mm_struct.
* @vma: The current vma.
*
@@ -641,7 +641,7 @@ static int find_vma_links(struct mm_struct *mm, unsigned long addr,
*
* Returns: The next VMA after @vma.
*/
-static inline struct vm_area_struct *vma_next(struct mm_struct *mm,
+static inline struct vm_area_struct *__vma_next(struct mm_struct *mm,
struct vm_area_struct *vma)
{
if (!vma)
@@ -1338,7 +1338,7 @@ struct vm_area_struct *vma_merge(struct mm_struct *mm,
if (vm_flags & VM_SPECIAL)
return NULL;
- next = vma_next(mm, prev);
+ next = __vma_next(mm, prev);
area = next;
if (area && area->vm_end == end) /* cases 6, 7, 8 */
next = next->vm_next;
@@ -2886,7 +2886,7 @@ static void unmap_region(struct mm_struct *mm,
struct vm_area_struct *vma, struct vm_area_struct *prev,
unsigned long start, unsigned long end)
{
- struct vm_area_struct *next = vma_next(mm, prev);
+ struct vm_area_struct *next = __vma_next(mm, prev);
struct mmu_gather tlb;
lru_add_drain();
@@ -3094,7 +3094,7 @@ int __do_munmap(struct mm_struct *mm, unsigned long start, size_t len,
if (error)
goto split_failed;
}
- vma = vma_next(mm, prev);
+ vma = __vma_next(mm, prev);
if (unlikely(uf)) {
/*
--
2.35.1
next prev parent reply other threads:[~2022-07-20 2:17 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 2:17 [PATCH v12 00/69] Introducing the Maple Tree Liam Howlett
2022-07-20 2:17 ` [PATCH v12 01/69] Maple Tree: add new data structure Liam Howlett
2022-07-20 2:17 ` [PATCH v12 02/69] radix tree test suite: add pr_err define Liam Howlett
2022-07-20 2:17 ` [PATCH v12 03/69] radix tree test suite: add kmem_cache_set_non_kernel() Liam Howlett
2022-07-20 2:17 ` [PATCH v12 05/69] radix tree test suite: add support for slab bulk APIs Liam Howlett
2022-07-20 2:17 ` [PATCH v12 04/69] radix tree test suite: add allocation counts and size to kmem_cache Liam Howlett
2022-07-20 2:17 ` [PATCH v12 06/69] radix tree test suite: add lockdep_is_held to header Liam Howlett
2022-07-20 2:17 ` [PATCH v12 08/69] mm: start tracking VMAs with maple tree Liam Howlett
2022-07-27 0:28 ` Nathan Chancellor
2022-07-28 0:34 ` Liam Howlett
2022-07-29 15:41 ` Liam Howlett
2022-07-29 17:02 ` Nathan Chancellor
2022-07-29 20:13 ` Liam Howlett
2022-07-20 2:17 ` [PATCH v12 07/69] lib/test_maple_tree: add testing for " Liam Howlett
2022-07-20 2:17 ` [PATCH v12 10/69] mmap: use the VMA iterator in count_vma_pages_range() Liam Howlett
2022-07-20 2:17 ` Liam Howlett [this message]
2022-07-20 2:17 ` [PATCH v12 11/69] mm/mmap: use the maple tree in find_vma() instead of the rbtree Liam Howlett
2022-07-20 2:17 ` [PATCH v12 13/69] mm/mmap: use maple tree for unmapped_area{_topdown} Liam Howlett
2022-07-20 2:17 ` [PATCH v12 12/69] mm/mmap: use the maple tree for find_vma_prev() instead of the rbtree Liam Howlett
2022-07-20 2:17 ` [PATCH v12 15/69] damon: convert __damon_va_three_regions to use the VMA iterator Liam Howlett
2022-07-20 2:17 ` [PATCH v12 16/69] proc: remove VMA rbtree use from nommu Liam Howlett
2022-07-20 2:17 ` [PATCH v12 14/69] kernel/fork: use maple tree for dup_mmap() during forking Liam Howlett
2022-07-20 2:17 ` [PATCH v12 19/69] xen: use vma_lookup() in privcmd_ioctl_mmap() Liam Howlett
2022-07-20 2:17 ` [PATCH v12 18/69] mmap: change zeroing of maple tree in __vma_adjust() Liam Howlett
2022-07-20 2:17 ` [PATCH v12 17/69] mm: remove rb tree Liam Howlett
2022-07-20 2:17 ` [PATCH v12 20/69] mm: optimize find_exact_vma() to use vma_lookup() Liam Howlett
2022-07-20 2:17 ` [PATCH v12 21/69] mm/khugepaged: optimize collapse_pte_mapped_thp() by using vma_lookup() Liam Howlett
2022-07-20 2:17 ` [PATCH v12 22/69] mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap() Liam Howlett
[not found] ` <f5e99dbb-7008-dcf8-3e85-2f161056b37a@gmail.com>
2022-07-25 14:01 ` Liam Howlett
2022-07-25 18:49 ` Liam Howlett
[not found] ` <8d77a517-fcc1-5e74-b9d8-2a250dc751ed@gmail.com>
2022-07-28 0:57 ` Liam Howlett
2022-07-20 2:17 ` [PATCH v12 24/69] mm/mmap: use advanced maple tree API for mmap_region() Liam Howlett
2022-07-20 2:17 ` [PATCH v12 23/69] mm: use maple tree operations for find_vma_intersection() Liam Howlett
2022-07-20 2:17 ` [PATCH v12 25/69] mm: remove vmacache Liam Howlett
2022-07-20 2:17 ` [PATCH v12 26/69] mm: convert vma_lookup() to use mtree_load() Liam Howlett
2022-07-20 2:17 ` [PATCH v12 27/69] mm/mmap: move mmap_region() below do_munmap() Liam Howlett
2022-07-20 2:17 ` [PATCH v12 29/69] mm/mmap: change do_brk_munmap() to use do_mas_align_munmap() Liam Howlett
2022-07-20 2:17 ` [PATCH v12 28/69] mm/mmap: reorganize munmap to use maple states Liam Howlett
2022-07-20 2:17 ` [PATCH v12 30/69] arm64: remove mmap linked list from vdso Liam Howlett
2022-07-20 2:17 ` [PATCH v12 31/69] arm64: Change elfcore for_each_mte_vma() to use VMA iterator Liam Howlett
2022-07-20 2:17 ` [PATCH v12 32/69] parisc: remove mmap linked list from cache handling Liam Howlett
2022-07-20 2:17 ` [PATCH v12 33/69] powerpc: remove mmap linked list walks Liam Howlett
2022-08-02 10:36 ` Christophe Leroy
2022-07-20 2:17 ` [PATCH v12 34/69] s390: remove vma " Liam Howlett
2022-07-20 2:17 ` [PATCH v12 36/69] xtensa: " Liam Howlett
2022-07-20 2:17 ` [PATCH v12 35/69] x86: " Liam Howlett
2022-07-20 2:17 ` [PATCH v12 37/69] cxl: remove vma linked list walk Liam Howlett
2022-07-20 2:17 ` [PATCH v12 38/69] optee: " Liam Howlett
2022-07-20 2:17 ` [PATCH v12 40/69] coredump: " Liam Howlett
2022-07-20 2:17 ` [PATCH v12 39/69] um: " Liam Howlett
2022-07-20 2:17 ` [PATCH v12 41/69] exec: use VMA iterator instead of linked list Liam Howlett
2022-07-20 2:17 ` [PATCH v12 44/69] userfaultfd: use maple tree iterator to iterate VMAs Liam Howlett
2022-07-20 2:17 ` [PATCH v12 42/69] fs/proc/base: use maple tree iterators in place of linked list Liam Howlett
2022-07-20 2:17 ` [PATCH v12 43/69] fs/proc/task_mmu: stop using linked list and highest_vm_end Liam Howlett
2022-07-20 2:17 ` [PATCH v12 46/69] acct: use VMA iterator instead of linked list Liam Howlett
2022-07-20 2:17 ` [PATCH v12 45/69] ipc/shm: " Liam Howlett
2022-07-20 2:17 ` [PATCH v12 47/69] perf: use VMA iterator Liam Howlett
2022-07-20 2:17 ` [PATCH v12 51/69] mm/gup: use maple tree navigation instead of linked list Liam Howlett
2022-07-20 2:17 ` [PATCH v12 48/69] sched: use maple tree iterator to walk VMAs Liam Howlett
2022-07-20 2:17 ` [PATCH v12 50/69] bpf: remove VMA linked list Liam Howlett
2022-07-20 2:17 ` [PATCH v12 49/69] fork: use VMA iterator Liam Howlett
2022-07-20 2:18 ` [PATCH v12 54/69] mm/madvise: use vma_find() instead of vma linked list Liam Howlett
2022-07-20 2:18 ` [PATCH v12 53/69] mm/ksm: use vma iterators " Liam Howlett
2022-07-20 2:18 ` [PATCH v12 52/69] mm/khugepaged: stop using " Liam Howlett
2022-07-20 2:18 ` [PATCH v12 57/69] mm/mlock: use vma iterator and maple state instead of " Liam Howlett
2022-07-20 2:18 ` [PATCH v12 56/69] mm/mempolicy: use vma iterator & " Liam Howlett
2022-07-20 2:18 ` [PATCH v12 58/69] mm/mprotect: use maple tree navigation " Liam Howlett
2022-07-20 2:18 ` [PATCH v12 55/69] mm/memcontrol: stop using mm->highest_vm_end Liam Howlett
2022-07-20 2:18 ` [PATCH v12 62/69] mm/pagewalk: use vma_find() instead of vma linked list Liam Howlett
2022-07-20 2:18 ` [PATCH v12 59/69] mm/mremap: use vma_find_intersection() " Liam Howlett
2022-07-20 2:18 ` [PATCH v12 61/69] mm/oom_kill: use maple tree iterators " Liam Howlett
2022-07-20 2:18 ` [PATCH v12 60/69] mm/msync: use vma_find() " Liam Howlett
2022-07-20 2:18 ` [PATCH v12 63/69] mm/swapfile: use vma iterator " Liam Howlett
2022-07-20 2:18 ` [PATCH v12 65/69] nommu: remove uses of VMA " Liam Howlett
2022-07-20 2:18 ` [PATCH v12 64/69] i915: use the VMA iterator Liam Howlett
2022-07-20 2:18 ` [PATCH v12 68/69] mm/mmap: drop range_has_overlap() function Liam Howlett
2022-07-20 2:18 ` [PATCH v12 67/69] mm: remove the vma linked list Liam Howlett
2022-07-20 2:18 ` [PATCH v12 66/69] riscv: use vma iterator for vdso Liam Howlett
2022-07-20 2:18 ` [PATCH v12 69/69] mm/mmap.c: pass in mapping to __vma_link_file() Liam Howlett
2022-07-20 5:09 ` [PATCH v12 00/69] Introducing the Maple Tree Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720021727.17018-10-Liam.Howlett@oracle.com \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).