From: Peter Xu <peterx@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com, John Hubbard <jhubbard@nvidia.com>,
Sean Christopherson <seanjc@google.com>,
Linux MM Mailing List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: [PATCH v2 2/3] kvm: Add new pfn error KVM_PFN_ERR_SIGPENDING
Date: Wed, 20 Jul 2022 20:03:17 -0400 [thread overview]
Message-ID: <20220721000318.93522-3-peterx@redhat.com> (raw)
In-Reply-To: <20220721000318.93522-1-peterx@redhat.com>
Add one new PFN error type to show when we got interrupted when fetching
the PFN due to signal pending.
This prepares KVM to be able to respond to SIGUSR1 (for QEMU that's the
SIGIPI) even during e.g. handling an userfaultfd page fault.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
include/linux/kvm_host.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 83cf7fd842e0..06a5b17d3679 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -96,6 +96,7 @@
#define KVM_PFN_ERR_FAULT (KVM_PFN_ERR_MASK)
#define KVM_PFN_ERR_HWPOISON (KVM_PFN_ERR_MASK + 1)
#define KVM_PFN_ERR_RO_FAULT (KVM_PFN_ERR_MASK + 2)
+#define KVM_PFN_ERR_SIGPENDING (KVM_PFN_ERR_MASK + 3)
/*
* error pfns indicate that the gfn is in slot but faild to
@@ -106,6 +107,16 @@ static inline bool is_error_pfn(kvm_pfn_t pfn)
return !!(pfn & KVM_PFN_ERR_MASK);
}
+/*
+ * When KVM_PFN_ERR_SIGPENDING returned, it means we're interrupted during
+ * fetching the PFN (a signal might have arrived), we may want to retry at
+ * some later point and kick the userspace to handle the signal.
+ */
+static inline bool is_sigpending_pfn(kvm_pfn_t pfn)
+{
+ return pfn == KVM_PFN_ERR_SIGPENDING;
+}
+
/*
* error_noslot pfns indicate that the gfn can not be
* translated to pfn - it is not in slot or failed to
--
2.32.0
next prev parent reply other threads:[~2022-07-21 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 0:03 [PATCH v2 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu
2022-07-21 0:03 ` [PATCH v2 1/3] mm/gup: Add FOLL_INTERRUPTIBLE Peter Xu
2022-07-21 7:55 ` David Hildenbrand
2022-08-17 0:33 ` Peter Xu
2022-07-21 0:03 ` Peter Xu [this message]
2022-08-11 19:41 ` [PATCH v2 2/3] kvm: Add new pfn error KVM_PFN_ERR_SIGPENDING Sean Christopherson
2022-07-21 0:03 ` [PATCH v2 3/3] kvm/x86: Allow to respond to generic signals during slow page faults Peter Xu
2022-08-11 20:12 ` Sean Christopherson
2022-08-11 20:58 ` Peter Xu
2022-08-15 21:26 ` Sean Christopherson
2022-08-16 20:47 ` Peter Xu
2022-08-16 22:51 ` David Matlack
2022-08-17 0:31 ` Peter Xu
2022-08-10 19:38 ` [PATCH v2 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721000318.93522-3-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).