From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9610FC43334 for ; Sun, 24 Jul 2022 10:16:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9F356B0072; Sun, 24 Jul 2022 06:16:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4E9D6B0073; Sun, 24 Jul 2022 06:16:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3D886B0074; Sun, 24 Jul 2022 06:16:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C57796B0072 for ; Sun, 24 Jul 2022 06:16:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9BB58141182 for ; Sun, 24 Jul 2022 10:16:02 +0000 (UTC) X-FDA: 79721587764.01.1F8037E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 4A1128002A for ; Sun, 24 Jul 2022 10:16:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 538B861027; Sun, 24 Jul 2022 10:16:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14614C3411E; Sun, 24 Jul 2022 10:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658657759; bh=O48nzOi2R9qh/OWeuXuKdIr+sSdg6b0BKHyG9bM2AlM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HK08MJbbuX/2xeE7knccMg1L3ztoSF1Q7UvZZX/WEM4G4jU7ehUy8UeVydTLHY/hm HHEgXlhBn0JPwmEPsx9M6TB7pbFiHZj8EMjXwsBryBQ+sr+UUBDJTfQjngJWZIfjVp AJ5L1FbsiQ3Q3DA52C6x820W8Nk50D/g7LRe0vSeKWJubwyDG2JRU138k/MYICim1o fHL/izzaRAUipaVmeW+beQkbT1h9oiQ5cvYXoD+ldpYoE+Dp+RaN3NAq2qghbcBmdb wjbHOAC4KwCAyuqOTXKJplX1MckID2mE/1wrFXIKo9FucMXbs0CAoFVKl72jqwieW1 Dr99gM5d4DuZw== From: SeongJae Park To: Greg KH Cc: Jianglei Nie , sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/damon/reclaim: fix potential memory leak in damon_reclaim_init() Date: Sun, 24 Jul 2022 10:15:57 +0000 Message-Id: <20220724101557.3137-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658657761; a=rsa-sha256; cv=none; b=byDFdwu1QYL2YHbYHQyW/M7AUMcpxjQCINSbr3L15GqxdcKMwN60OsEobCqtCd92a81p5P WGQIOYiE9PdjuFvbU6xmnjPH1A1PK93b9VxSG0WJ6R74vGHnrhISY4riM+GPy1MR+ZfDVN aKcsxDUWuFU+AyymvvQ4hsHSrfDQB94= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HK08MJbb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658657761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FyYz33Ob7tyBu2ZXjWwcu6s/Gy5J+1gLjuZkxrqeKf4=; b=IYiscK6cK+3ResIl5KKI5PJ0s76DcSV5YcqqedLoKX2jpoYj4375R097Ala4VneHdiBwm1 ifKZBxXVPZAq1U5l4YQsMXIuKlp6FcvKqqFnwAImWY7kba4aGSIung5NcH9CeOKv6nLSgB L6JS5wbhVeJLnXIGuWsjFzp4Vv4dxs0= X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HK08MJbb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspamd-Server: rspam01 X-Stat-Signature: 7pwqrf4h8ccpzma9mmw76r5y74nmpo5m X-Rspamd-Queue-Id: 4A1128002A X-HE-Tag: 1658657761-465549 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Jianglei and Greg, On Sun, 24 Jul 2022 09:18:52 +0200 Greg KH wrote: > On Sun, Jul 24, 2022 at 02:52:24PM +0800, Jianglei Nie wrote: > > damon_reclaim_init() allocates a memory chunk for ctx with > > damon_new_ctx(). When damon_select_ops() fails, ctx is not released, which > > will lead to a memory leak. > > > > We should release the ctx with damon_destroy_ctx() when damon_select_ops() > > fails to fix the memory leak. > > > > Fixes: 4d69c3457821 ("mm/damon/reclaim: use damon_select_ops() instead of damon_{v,p}a_set_operations()") > > Signed-off-by: Jianglei Nie > > --- > > mm/damon/reclaim.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c > > index 4b07c29effe9..0b3c7396cb90 100644 > > --- a/mm/damon/reclaim.c > > +++ b/mm/damon/reclaim.c > > @@ -441,8 +441,10 @@ static int __init damon_reclaim_init(void) > > if (!ctx) > > return -ENOMEM; > > > > - if (damon_select_ops(ctx, DAMON_OPS_PADDR)) > > + if (damon_select_ops(ctx, DAMON_OPS_PADDR)) { > > + damon_destroy_ctx(ctx); > > return -EINVAL; > > + } > > > > ctx->callback.after_wmarks_check = damon_reclaim_after_wmarks_check; > > ctx->callback.after_aggregation = damon_reclaim_after_aggregation; > > -- > > 2.25.1 > > > > > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly. > > Thank you for the notice, Greg. Jianglei, please read that great document. And Andrew already added the 'Fixes:' and 'Cc: stable@' tags in the patch when he added[1] it in the mm tree. Hence I think this would be merged in the appropriate stable series once it gets merged in the mainline. [1] https://lore.kernel.org/mm-commits/20220717004946.7AD93C34114@smtp.kernel.org/ Thanks, SJ