From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 339AFC28D13 for ; Tue, 23 Aug 2022 00:08:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8319B6B0074; Mon, 22 Aug 2022 20:08:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E0EB6B0075; Mon, 22 Aug 2022 20:08:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 682528D0001; Mon, 22 Aug 2022 20:08:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 556746B0074 for ; Mon, 22 Aug 2022 20:08:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 29518812EC for ; Tue, 23 Aug 2022 00:08:24 +0000 (UTC) X-FDA: 79828920528.30.7100378 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id B9BFC80017 for ; Tue, 23 Aug 2022 00:08:23 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 69469B8199B; Tue, 23 Aug 2022 00:08:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36841C433D6; Tue, 23 Aug 2022 00:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1661213301; bh=ql3WhYwvtGyV0nnW4S8Tm+rGjMLwd8ee87bzIsZn2ms=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vRwnTZRxoiSrk0tZjUMMz0NWpy3KJjQW1Gzwl4s5BxfTEsZyNaPKh3ddH+egMSRAD 2sR4hnNN+xm0NXU8iGalWA3ooH8VIUWkt4psle8L7uIrU6rbO7bDLYXnhrZRLNscHk bIFHQN8LlfFrHCUIGNFAHen8hRb613xJNDRLoVjU= Date: Mon, 22 Aug 2022 17:08:19 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , Huang@google.com, Shaoqin , Cgroups , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux-MM Subject: Re: [PATCH v6 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses. Message-Id: <20220822170819.60d888a5d3e23f40fd1b2e16@linux-foundation.org> In-Reply-To: References: <20220628220938.3657876-1-yosryahmed@google.com> <20220628220938.3657876-2-yosryahmed@google.com> <20220817102408.7b048f198a736f053ced2862@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661213303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4mQ/RRCqqB3WaViCzYaKNd+wMf81VYa0XotOILtQtk8=; b=EU+L3NOXvO3YuOJmDhHeZBb3AMI++lWACeyejuV5AWhHeaImC+NvOniZ+gi+5adD2vafNp 2JyJHkoFbN5FHDHDzqxw4iwlpZ6TMsBCtbE1YeAfIhbdz9o3adBF5NQaLS06imfPkOSzpy uq8j9S+50wRhR2YzQAYgwOqewPx/ris= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vRwnTZRx; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661213303; a=rsa-sha256; cv=none; b=xzjULCEU+a24ip2ndy/+UqR4ObuAJAHPxN/h55l+kswLfUVzfLCpLJD6amB4EJtk8VXx3P ZnWQIKhmeOlzpUgMSpZNL0D3kjYUiFNJ3tbmlMwZm0pxdTyg068JwfhRgGETc5TLxPCdE8 0jkxuwFWU9HZRKyw/msKRL5fp4nBm5M= X-Rspamd-Queue-Id: B9BFC80017 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vRwnTZRx; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam03 X-Stat-Signature: m6sq8f37hwifsjds6renujxusdat5pwy X-HE-Tag: 1661213303-117548 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 22 Aug 2022 17:04:57 -0700 Yosry Ahmed wrote: > > SecondaryPageTables is too long (unfortunately), it messes up the > > formatting in node_read_meminfo() and meminfo_proc_show(). I would > > prefer "secondary" as well, but I don't know if breaking the format in > > this way is okay. > > Any thoughts here Andrew? Change to SecondaryPageTables anyway? Change > all to use "sec" instead of "secondary"? Leave as-is? Leave as-is, I guess.