From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43DEEC28D13 for ; Thu, 25 Aug 2022 10:11:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7836940009; Thu, 25 Aug 2022 06:11:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B27C7940007; Thu, 25 Aug 2022 06:11:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A25C940009; Thu, 25 Aug 2022 06:11:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 89067940007 for ; Thu, 25 Aug 2022 06:11:37 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 113C7C1A0C for ; Thu, 25 Aug 2022 10:11:37 +0000 (UTC) X-FDA: 79837698234.05.11E66DC Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf29.hostedemail.com (Postfix) with ESMTP id BA0F5120002 for ; Thu, 25 Aug 2022 10:11:36 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id w29so13687718pfj.3 for ; Thu, 25 Aug 2022 03:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=NKL5sVtokizfWAI3mo2jb9YTpdgBm9GDnhWm26Gpw5s=; b=Gy1ISArxPeO5t0wyjubpA3M0UwCqZnmexobJgdIoq7tqU9HMbig6Y+7mGWKf54ECC8 DqQndeO6hmcTQOcP0wGzgvV+4sXY89dYzb7/lyOeA8+OpBHUu8O3rCfoFzhAot3HDtVY Ce7vtNvX7ItLbUkB2MFUwWbkWA/FzUlnDgneBXcMJqO+AhBTgppDm+wxJv3E3ETTr4QA lFF/lELPdk9gCZYniMOeQsec8xH89bdgarwyYZHV7mZzwiPpvZzq/IjP1XQeYBvqQs7V 2fftWuXXkPuQNSe0e7Y7HoDIW6QdtAB1sOCVQ3StK0qJInlmGTpxoS+XYQRxpKtzCGj8 gCaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=NKL5sVtokizfWAI3mo2jb9YTpdgBm9GDnhWm26Gpw5s=; b=f0hTl641z9xQaRoDHsxngEVzT2qkfdzoZl8sotA16O0JPPGNsTlFMprBE3P9L/3/F5 Am6W2nOGC83Krfe9v5XoHp4htAhXROwrQyAdmeN7F+lBv2FHAiVpvliYWP7kUjEV3CJ1 tlkZUy/WF7g8vagXnmIyH8f6IsTW1vlguHAmKjE+CqrSghs0+PiLZXByW13+/un7JIbh NR+j0DJNHf1hJMiHN/kG9Bv+6xqxCFHvhFJI/7LIDcTnL5gsab4Z4jxTg2ZaHIxYFBwE ZP6EL8CnZWAb53LZYjDajgPW1dpxka0h52e4i2qIpHUe/StY2PQibekyzYfiuCxpZaDm BQqQ== X-Gm-Message-State: ACgBeo3tIHlrKYtqsEW859Ekn1a96OjzOn0SFBtQ8kMzjg1G3HjQr1ql iZ6XoH59K0FDthdg0vzhXfy73g== X-Google-Smtp-Source: AA6agR5IcwxykGGpHLVe3CX1H3gs3cvYf5zfNNUsTN/8NtEiGwMN/bJ7KCESq8870YRROxxIqH28lw== X-Received: by 2002:a05:6a00:e8a:b0:535:cc5c:3d87 with SMTP id bo10-20020a056a000e8a00b00535cc5c3d87mr3497198pfb.24.1661422295360; Thu, 25 Aug 2022 03:11:35 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id b10-20020a170903228a00b001714c36a6e7sm8477581plh.284.2022.08.25.03.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 03:11:34 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@redhat.com, kirill.shutemov@linux.intel.com, mika.penttila@nextfour.com, jgg@nvidia.com, tglx@linutronix.de, willy@infradead.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, Qi Zheng Subject: [RFC PATCH 1/7] mm: use ptep_clear() in non-present cases Date: Thu, 25 Aug 2022 18:10:31 +0800 Message-Id: <20220825101037.96517-2-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220825101037.96517-1-zhengqi.arch@bytedance.com> References: <20220825101037.96517-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661422296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NKL5sVtokizfWAI3mo2jb9YTpdgBm9GDnhWm26Gpw5s=; b=wKoc5yWcT9tKIg6Yr9GOx9Tr6jfnFcFNs7bjfqP2T1hpdJAqaQ35kgsCNxmG3MEeIKcLMW XeFNELV8iettrJgBybkcvT+xkKxf1Yomyzql6O2Pk+jaxCS/8F6uL2TaC4kcVn/rEp+4tO HKf0lKW8Y6QrjAtMD8dzp0sOgQn5o10= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Gy1ISArx; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661422296; a=rsa-sha256; cv=none; b=1WWl09+VNbEQfX9Vf5GctxrDXukFtZf6pukrEVIQ295CXrU+uJ7WGcekSRPU6bmB3ewEhL HU3dAK5PwEUQ0J7H8xK79i6OaQKaU72+aRdfVmQFFYgc+/Z69UYUTjRtgvavnqLVmFiGLp l/lGes7S0mS+Ac2odLHU8kGP8CPZPhA= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Gy1ISArx; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BA0F5120002 X-Stat-Signature: bswgp9nxdb9rwn6pawujre3p6kzwqc3j X-Rspam-User: X-HE-Tag: 1661422296-588769 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: After commit 08d5b29eac7d ("mm: ptep_clear() page table helper"), the ptep_clear() can be used to track the clearing of PTE entries, but it skips some places since the page table check does not care about non-present PTE entries. Subsequent patches need to use ptep_clear() to track all clearing PTE entries, so this patch makes ptep_clear() used for all cases including clearing non-present PTE entries. Signed-off-by: Qi Zheng --- include/linux/pgtable.h | 2 +- mm/memory.c | 2 +- mm/mprotect.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index 3cdc16cfd867..9745684b0cdb 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -428,7 +428,7 @@ static inline void pte_clear_not_present_full(struct mm_struct *mm, pte_t *ptep, int full) { - pte_clear(mm, address, ptep); + ptep_clear(mm, address, ptep); } #endif diff --git a/mm/memory.c b/mm/memory.c index 1c6027adc542..207e0ee657e9 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3655,7 +3655,7 @@ static vm_fault_t pte_marker_clear(struct vm_fault *vmf) * none pte. Otherwise it means the pte could have changed, so retry. */ if (is_pte_marker(*vmf->pte)) - pte_clear(vmf->vma->vm_mm, vmf->address, vmf->pte); + ptep_clear(vmf->vma->vm_mm, vmf->address, vmf->pte); pte_unmap_unlock(vmf->pte, vmf->ptl); return 0; } diff --git a/mm/mprotect.c b/mm/mprotect.c index ba5592655ee3..1a01bd22a4ed 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@ -201,7 +201,7 @@ static unsigned long change_pte_range(struct mmu_gather *tlb, * fault will trigger without uffd trapping. */ if (uffd_wp_resolve) { - pte_clear(vma->vm_mm, addr, pte); + ptep_clear(vma->vm_mm, addr, pte); pages++; } continue; -- 2.20.1