From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9263FECAAA2 for ; Fri, 26 Aug 2022 00:08:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFA206B0074; Thu, 25 Aug 2022 20:08:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA989940007; Thu, 25 Aug 2022 20:08:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D49BC6B0078; Thu, 25 Aug 2022 20:08:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C655C6B0074 for ; Thu, 25 Aug 2022 20:08:11 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9F17B16067D for ; Fri, 26 Aug 2022 00:08:11 +0000 (UTC) X-FDA: 79839806382.05.7204687 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 4D9D7A0017 for ; Fri, 26 Aug 2022 00:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661472490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hdzMOeIUQobXozAoBo+0gU24p6eUcuhYf3lPGxm6UuE=; b=apDyk8BTriPPJQDPLcHevevogWq7sS8WVkJWp/gl7NyT5rOQmgGZWMuZT34ZnCv4j3+eZL gPPrJvPgz3wHrDopir3v0j/OGG0rS5BccIO3HNdk8I5KI6hBF1im6CoFXy2RsHKKRX9z+k lBsEkVcca62PP/xbU3rStDHgA3vOyrQ= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-127-wgXpF6-WMQ2q8BzxUYRhPw-1; Thu, 25 Aug 2022 20:08:09 -0400 X-MC-Unique: wgXpF6-WMQ2q8BzxUYRhPw-1 Received: by mail-il1-f199.google.com with SMTP id l20-20020a056e02067400b002dfa7256498so54294ilt.4 for ; Thu, 25 Aug 2022 17:08:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc; bh=hdzMOeIUQobXozAoBo+0gU24p6eUcuhYf3lPGxm6UuE=; b=F3lJmQ/FNwpoeF4hdGcjkAW6wG5txSGuGMEAjTxrZxxQfq3UcMOpx8rFhvqL7Dsm5f vJKzA7aTmEHN54snljwXXjrDrf3jJp/Q2Jdmq7WQaHsRw5ftaJ+5KFR8dxyrKB8RFyDJ kzqriYBQVgUts0Ps3c+nzo3Cj3hAzpFiO+uB6BFs96s6WgG6KWttqE6OQTUCIwSLAt2D HmxGJlm/cV/C7rer/y/rzkcc/bhy36Jl5HcDd8gINegb+q3po/pu7RMlkqhtnShYBD9A fsBS+3ASadvOYeN/+bC63YNUsJ3SZG6ZGoxm72z6l9LL+61FOc5Zb9gf0GAGT6cqSHz3 Lq+w== X-Gm-Message-State: ACgBeo12sm51x8yYm/pX6gJAXAqkbCQRx7s6EqmpV5GzEkqwNM8OAMsE ij99iKTVQe5Q4EX7H1Ty77oZtC7PCb3V2v1cYHIZfVbSQ2aO4SC5mVPuSOBAd04+Wc2HJeHMUKU 1e7CBqmIGkFo= X-Received: by 2002:a05:6638:248c:b0:349:fddf:b80c with SMTP id x12-20020a056638248c00b00349fddfb80cmr2976474jat.261.1661472489142; Thu, 25 Aug 2022 17:08:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR7ipYtHVVpEtusLYEDloHY4DKd6rUFDwJESB2zw/7x6ZSRdqLCMTAAE/E8tx/dwxcID0l2k4g== X-Received: by 2002:a05:6638:248c:b0:349:fddf:b80c with SMTP id x12-20020a056638248c00b00349fddfb80cmr2976462jat.261.1661472488897; Thu, 25 Aug 2022 17:08:08 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id v6-20020a6bac06000000b00688dd369c7esm295480ioe.55.2022.08.25.17.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 17:08:08 -0700 (PDT) Date: Thu, 25 Aug 2022 18:08:07 -0600 From: Alex Williamson To: "Laba, SlawomirX" Cc: "linux-pci@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "regressions@lists.linux.dev" , "bhelgaas@google.com" , "kvm@vger.kernel.org" , "linux-mm@kvack.org" , "songmuchun@bytedance.com" , "mike.kravetz@oracle.com" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , Andrew Morton Subject: Re: BUG: Virtual machine fails to start on 6.0-rc2 Message-ID: <20220825180807.020471c8.alex.williamson@redhat.com> In-Reply-To: References: Organization: Red Hat MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661472491; a=rsa-sha256; cv=none; b=XpB0SIkknYbYvtexPvh0pbv0gp2WRDzYxYrRXqN50u64zWra/+xstD5xxLIMtjO8Z8MBBj nfH5px9QxPoWSzdJE4DoIcj3orzpd1McX7DYulNxpS4EmBCoD8A6CBa9KYuj3NOOn8b166 C3g7YOGvBYh8QWWaXlXMTsBelmQQUmE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=apDyk8BT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661472491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hdzMOeIUQobXozAoBo+0gU24p6eUcuhYf3lPGxm6UuE=; b=v24mqOnNLhNIfY8adliDhn6rekzsCk1ZmNwY8oNaajm8ZLEqfhgZTr5pajbHCwHEUkwdim AmDKg7OTuxbfZ09TxdcGfsxmYZY7S0infdzWHRQv6ZRCGw2XRfKG99oBkiWkRt/j7vBZb2 JSPgbgqTpwNQJ7g/RlMQ3HpsubFohds= X-Stat-Signature: zzfa61bgwx6ku4cbju37dp564nccks4x X-Rspamd-Queue-Id: 4D9D7A0017 X-Rspam-User: X-Rspamd-Server: rspam11 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=apDyk8BT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com X-HE-Tag: 1661472491-612277 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 25 Aug 2022 23:42:47 +0000 "Laba, SlawomirX" wrote: > We were testing the changes for our VF devices and noticed an issue > when starting VMs with passthrough VFs. We then moved back to > mainline kernel and reproduced the issue on 6.0-rc2 > > We noticed that the startup of the KVM hangs. > > Steps to reproduce: > Create a VF from the PF interface. > Configure VM XML with the VF PCI. > Start the KVM. > > To isolate the issue we moved back to kernel 5.19 and it was working > fine. > > Working tag v5.19 > Tested failing commit 4c612826bec1 Does this resolve the issue? https://lore.kernel.org/all/166015037385.760108.16881097713975517242.stgit@omen/ This is currently in Andrew's mm-hotfixes-unstable branch and we're waiting for it to be merged to mainline. Thanks, Alex > [root@localhost sl]# uname -r > 6.0.0-rc2-00159-g4c612826bec1 > [root@localhost sl]# echo 1 > > /sys/class/net/ens785f3/device/sriov_numvfs [root@localhost sl]# > virsh start rhel_9_0_first ^C > [root@localhost sl]# virsh list --all > Id Name State > ------------------------------- > 1 rhel_9_0_first paused > > Dmesg: > [ +0.042400] iavf: Intel(R) Ethernet Adaptive Virtual Function > Network Driver [ +0.000004] Copyright (c) 2013 - 2018 Intel > Corporation. [ +0.000309] iavf 0000:18:19.0: enabling device (0000 > -> 0002) [ +0.073471] iavf 0000:18:19.0: Invalid MAC address > 00:00:00:00:00:00, using random [ +0.000674] iavf 0000:18:19.0: > Multiqueue Enabled: Queue pair count = 16 [ +0.000466] iavf > 0000:18:19.0: MAC address: 5a:0c:b5:f7:4f:0b [ +0.000003] iavf > 0000:18:19.0: GRO is enabled [ +0.005941] iavf 0000:18:19.0 > ens785f3v0: renamed from eth0 [ +0.179174] IPv6: > ADDRCONF(NETDEV_CHANGE): ens785f3v0: link becomes ready [ +0.000040] > iavf 0000:18:19.0 ens785f3v0: NIC Link is Up Speed is 25 Gbps Full > Duplex [ +26.408503] bridge: filtering via arp/ip/ip6tables is no > longer available by default. Update your scripts to load br_netfilter > if you need this. [ +0.399621] VFIO - User Level meta-driver > version: 0.3 [ +0.151579] iavf 0000:18:19.0: Remove device [ > +0.292158] ice 0000:18:00.3 ens785f3: Setting MAC 52:54:00:9f:ea:de > on VF 0. VF driver will be reinitialized [ +0.083676] ice > 0000:18:00.3: Clearing port VLAN on VF 0 [ +0.155905] tun: Universal > TUN/TAP device driver, 1.6 [ +0.000976] virbr0: port 1(vnet0) > entered blocking state [ +0.000017] virbr0: port 1(vnet0) entered > disabled state [ +0.000052] device vnet0 entered promiscuous mode [ > +0.000244] virbr0: port 1(vnet0) entered blocking state [ +0.000003] > virbr0: port 1(vnet0) entered listening state [ +2.019924] virbr0: > port 1(vnet0) entered learning state [ +2.047997] virbr0: port > 1(vnet0) entered forwarding state [ +0.000018] virbr0: topology > change detected, propagating [Aug25 19:12] INFO: task khugepaged:507 > blocked for more than 122 seconds. [ +0.000016] Tainted: G > W I 6.0.0-rc2-00159-g4c612826bec1 #1 [ +0.000010] "echo 0 > > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ > > +0.000010] task:khugepaged state:D stack: 0 pid: 507 ppid: > > 2 flags:0x00004000 [ +0.000004] Call Trace: > [ +0.000001] > [ +0.000003] __schedule+0x1bc/0x550 > [ +0.000006] ? osq_unlock+0xf/0x90 > [ +0.000005] schedule+0x5d/0xd0 > [ +0.000002] rwsem_down_write_slowpath+0x2c9/0x5e0 > [ +0.000004] ? find_vma+0x64/0x70 > [ +0.000004] collapse_huge_page+0x1f8/0x8a0 > [ +0.000004] ? _raw_spin_unlock+0x14/0x30 > [ +0.000002] ? preempt_count_add+0x70/0xa0 > [ +0.000005] ? _raw_spin_lock_irqsave+0x21/0x30 > [ +0.000001] ? lock_timer_base+0x61/0x80 > [ +0.000005] khugepaged_scan_pmd+0x33d/0x7b0 > [ +0.000003] khugepaged_scan_mm_slot+0x155/0x440 > [ +0.000003] khugepaged+0x189/0x3e0 > [ +0.000002] ? preempt_count_add+0x70/0xa0 > [ +0.000002] ? _raw_spin_unlock_irqrestore+0x1e/0x40 > [ +0.000002] ? khugepaged_scan_mm_slot+0x440/0x440 > [ +0.000001] kthread+0xf0/0x120 > [ +0.000003] ? kthread_complete_and_exit+0x20/0x20 > [ +0.000003] ret_from_fork+0x1f/0x30 > [ +0.000006] > > On the working version there is a line that enables the interface for > the VF which is missing on non-working one: [ +0.911730] vfio-pci > 0000:18:19.0: enabling device (0000 -> 0002) >