From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32C65ECAAD5 for ; Mon, 29 Aug 2022 07:42:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92997940008; Mon, 29 Aug 2022 03:42:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D791940007; Mon, 29 Aug 2022 03:42:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78464940008; Mon, 29 Aug 2022 03:42:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 69BCD940007 for ; Mon, 29 Aug 2022 03:42:14 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 41A4E1C5C71 for ; Mon, 29 Aug 2022 07:42:14 +0000 (UTC) X-FDA: 79851836988.18.E4C11B5 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by imf24.hostedemail.com (Postfix) with ESMTP id A3FE818001B for ; Mon, 29 Aug 2022 07:42:13 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 339EB5C0053; Mon, 29 Aug 2022 03:42:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 29 Aug 2022 03:42:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1661758933; x= 1661845333; bh=4C06KhMTykWiCxdjtJmo+Tc7LuTjHECyvZLNTCPlv+4=; b=d LWYBo7aC1lWT2Hv5/HeRFrhQ9Hqfm8nmQYp8FdMhVnShgG8tNzzMjhc5n9Zq5hJj U+eRKVnb1aKU91zDAq6nuAwI2ZN1EI9G65dEDR8VjQRyDuDxTeLc3YvzX7kUXuBP iY44gZPV0s0rTI/2t5IQEXWnDLHXnj487xRkK9gV1TQ7K9JO/doZ43Y135vHJ2w+ 1XQmM99I4J7Iwja/IekwTElxD4RZhYbycHCksUQ3Jtbn6kk8jk2uaxtw5I/N57fu TolTruvSoHrIS+L6lkCvxL7jKYv8nb98aJJgy+9+/dHL4PdjFYGYAYEFyc3ok86e i3Yv2lBPfB7GgByKL0Srw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1661758933; x= 1661845333; bh=4C06KhMTykWiCxdjtJmo+Tc7LuTjHECyvZLNTCPlv+4=; b=W Vlai/Hizehliq6lCnC/UL5yWHWhmDIsWHH+b0FpbnE44x1MmMxKBAq656ZEh4OzU ozzlutt+CMOHSaaRyUYStyiq9TcigCsK6Vqct1v3m+ilfCFmxI0UUgrlOUyTuWMa YYngUYiqj0Lu25q2tRylpvzinYY3IpCtVK8B3XA5hvI6gjFfBbcjEYm7LlNk1mEF k/ZEVJpZcANP32EfmaI1aDVGdRPlkT8t6WIDsA0GsNlOKGYMHMZ6EIx3IpRrJ/ea 5OL0ak3WvDnaIL0B4jT6fjdL7gdFG4vJ+2MYKcZ2LXOrwBsag0fNHdAIDOIumjKM Knt8/pQE9zz5t2y1MYK4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdektddguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgesthhqredttddtudenucfhrhhomhepofgr gihimhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtf frrghtthgvrhhnpeejvdetffeugeegfefghfefjeelleffkedttefhiedtlefhgfegteei gfduledtveenucffohhmrghinhepkhgvrhhnvghlrdhorhhgpddtuddrohhrghenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvges tggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Aug 2022 03:42:12 -0400 (EDT) Date: Mon, 29 Aug 2022 09:42:09 +0200 From: Maxime Ripard To: Julia Lawall Cc: Linux Memory Management List , kbuild-all@lists.01.org Subject: Re: [linux-next:master 331/3266] drivers/gpu/drm/vc4/vc4_hdmi.c:1459:2-8: preceding lock on line 1456 (fwd) Message-ID: <20220829074209.nvpvqmu54mbbdomz@houat> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661758933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4C06KhMTykWiCxdjtJmo+Tc7LuTjHECyvZLNTCPlv+4=; b=UXiz7NSTNCtFZoKTqkZlOg3mpaKC1AVvnFt8XGoy+IgT1U6t0CtMUdtgQIxg67zd30pEU6 h/Feo6NeSgK/C1ocvuRYqkKgzX9Mw8hN1yv9iLCmAeXdQoWe5ZvwZfBBTMGg0+iqwNBsnB WJNBIE6+wXImdKyOs9aumI1KKg10Gls= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=cerno.tech header.s=fm3 header.b="d LWYBo7"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="W Vlai/H"; dmarc=pass (policy=none) header.from=cerno.tech; spf=pass (imf24.hostedemail.com: domain of maxime@cerno.tech designates 66.111.4.29 as permitted sender) smtp.mailfrom=maxime@cerno.tech ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661758933; a=rsa-sha256; cv=none; b=b+mjehRqNMBS47BY/B4kmTJBwaN7xEFt3C2yi2jMrgFda12/vjjrdBbaAKUsbCKZLSowZt YCsd+9VFrchjNhVlg5m7JAOYRrsow8cKhl6vZfm+bgduUO08OMnY7TAbYLPjIsEyxb9HGD TmgxAQfV0SQ2ARTEis9smCBHU6/skLU= X-Stat-Signature: poyoq1has8prbek49a4pnsucdbbiqspj X-Rspamd-Queue-Id: A3FE818001B Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=cerno.tech header.s=fm3 header.b="d LWYBo7"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="W Vlai/H"; dmarc=pass (policy=none) header.from=cerno.tech; spf=pass (imf24.hostedemail.com: domain of maxime@cerno.tech designates 66.111.4.29 as permitted sender) smtp.mailfrom=maxime@cerno.tech X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1661758933-654758 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Julia On Sat, Aug 27, 2022 at 04:33:11PM +0200, Julia Lawall wrote: > Please check whether anunlock is needed before line 1459. >=20 > julia >=20 > ---------- Forwarded message ---------- > Date: Fri, 26 Aug 2022 07:43:10 +0800 > From: kernel test robot > To: kbuild@lists.01.org > Cc: lkp@intel.com, Julia Lawall > Subject: [linux-next:master 331/3266] drivers/gpu/drm/vc4/vc4_hdmi.c:1459= :2-8: > preceding lock on line 1456 >=20 > BCC: lkp@intel.com > CC: kbuild-all@lists.01.org > CC: Linux Memory Management List > TO: Maxime Ripard >=20 > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: b5d939c951865f6fc229094e84b77c9a9e0ed0c7 > commit: cd00ed5187bff03d4c2ba143a5993383dd6ed66c [331/3266] drm/vc4: hdmi= : Protect device resources after removal > :::::: branch date: 18 hours ago > :::::: commit date: 6 weeks ago > config: arm64-randconfig-c44-20220824 (https://download.01.org/0day-ci/ar= chive/20220826/202208260727.0o3WQ2wp-lkp@intel.com/config) > compiler: aarch64-linux-gcc (GCC) 12.1.0 >=20 > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > Reported-by: Julia Lawall >=20 > cocci warnings: (new ones prefixed by >>) > >> drivers/gpu/drm/vc4/vc4_hdmi.c:1459:2-8: preceding lock on line 1456 > drivers/gpu/drm/vc4/vc4_hdmi.c:1429:2-8: preceding lock on line 1426 >=20 > vim +1459 drivers/gpu/drm/vc4/vc4_hdmi.c >=20 > c8b75bca92cbf0 Eric Anholt 2015-03-02 1442 > 8d9147466776c4 Maxime Ripard 2020-12-15 1443 static void vc4_hdmi_encod= er_post_crtc_enable(struct drm_encoder *encoder, > 8d9147466776c4 Maxime Ripard 2020-12-15 1444 struct drm_atom= ic_state *state) > 09c438139b8f5b Maxime Ripard 2020-09-03 1445 { > 09c438139b8f5b Maxime Ripard 2020-09-03 1446 struct vc4_hdmi *vc4_hdmi= =3D encoder_to_vc4_hdmi(encoder); > cd00ed5187bff0 Maxime Ripard 2022-07-11 1447 struct drm_device *drm = =3D vc4_hdmi->connector.dev; > 633be8c3c0c5e0 Maxime Ripard 2021-10-25 1448 struct drm_display_mode *= mode =3D &vc4_hdmi->saved_adjusted_mode; > c3c2f38ce532c6 Jos=E9 Exp=F3sito 2022-04-20 1449 struct drm_display_in= fo *display =3D &vc4_hdmi->connector.display_info; > 8b3f90e98e1764 Maxime Ripard 2020-09-03 1450 bool hsync_pos =3D mode->= flags & DRM_MODE_FLAG_PHSYNC; > 8b3f90e98e1764 Maxime Ripard 2020-09-03 1451 bool vsync_pos =3D mode->= flags & DRM_MODE_FLAG_PVSYNC; > 81fb55e500a82a Maxime Ripard 2021-10-25 1452 unsigned long flags; > 09c438139b8f5b Maxime Ripard 2020-09-03 1453 int ret; > cd00ed5187bff0 Maxime Ripard 2022-07-11 1454 int idx; > c8b75bca92cbf0 Eric Anholt 2015-03-02 1455 > 82cb88af12d29e Maxime Ripard 2021-10-25 @1456 mutex_lock(&vc4_hdmi->mut= ex); > 82cb88af12d29e Maxime Ripard 2021-10-25 1457 > cd00ed5187bff0 Maxime Ripard 2022-07-11 1458 if (!drm_dev_enter(drm, &= idx)) > cd00ed5187bff0 Maxime Ripard 2022-07-11 @1459 return; Thanks for the report. You're right this was a bug, but it should have been addressed by https://lore.kernel.org/all/20220824161327.330627-2-dakr@redhat.com/ Maxime