linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, songmuchun@bytedance.com,
	mike.kravetz@oracle.com, willy@infradead.org, vbabka@suse.cz,
	william.kucharski@oracle.com, dhowells@redhat.com,
	peterx@redhat.com, arnd@arndb.de, ccross@google.com,
	hughd@google.com, ebiederm@xmission.com,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [PATCH 0/7] begin converting hugetlb code to folios
Date: Mon, 29 Aug 2022 16:00:07 -0700	[thread overview]
Message-ID: <20220829230014.384722-1-sidhartha.kumar@oracle.com> (raw)

This patch series starts the conversion of the hugetlb code to operate
on struct folios rather than struct pages. This removes the ambiguitiy
of whether functions are operating on head pages, tail pages of compound
pages, or base pages. 

This series passes the linux test project hugetlb test cases.

Patch 1 adds hugeltb specific page macros that can operate on folios.

Patch 2 adds the private field of the first tail page to struct page.
This patch depends on Matthew Wilcox's patch mm: Add the first tail
page to struct folio[1]:

Patchs 3-4 introduce hugetlb subpool helper functions which operate on
struct folios. These patches were tested using the hugepage-mmap.c
selftest along with the migratepages command.

Patch 5 converts hugetlb_delete_from_page_cache() to use folios.
This patch depends on Mike Kravetz's patch: hugetlb: rename 
remove_huge_page to hugetlb_delete_from_page_cache[2]:


Patch 6 adds a folio_hstate() function to get hstate information from a
folio.

Patch 7 adds a user of folio_hstate().

Bpftrace was used to track time spent in the free_huge_pages function
during the ltp test cases as it is a caller of the hugetlb subpool
functions. From the histogram, the performance is similar before and
after the patch series. 

Time spent in 'free_huge_page'

6.0.0-rc2.master.20220823
@nsecs:
[256, 512)         14770 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@|
[512, 1K)            155 |                                                    |
[1K, 2K)             169 |                                                    |
[2K, 4K)              50 |                                                    |
[4K, 8K)              14 |                                                    |
[8K, 16K)              3 |                                                    |
[16K, 32K)             3 |                                                    |


6.0.0-rc2.master.20220823 + patch series
@nsecs: 
[256, 512)         13678 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@|
[512, 1K)            142 |                                                    |
[1K, 2K)             199 |                                                    |
[2K, 4K)              44 |                                                    |
[4K, 8K)              13 |                                                    |
[8K, 16K)              4 |                                                    |
[16K, 32K)             1 |                                                    |

[1] https://lore.kernel.org/linux-mm/20220808193430.3378317-6-willy@infradead.org/
[2] https://lore.kernel.org/all/20220824175757.20590-4-mike.kravetz@oracle.com/T/#me431952361ea576862d7eb617a5dced9807dbabb

Sidhartha Kumar (7):
  mm/hugetlb: add folio support to hugetlb specific flag macros
  mm: add private field of first tail to struct page and struct folio
  mm/hugetlb: add hugetlb_folio_subpool() helper
  mm/hugetlb: add hugetlb_set_folio_subpool() helper
  mm/hugetlb: convert hugetlb_delete_from_page_cache() to use folios
  mm/hugetlb add folio_hstate()
  mm/migrate: use folio_hstate() in alloc_migration_target()

 fs/hugetlbfs/inode.c     | 22 ++++++++++----------
 include/linux/hugetlb.h  | 45 ++++++++++++++++++++++++++++++++++++----
 include/linux/mm_types.h | 15 ++++++++++++++
 mm/migrate.c             |  2 +-
 4 files changed, 68 insertions(+), 16 deletions(-)

-- 
2.31.1



             reply	other threads:[~2022-08-29 23:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29 23:00 Sidhartha Kumar [this message]
2022-08-29 23:00 ` [PATCH 1/7] mm/hugetlb: add folio support to hugetlb specific flag macros Sidhartha Kumar
2022-08-30  3:33   ` Matthew Wilcox
2022-08-30 18:09     ` Sidhartha Kumar
2022-09-01 16:55       ` Mike Kravetz
2022-08-29 23:00 ` [PATCH 2/7] mm: add private field of first tail to struct page and struct folio Sidhartha Kumar
2022-08-30  3:36   ` Matthew Wilcox
2022-09-01 17:32   ` Mike Kravetz
2022-09-01 18:32     ` Matthew Wilcox
2022-09-01 20:29       ` Mike Kravetz
2022-08-29 23:00 ` [PATCH 3/7] mm/hugetlb: add hugetlb_folio_subpool() helper Sidhartha Kumar
2022-08-29 23:00 ` [PATCH 4/7] mm/hugetlb: add hugetlb_set_folio_subpool() helper Sidhartha Kumar
2022-08-29 23:00 ` [PATCH 5/7] mm/hugetlb: convert hugetlb_delete_from_page_cache() to use folios Sidhartha Kumar
2022-08-30  3:26   ` Matthew Wilcox
2022-08-30 16:47     ` Sidhartha Kumar
2022-08-29 23:00 ` [PATCH 6/7] mm/hugetlb add folio_hstate() Sidhartha Kumar
2022-09-01 18:34   ` Mike Kravetz
2022-08-29 23:00 ` [PATCH 7/7] mm/migrate: use folio_hstate() in alloc_migration_target() Sidhartha Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220829230014.384722-1-sidhartha.kumar@oracle.com \
    --to=sidhartha.kumar@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=ccross@google.com \
    --cc=dhowells@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=peterx@redhat.com \
    --cc=songmuchun@bytedance.com \
    --cc=vbabka@suse.cz \
    --cc=william.kucharski@oracle.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).