From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F15F7ECAAD5 for ; Mon, 5 Sep 2022 14:33:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F813801E2; Mon, 5 Sep 2022 10:33:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A6108D0076; Mon, 5 Sep 2022 10:33:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76EE9801E2; Mon, 5 Sep 2022 10:33:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 682F58D0076 for ; Mon, 5 Sep 2022 10:33:57 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4A68B80DC2 for ; Mon, 5 Sep 2022 14:33:57 +0000 (UTC) X-FDA: 79878276114.31.45ABDCB Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf24.hostedemail.com (Postfix) with ESMTP id 906ED180095 for ; Mon, 5 Sep 2022 14:33:56 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 3D5E668AA6; Mon, 5 Sep 2022 16:33:51 +0200 (CEST) Date: Mon, 5 Sep 2022 16:33:51 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Greg Kroah-Hartman , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Stephen Bates Subject: Re: [PATCH v9 2/8] iov_iter: introduce iov_iter_get_pages_[alloc_]flags() Message-ID: <20220905143351.GA5813@lst.de> References: <20220825152425.6296-1-logang@deltatee.com> <20220825152425.6296-3-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825152425.6296-3-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=none (imf24.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662388437; a=rsa-sha256; cv=none; b=e3D+yZULLxBC+lXteFTr6QTqXNgWVqf9nW/Tme+ARDOBkAecOolKzLxM3aD9o7F0iyS/VE DubkUfZqRTeAksCZsyxQZ09/bUl/EZixZXxjjwEFeaYE3Hhj7zVfAhjE6upp9HiY9OZ5tS DlBJsrJ1YW0GG/n49/pvzd0gioPIF/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662388436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y4/jKaf/eLcqZPk6lC+3R154Ru296Ee+lt5Q6AOm3dE=; b=E05U+bekl5DFan4yPWGqhgqWsyufQjy4wW3rssCb/AzP6QU0XmlfmD7ZMSJsdrThOu9XUR Rn8yBR+hpkeeZuo3J7RbdfoC7iMsZ29oOb91NSQxUwG61+fm/3gk4SP046Rja5iO5QG/g6 EwDv6Mrf1c8xTvHOYesrLCUOlRnBhi4= Authentication-Results: imf24.hostedemail.com; dkim=none; spf=none (imf24.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspam-User: X-Stat-Signature: cgna1n67sxsn6zjek9yfk8awagpi5mo8 X-Rspamd-Queue-Id: 906ED180095 X-Rspamd-Server: rspam05 X-HE-Tag: 1662388436-366110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 25, 2022 at 09:24:19AM -0600, Logan Gunthorpe wrote: > Add iov_iter_get_pages_flags() and iov_iter_get_pages_alloc_flags() > which take a flags argument that is passed to get_user_pages_fast(). > > This is so that FOLL_PCI_P2PDMA can be passed when appropriate. Any reason why iov_iter_get_pages2 doesn't call iov_iter_get_pages_flags and same for the __alloc version? Also with the "main" version now having the 2 postfix, we can just use the iov_iter_get_pages name for the flags version, and maybe eventually just convert all users over to it.