From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70DA7ECAAD5 for ; Mon, 5 Sep 2022 14:36:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12F788D0076; Mon, 5 Sep 2022 10:36:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E00B801E6; Mon, 5 Sep 2022 10:36:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F10678D0099; Mon, 5 Sep 2022 10:36:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E35498D0076 for ; Mon, 5 Sep 2022 10:36:39 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C75041602DA for ; Mon, 5 Sep 2022 14:36:39 +0000 (UTC) X-FDA: 79878282918.12.18BE9A4 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf23.hostedemail.com (Postfix) with ESMTP id 60F0B140076 for ; Mon, 5 Sep 2022 14:36:39 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id E999768BFE; Mon, 5 Sep 2022 16:36:34 +0200 (CEST) Date: Mon, 5 Sep 2022 16:36:34 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Greg Kroah-Hartman , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Stephen Bates Subject: Re: [PATCH v9 5/8] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages() Message-ID: <20220905143634.GD5813@lst.de> References: <20220825152425.6296-1-logang@deltatee.com> <20220825152425.6296-6-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825152425.6296-6-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662388599; a=rsa-sha256; cv=none; b=o9xj2cgJRTGV7WONo/bsAtEsfxpbE5iST1byjMMBm9bmV6O53hIXyjHcxO2N/JuzpXqwFZ +lpIaeTmAVBgMecR60di9AdPgSPJ18+/Zwq03csjxsOg991XpK40SDzKko+rlWtE7+qHB7 UAfJp6UB3QHhrKLS5qa6XCIg4DtYhdk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662388599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VbAFdpoPXWbRZlhuN33kyDdubb2U+AU+TS+0sItsAU8=; b=0xYWWc7+nVi3Kwrph9yQ9bZvy1aK6QOQLi2rM+V7XJt4ik5tEirPiFNrK0VLEGdciX4z+r JRa6UJl5dNPZn9f46nQbbBNM5i9NaiY+QvqVvA0e8kMLI7rbwkqv7Bi0GtkyrNr2qwPhIk myCG9zucErHnYK7VQJxr7kCxMQMxZyM= X-Rspamd-Server: rspam02 X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Stat-Signature: hxprt8kuuyak7zjxc7rwkumghp4nkixi X-Rspamd-Queue-Id: 60F0B140076 X-HE-Tag: 1662388599-837512 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 25, 2022 at 09:24:22AM -0600, Logan Gunthorpe wrote: > + if (bio->bi_bdev && bio->bi_bdev->bd_disk && > + blk_queue_pci_p2pdma(bio->bi_bdev->bd_disk->queue)) bdev->bd_disk is never NULL. Otherwise looks good: Reviewed-by: Christoph Hellwig