From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 228C7C6FA82 for ; Tue, 13 Sep 2022 14:41:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 540846B0071; Tue, 13 Sep 2022 10:41:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EF278D0001; Tue, 13 Sep 2022 10:41:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DE496B0073; Tue, 13 Sep 2022 10:41:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3041A6B0071 for ; Tue, 13 Sep 2022 10:41:24 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E14221406A2 for ; Tue, 13 Sep 2022 14:41:15 +0000 (UTC) X-FDA: 79907324910.10.AD641EA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 7E23A1400B7 for ; Tue, 13 Sep 2022 14:41:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 89C58614B7; Tue, 13 Sep 2022 14:41:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C540AC43150; Tue, 13 Sep 2022 14:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663080074; bh=0Iu5DsvC2OjaeqYGhwmLixwDgdWUl/BFj6dhTq4RAts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p9Zm7asacy4VFjm24SgyTL0RRdpJv68cAyH0gdlTLHAHQg+8sQHqWn/+3anIjp6IG wwLvL+MdXvOS9NT8hhDH6UklUcGMa3rcncpD51I6+EXMec52o59k2Qi0Ey76Wfp1Tf Yq1CNCaySzlU6sxB8GeIRvWTCf2lF4xvLrRyP7KAIS4uESjxQt5XukzZcPkWNaYi4a Sdvk2W7L8RRvrlFQt6ljuAqr68jVK+vALzs1DfS+v13/OB5wGsG3T0xVF66TYIKj/H 6PO+4ZjiGM98bH32tLQGDytl4cq83o+5vK/dsctgjUpw82j9zCJVDqcb4S1R7oxALp lh4CI7QYQY7cQ== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] mm/damon/sysfs: use the wrapper directly to check if the kdamond is running Date: Tue, 13 Sep 2022 14:41:12 +0000 Message-Id: <20220913144112.95690-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1662995513-24489-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663080075; a=rsa-sha256; cv=none; b=6NZxkc1Z2JckqKMuBTVAKTh7h+IPQqWS0XE5UlRzYxfSYJYiC09taTfjPAAQUCzqUaYWsd n02CUR5liPGcJuQGXwCEQITsyD+eRyhH+KGurFS3oP4nTxuGwxMSfnZnxr6hWn2kRRJbGD co44/HNEKLAKu/ak/1fQ9rmiA2JzKhs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p9Zm7asa; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663080075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ff9+4HuExaNxehyyUnv08ibFUclpJEbIWBvzG1J3oWA=; b=G2hLcTq0Wpc9e2YkGy8kZaJ6zJ/GSekaUgDHzbQOSRWnW5mlbMsZjfmgOwAwpr3ld/8otR Ds/BEYbTfosCvmYQ0ak1lO8GV/h556L0NEFgWvGTLU2rjFbmBv4bIGJdpAnFutjmx8/+ex Nz6C8h/uCqEKWUye9GUqh8L9zUognqg= X-Stat-Signature: otcdw7dotfzwki8khzy8ghuain71hk5d X-Rspamd-Queue-Id: 7E23A1400B7 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p9Zm7asa; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1663080075-350809 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kaixu, On Mon, 12 Sep 2022 23:11:53 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > We can use the 'damon_sysfs_kdamond_running()' wrapper directly to > check if the kdamond is running in 'damon_sysfs_turn_damon_on()'. > > Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/sysfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 7488e27c87c3..84861c4085a5 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -2455,8 +2455,7 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond) > struct damon_ctx *ctx; > int err; > > - if (kdamond->damon_ctx && > - damon_sysfs_ctx_running(kdamond->damon_ctx)) > + if (damon_sysfs_kdamond_running(kdamond)) > return -EBUSY; > if (damon_sysfs_cmd_request.kdamond == kdamond) > return -EBUSY; > -- > 2.27.0 >