From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB36EC6FA82 for ; Tue, 13 Sep 2022 15:12:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17BC16B0073; Tue, 13 Sep 2022 11:12:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12BDE6B0075; Tue, 13 Sep 2022 11:12:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F355C6B0078; Tue, 13 Sep 2022 11:12:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E2D0A6B0073 for ; Tue, 13 Sep 2022 11:12:39 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BA88F80C0C for ; Tue, 13 Sep 2022 15:12:39 +0000 (UTC) X-FDA: 79907404038.20.BFF8CCB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id AE7C4C00C8 for ; Tue, 13 Sep 2022 15:12:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F1183614CF; Tue, 13 Sep 2022 15:12:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46E53C433C1; Tue, 13 Sep 2022 15:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663081955; bh=4luCPVtQTAZm35zZrX2IGMQkLhYUQiShAN4g1WJcn8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ij4X0cM3XlwT37LgX3kv5/sJHbizPuQndngFDP4EWnIj8AVrjyh4b6G9rr27MVHl/ L9zwqqsdFItrXT/VRvx4kXzTOHe1gxIRCPfkEr3Y3+E1lJpJZOKHSYEpoDFRsX1fBm /r05Dqt4Sl93xrzWV5J+iLKyySpzW9ouyBkoLD4nXCfxOkbDjc8zz3MpD1m5vivW/U 74G/ZkhqNkD4iuQ6a4eMjCFTw0Jyqv0p2dTzMwVec8oghCfQdpqnjvYwAsNa5vQffI X0kQJWcLHfymzX2s66tgDXwPqC9nSdpgKUw5z6Lx04wsIRPrHwjJiBrGQL3X+Gp4OE WIUOoz/X0WFyA== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH 0/4] mm/damon: code simplifications and cleanups Date: Tue, 13 Sep 2022 15:12:33 +0000 Message-Id: <20220913151233.103245-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663081958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=soukQwrem34zPkoOumU+y5Ebup/a1b574VUh3ABeXSE=; b=hWAPiJOreXweG2ChE6N/1Bl6jArM59lUf0KfNYk9JsdpojLoKaCFSdFnWiWYtKFy93AZdl SXTPk9cVJwjNhPfQCRvbTfu7UmLxvwF3SQS8b36OpXzR/sj7lwiLVbvBIxeBZyf+ylB03L 5sW4OSBwE5jqGeqET7pRt/q0Q97ZzUc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ij4X0cM3; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663081958; a=rsa-sha256; cv=none; b=VfVLl/XniZkSMlBXG7azh8aNcXQFQ+AworDkPpqxpH83JojWYcR6D1QKHm1qsftlLqyTgb HZbrBkoax+8eonP87c3dgsdYZFMNixLCW0PxKyy29YRpJU3cGNVlm+a292nfuoxj4uXb1B psSdZGhJ+xrWOz6fdmrbWDFMVSTnEms= X-Rspam-User: X-Stat-Signature: 8wfpd5jz4uj3ehn96psxzmc4jtmxfgqa X-Rspamd-Queue-Id: AE7C4C00C8 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ij4X0cM3; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam08 X-HE-Tag: 1663081958-72430 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 13 Sep 2022 17:11:23 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > This patchset contains some code simplifications and cleanups > for DAMON. For the first three patches, Reviewed-by: SeongJae Park But, I have a question for the last one. Please answer it. Thanks, SJ > > Kaixu Xia (4): > mm/damon: simplify the parameter passing for 'prepare_access_checks' > mm/damon/sysfs: simplify the variable 'pid' assignment operation > mm/damon/core: simplify the kdamond stop mechanism by removing 'done' > mm/damon/vaddr: indicate the target is invalid when 'nr_regions' is > zero > > mm/damon/core.c | 24 +++++++++--------------- > mm/damon/paddr.c | 5 ++--- > mm/damon/sysfs.c | 11 ++++------- > mm/damon/vaddr.c | 9 ++++++--- > 4 files changed, 21 insertions(+), 28 deletions(-) > > -- > 2.27.0