From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E8EC54EE9 for ; Tue, 13 Sep 2022 17:16:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA1138D0001; Tue, 13 Sep 2022 13:16:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E50E46B0072; Tue, 13 Sep 2022 13:16:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3F528D0001; Tue, 13 Sep 2022 13:16:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C61F86B0071 for ; Tue, 13 Sep 2022 13:16:51 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 98B5E1C5CAA for ; Tue, 13 Sep 2022 17:16:51 +0000 (UTC) X-FDA: 79907717022.19.F2B5B50 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 3D77CC00C6 for ; Tue, 13 Sep 2022 17:16:51 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6A6A2B8104A; Tue, 13 Sep 2022 17:16:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A57CBC433C1; Tue, 13 Sep 2022 17:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663089408; bh=Uo0FmKOIOqO2xt98KZDO75WMovCewe/BPwr12WzqD+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mAlGN2bbSywVp6ZYPZdCV+CdkaorThXnHVupWVu4TBqYco2iF+6ffjoU204Ci59xD QYVctAzw25geHyf0q6pAXfz06rbQk2VZUv9nk6rUhCdG72swQ+NTHuQedhHAFwXnqU IF/lpEivXclmgCb/wuCpAzd6fi4BtKrZsIsQR6wiXTYvkGHlodvO9LRQylSKEgfssc XUdPM18I8xWqEMkAWVCTaSyxWDYNTcQmonggXcRUrOCZiaqGLdvKkpQeH+LJs0X2vo CtPlfprzSMSNhql2Z5OvJh2J6PtKhdNHeSFgLRmhoe6K/tL5axr4CwUmdSVVai4dN3 EJ89jtbcc9gJA== From: SeongJae Park To: Dawei Li Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon: Creating kmem cache for damon regions by KMEM_CACHE() Date: Tue, 13 Sep 2022 17:16:46 +0000 Message-Id: <20220913171646.47472-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663089411; a=rsa-sha256; cv=none; b=rAzlSlIBDx4xf2J2gavN+FZDrwP5VpDDF9N4AHTJJX/WYucsxDxVOSvH/0UaFKehukU5Xd DDUaocLp7FsUWMF5bH4lKOq4GghfKJHHqet7/WnOMl45aPIHd8nwM6vgH52kAZz2vksR0w 5rYIiLJAzZbRikYwDnibpXGNoDzDAYQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mAlGN2bb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663089411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IzEJvDqgB6ybGEn8MXPW6RmZp/5/rhlD6Xi8EY6Ywio=; b=neHXuIy5pYutv09RfRcr+v/nN4pc5nGSWL3XyEEv+9ADJxU3NZoVZga3CtMMNUHcWSZAqm 4mEn2Th2zD5JDux8GF9QBHVfTNNNPXDqUBxA/FSLpSymZQHAuxa/sQNqDHEak2Vty1fhfz E94u2rz/5EFwzb2/AMkGVYg8o+uiQE0= Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mAlGN2bb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 1hktpm1jx6csregq8mcw376g554x3xua X-Rspamd-Queue-Id: 3D77CC00C6 X-HE-Tag: 1663089411-325694 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 14 Sep 2022 00:21:58 +0800 Dawei Li wrote: > Damon regions are dynamic objects which can be created and destroyed > frequently, a dedicated slab cache is created by KMEM_CACHE(), as > suggested by akpm. > > Signed-off-by: Dawei Li > --- > mm/damon/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 0b1eb945c68a..20163c3c9aa7 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -1283,8 +1283,7 @@ bool damon_find_biggest_system_ram(unsigned long *start, unsigned long *end) > > static int __init damon_init(void) > { > - damon_region_cache = kmem_cache_create("damon_region_cache", sizeof(struct damon_region), > - 0, 0, NULL); > + damon_region_cache = KMEM_CACHE(damon_region, 0); I was about to say about the 80 columns limit, and this fixes it as well. Thank you, Andrew and Dawei! > if (unlikely(!damon_region_cache)) { > pr_err("creating damon_region_cache fails\n"); > return -ENOMEM; > -- > 2.25.1 > For this fixup and the initial patch[1], Reviewed-by: SeongJae Park [1] https://lore.kernel.org/damon/TYCP286MB2323DA1894FA55BB9CF90978CA449@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM/ Thanks, SJ