From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 756ECECAAA1 for ; Fri, 16 Sep 2022 16:37:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D21BA8D0002; Fri, 16 Sep 2022 12:37:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD00C8D0001; Fri, 16 Sep 2022 12:37:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B97FA8D0002; Fri, 16 Sep 2022 12:37:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A81188D0001 for ; Fri, 16 Sep 2022 12:37:25 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7F1C4C1B73 for ; Fri, 16 Sep 2022 16:37:25 +0000 (UTC) X-FDA: 79918504050.30.51E0385 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf21.hostedemail.com (Postfix) with ESMTP id 2A3471C00BF for ; Fri, 16 Sep 2022 16:37:24 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B482BB82866; Fri, 16 Sep 2022 16:37:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4795C433C1; Fri, 16 Sep 2022 16:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663346241; bh=vLKW3Gq6muuTLKVz5phR18jx4OuzQbbEePlcPKmt4oo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sj+xbk4MXxrHXdhICPcKsreC2faYMsGk+DvIEUmZ9rbxopWBVIaSfPMVS4MB3z0fX bwrOfcnvn2C8tK8+O5zANRFoMd9TfsPZ29Vy8mcAWkIihafPE0Wqe/uHR1Ozko0/ED VKEPQfi+y3MYSLYh5YzaIMKN3a15EjKt44aG2hcNfm+TwQJTiQIcP5v+9QOsBqb2QB 01fjiK8lJ1XRuXHnJ+jpHXlmuycYsYLMmCGWRRuMBIO2UejhRsidKd5T2+TgUlEuTw p8Futp9m2xy4jDbtd6JWYYeVDUo2JwXjHEZvZ04qu2y3uSoOsrLnxtdbO+TlFEWjdh TVLGslW9yRcQg== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] mm/damon: return void from damon_set_schemes() Date: Fri, 16 Sep 2022 16:37:19 +0000 Message-Id: <20220916163719.17577-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1663341635-12675-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663346244; a=rsa-sha256; cv=none; b=0Xg6SBw9HD8J/7db7kAPpams0JQNiYunjIfBbmkdE6pOnoT3gxwbM9ObdcZStE43huszj2 2y6su+T8hA/kwU26scT3lxtHDxL9nNHn8QgMDSKyhtSLc0Qwnwxo2unMx4grkOs4kgGbw7 9g3/EKlOJKxxV0Fp1gjnTb+E2ef4qcM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sj+xbk4M; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663346244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e2p+OySg34u2Cmnm2TX2BMviAi6Cnk2NeRN4VrOI9yM=; b=aftmKKtfQV0T0u0zYFdDw0aI1p8hfwR0fetuflFgbcqIo97c6RSIw8YdPAHkM3OdpYFud5 PTbwdodkjG7cwCktv5VKYIl93G/Hb86nZYgeIeppQSpu/26Uz1E39vxe8+Kroooom8/dYX 1XL/w4fHD/kgOHKHA/b78VJZdBIQBGE= X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2A3471C00BF Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sj+xbk4M; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org X-Stat-Signature: t6bqhjyo3w3e15qbtwjxwib3d5cfyhw8 X-HE-Tag: 1663346244-142866 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 16 Sep 2022 23:20:35 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > There is no point in returning an int from damon_set_schemes(). > It always returns 0 which is meaningless for the caller, so > change it to return void directly. > > Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park Thanks, SJ [...]