From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94688ECAAD8 for ; Tue, 20 Sep 2022 16:33:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8A30940008; Tue, 20 Sep 2022 12:33:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1123940007; Tue, 20 Sep 2022 12:33:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB174940008; Tue, 20 Sep 2022 12:33:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B956B940007 for ; Tue, 20 Sep 2022 12:33:10 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7733DA630C for ; Tue, 20 Sep 2022 16:33:10 +0000 (UTC) X-FDA: 79933008540.22.1377180 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 194091C0063 for ; Tue, 20 Sep 2022 16:33:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54CEDB82983; Tue, 20 Sep 2022 16:33:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D3ABC433C1; Tue, 20 Sep 2022 16:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663691587; bh=SyW+GjcCjRvE/yEXks2zPGJu/Rt4pnX5r+N3a1uyxRA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dhErWCSXOBGZYglnFQomPh1MstM47hkNjGtSFgdan3Md7RI2FRukF/duTNdl0C68A x5UiXF8ItPbVLg0jQHak3yfVzS4E99Ebn9mfmAzIZnII5mCA/VbK7DHD3YIcME+YWA RDTHsOhFZewi3rpaIHKYL658obI0MyrNue5EYyENGO+CSaXHIiCImFATLALPrIzp0J ise+R6QUykAYt/mFnaxfNlCJFIKEGbRRswnNePCbElcVV9olZu69MU/GWV1QmN9cxZ X/KyWzw4lots2TpacCtsCwBBEdRsmY3lXLgqXnaIFnAxutgs4NDtBVHpYwhl0vlp8S j8QIvUl3P20+A== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/damon/sysfs: return 'err' value when call kstrtoul() failed Date: Tue, 20 Sep 2022 16:33:04 +0000 Message-Id: <20220920163304.52672-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220920025158.70293-1-xhao@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dhErWCSX; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663691590; a=rsa-sha256; cv=none; b=YqMLteU/zIOONfAJPNrmBdBDrsBEKZWJnlzUsG0RDgTVj5uzxHs/pq/bsZWtk+gmeXnY1V M2KftAORRWeG7QEAvnQhKC2hjHKZLG5AK5lgngCGmYBgbGgQ3xIgGlxcsfDuFYrxNaQXw9 yNXKona2eaCDceyyWnrHm+Xj9rq5t+M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663691590; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F60D75pTA+gT35c2vVeU+MijOLQ5qVl8itbWd3qp8BM=; b=dMJdusl1f9+vPftkOhcpA4xyNYz5tqtWTFkxsoAuy/fiQvS+1+WmE6jpZcT81BKMpyckU5 NnU7YC0Sr2IQUaooAlK/p1D6uN+swGgJ37v7o9NJfrx1m5Ix8r2dRnKrGcNF0QtYf0M2mk ePI09vEpmxGFbU5QgmhEY8CtQHJNkdw= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 194091C0063 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dhErWCSX; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: wdg8sno5egeuhf9ixmhx7ysz4w44bqdc X-HE-Tag: 1663691589-329204 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xin, On Tue, 20 Sep 2022 10:51:58 +0800 Xin Hao wrote: > We had better return the 'err' value when calling kstrtoul() failed, so > the user will know why it really fails, there do little change, let it > return the 'err' value when failed. > > Suggested-by: SeongJae Park > Signed-off-by: Xin Hao Looks good to me overall, but... > Changes from v1 > https://lore.kernel.org/linux-mm/20220919170305.61335-1-sj@kernel.org/T/ > - keep the 'err' variable, and return the 'err' value when failed. Patch changelog shouldn't be here as a part of the commit message, > --- But here. Other than that, Reviewed-by: SeongJae Park I will revise and post it on behalf of Xin, for reducing unnecessary Andrew's burden. Thanks, SJ [...]