From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, Kostya Serebryany <kcc@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Alexander Potapenko <glider@google.com>,
Taras Madan <tarasmadan@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
Andi Kleen <ak@linux.intel.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Bharata B Rao <bharata@amd.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Ashok Raj <ashok.raj@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv9 08/14] x86/mm: Reduce untagged_addr() overhead until the first LAM user
Date: Fri, 30 Sep 2022 17:47:52 +0300 [thread overview]
Message-ID: <20220930144758.30232-9-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <20220930144758.30232-1-kirill.shutemov@linux.intel.com>
Use static key to reduce untagged_addr() overhead.
The key only gets enabled when the first process enables LAM.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
arch/x86/include/asm/uaccess.h | 8 ++++++--
arch/x86/kernel/process_64.c | 4 ++++
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h
index 803241dfc473..fc33d6ba1090 100644
--- a/arch/x86/include/asm/uaccess.h
+++ b/arch/x86/include/asm/uaccess.h
@@ -22,6 +22,8 @@ static inline bool pagefault_disabled(void);
#endif
#ifdef CONFIG_X86_64
+DECLARE_STATIC_KEY_FALSE(tagged_addr_key);
+
/*
* Mask out tag bits from the address.
*
@@ -30,8 +32,10 @@ static inline bool pagefault_disabled(void);
*/
#define untagged_addr(mm, addr) ({ \
u64 __addr = (__force u64)(addr); \
- s64 sign = (s64)__addr >> 63; \
- __addr &= (mm)->context.untag_mask | sign; \
+ if (static_branch_likely(&tagged_addr_key)) { \
+ s64 sign = (s64)__addr >> 63; \
+ __addr &= (mm)->context.untag_mask | sign; \
+ } \
(__force __typeof__(addr))__addr; \
})
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index d75252a5c7be..1730c2fcc7ab 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -742,6 +742,9 @@ static long prctl_map_vdso(const struct vdso_image *image, unsigned long addr)
}
#endif
+DEFINE_STATIC_KEY_FALSE(tagged_addr_key);
+EXPORT_SYMBOL_GPL(tagged_addr_key);
+
static void enable_lam_func(void *mm)
{
struct mm_struct *loaded_mm = this_cpu_read(cpu_tlbstate.loaded_mm);
@@ -791,6 +794,7 @@ static int prctl_enable_tagged_addr(struct mm_struct *mm, unsigned long nr_bits)
}
on_each_cpu_mask(mm_cpumask(mm), enable_lam_func, mm, true);
+ static_branch_enable(&tagged_addr_key);
out:
mmap_write_unlock(mm);
return ret;
--
2.35.1
next prev parent reply other threads:[~2022-09-30 14:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 14:47 [PATCHv9 00/14] Linear Address Masking enabling Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 01/14] x86/mm: Fix CR3_ADDR_MASK Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 02/14] x86: CPUID and CR3/CR4 flags for Linear Address Masking Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 03/14] mm: Pass down mm_struct to untagged_addr() Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 04/14] x86/mm: Handle LAM on context switch Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 05/14] x86/uaccess: Provide untagged_addr() and remove tags before address check Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 06/14] KVM: Serialize tagged address check against tagging enabling Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 07/14] x86/mm: Provide arch_prctl() interface for LAM Kirill A. Shutemov
2022-09-30 14:47 ` Kirill A. Shutemov [this message]
2022-09-30 14:47 ` [PATCHv9 09/14] x86: Expose untagging mask in /proc/$PID/arch_status Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 10/14] x86/mm, iommu/sva: Make LAM and SVM mutually exclusive Kirill A. Shutemov
2022-10-10 21:24 ` Jacob Pan
2022-09-30 14:47 ` [PATCHv9 11/14] selftests/x86/lam: Add malloc and tag-bits test cases for linear-address masking Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 12/14] selftests/x86/lam: Add mmap and SYSCALL " Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 13/14] selftests/x86/lam: Add io_uring " Kirill A. Shutemov
2022-09-30 14:47 ` [PATCHv9 14/14] selftests/x86/lam: Add inherit " Kirill A. Shutemov
2022-10-06 13:58 ` [PATCHv9 00/14] Linear Address Masking enabling Alexander Potapenko
2022-10-06 16:41 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930144758.30232-9-kirill.shutemov@linux.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=andreyknvl@gmail.com \
--cc=ashok.raj@intel.com \
--cc=bharata@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hjl.tools@gmail.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=ryabinin.a.a@gmail.com \
--cc=tarasmadan@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).