From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D00DEC4332F for ; Mon, 10 Oct 2022 07:42:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CEEE6B0071; Mon, 10 Oct 2022 03:42:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37EFE6B0073; Mon, 10 Oct 2022 03:42:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2462E6B0074; Mon, 10 Oct 2022 03:42:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 11CAE6B0071 for ; Mon, 10 Oct 2022 03:42:40 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DA8EDA0BBA for ; Mon, 10 Oct 2022 07:42:39 +0000 (UTC) X-FDA: 80004247638.17.D990B0D Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf10.hostedemail.com (Postfix) with ESMTP id 2FD48C0019 for ; Mon, 10 Oct 2022 07:42:38 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id CE64268AA6; Mon, 10 Oct 2022 09:42:34 +0200 (CEST) Date: Mon, 10 Oct 2022 09:42:34 +0200 From: Christoph Hellwig To: Linus Torvalds Cc: Sumit Garg , Phil Chang =?utf-8?B?KOW8teS4luWLsyk=?= , "ira.weiny@intel.com" , Jens Wiklander , Andrew Morton , Al Viro , "Fabio M. De Francesco" , Christoph Hellwig , "op-tee@lists.trustedfirmware.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 2/4] tee: Remove vmalloc page support Message-ID: <20221010074234.GA20788@lst.de> References: <20221002002326.946620-1-ira.weiny@intel.com> <20221002002326.946620-3-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665387759; a=rsa-sha256; cv=none; b=725E7qeZBkSx9DEAI05lmsyAOaRcSVRnlcYrGFs1BWdLtOapQ7g/KGlN4Ym6aODQMFq2rs +Km3QXdfn1/z441NTL9S70gKMWplFT0gi+T1W1qgMAJp26tXt/cd9vFe1x4LTa/eCVLDQq BHNV6wRylxfppmcYXUygwLxJv/3nXS0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665387759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q7/T3qOR7eV3PKPPEk4TsEo2eKHyahjMu7OZV476LSs=; b=2aJxVqwccwmJv3mRRIeah6K+Yt7Y6x/jpNffhAN6zQOEDQCek5iwaU21cjGIXuU65C+Q1h qUIpW2Z4cQToyMyDe447MITYd9CvCsn1RjFw3cn2RmBqDA4OI8vW9ZNDnTfkWybgs3h593 nVRLT0jsBUrtO9bIKBME8fzBJBfyWeU= Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Stat-Signature: xniimwfresw3qbgpofd54a9wxfparuai X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2FD48C0019 X-Rspam-User: X-HE-Tag: 1665387758-453905 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 06, 2022 at 11:20:16AM -0700, Linus Torvalds wrote: > Actually, I think even then we shouldn't support vmalloc - and > register_shm_helper() just needs to be changed to pass in an array of > actual page pointers instead. > > At that point TEE_SHM_USER_MAPPED should also go away, because then > it's the caller that should just do either the user space page > pinning, or pass in the kernel page pointer. > > JensW, is there some reason that wouldn't work? I suspect the best long term option would be to just pass an iov_iter..