From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA65C4332F for ; Thu, 13 Oct 2022 03:16:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CDBA6B0071; Wed, 12 Oct 2022 23:16:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97E806B0073; Wed, 12 Oct 2022 23:16:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 845F26B0074; Wed, 12 Oct 2022 23:16:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6EC6C6B0071 for ; Wed, 12 Oct 2022 23:16:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 43E621C6013 for ; Thu, 13 Oct 2022 03:16:53 +0000 (UTC) X-FDA: 80014464306.23.E6D90CF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id D9AFC40027 for ; Thu, 13 Oct 2022 03:16:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A6D461662; Thu, 13 Oct 2022 03:16:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20D08C433D6; Thu, 13 Oct 2022 03:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665631011; bh=pPVBjkE+WYLlwdAojvR6/fxG25rQT+sKY5Dn1ohZXRE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JocxvH1+TArBftSrmjX8X/t9EgB4e+ayDR3t9HrEFJdCLH+ouDr0NxbsXvKmz59XS CRSomupkkE/6iOEtIPZbQLa6tcU3hEiqWb8OEaW9V1Is4Rf8UfOIqxdZeq1OLepk1N TFRiM4i03yFDYgYUNUZiNkX/33xRDkU1qqZ18YJAtf3cVMZWo4mD4+QlpJ3WYAKlnd H1GWbnLEFEjoWnvQZxijUODUrGlD5XhPcXjmYNdW7YAGvdL+2TVcPIV5dml568G+Ak x73LJ6ActKw4GV/TfHAvHyJoANHfosb4nbynHdXzH4/mqIMP/1HLunwmohznygUjHC wbBamUHL0zpRQ== Date: Wed, 12 Oct 2022 20:16:50 -0700 From: Jakub Kicinski To: Shakeel Butt Cc: Wei Wang , Eric Dumazet , netdev@vger.kernel.org, "David S . Miller" , cgroups@vger.kernel.org, linux-mm@kvack.org, Roman Gushchin Subject: Re: [PATCH net-next] net-memcg: pass in gfp_t mask to mem_cgroup_charge_skmem() Message-ID: <20221012201650.3e55331d@kernel.org> In-Reply-To: <20221012184050.5a7f3bde@kernel.org> References: <20210817194003.2102381-1-weiwan@google.com> <20221012163300.795e7b86@kernel.org> <20221012173825.45d6fbf2@kernel.org> <20221013005431.wzjurocrdoozykl7@google.com> <20221012184050.5a7f3bde@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665631013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jcN1F6TU12xt1ZVipKKzKsb+NTJydfJYa8ElYl5u5jU=; b=gAV5T/9/WoY0kG3/YvP4d/Jcd4jXmz51oZg/H1cdwhJnjsQ9XTDvJD7oGrOERwWR+DRSzB FI73I7AVS9f/GEwG16D88/d0JpzfTVeNNJsC5rtcILMlusRzgJgWo9D3Vy6USYPDLtO1aX 9qB64Zi0JK+cS97czWcFEMZXdI9Ki4Q= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JocxvH1+; spf=pass (imf12.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665631013; a=rsa-sha256; cv=none; b=LrM3ArYG793LV+bYpIZCuawR93D/41hwpyRrvEsSAh4iINrarlZ5Yh8RwacYsl3Dxs40ur CYLgdZC7pAnFoCp0GGJQsAt8DTy+iIm5KEWdWqjDPdODxR3yTSS7pm4VSC2Fs9VOHc328A 1i2bqBhezWgsRNmziih9GezIOwoPs2o= X-Rspam-User: X-Rspamd-Queue-Id: D9AFC40027 X-Stat-Signature: yy9cm53m7qnd1c41mejp8htwtxjwyew3 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JocxvH1+; spf=pass (imf12.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam10 X-HE-Tag: 1665631012-70931 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 12 Oct 2022 18:40:50 -0700 Jakub Kicinski wrote: > Did the fact that we used to force charge not potentially cause > reclaim, tho? Letting TCP accept the next packet even if it had > to drop the current one? I pushed this little nugget to one affected machine via KLP: diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 03ffbb255e60..c1ca369a1b77 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -7121,6 +7121,10 @@ bool mem_cgroup_charge_skmem(struct mem_cgroup *memcg, unsigned int nr_pages, return true; } + if (gfp_mask == GFP_NOWAIT) { + try_charge(memcg, gfp_mask|__GFP_NOFAIL, nr_pages); + refill_stock(memcg, nr_pages); + } return false; } The problem normally reproes reliably within 10min -- 30min and counting and the application-level latency has not spiked.