linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Matthew Wilcox <willy@infradead.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Uladzislau Rezki <urezki@gmail.com>,
	Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH 5/7] mm/vmalloc: Use a trace_purge_vmap_area_lazy event
Date: Mon, 17 Oct 2022 18:02:31 +0200	[thread overview]
Message-ID: <20221017160233.16582-8-urezki@gmail.com> (raw)
In-Reply-To: <20221017160233.16582-1-urezki@gmail.com>

This is for debug purpose and is called when all outstanding
areas are removed back to the vmap space. It gives some extra
information about:
- a start:end range where set of vmap ares were freed;
- a number of purged areas which were backed off.

Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
---
 mm/vmalloc.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index f4397817ccd7..912abcd6e8b4 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1731,6 +1731,7 @@ static void purge_fragmented_blocks_allcpus(void);
 static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)
 {
 	unsigned long resched_threshold;
+	unsigned int num_purged_areas = 0;
 	struct list_head local_purge_list;
 	struct vmap_area *va, *n_va;
 
@@ -1742,7 +1743,7 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)
 	spin_unlock(&purge_vmap_area_lock);
 
 	if (unlikely(list_empty(&local_purge_list)))
-		return false;
+		goto out;
 
 	start = min(start,
 		list_first_entry(&local_purge_list,
@@ -1777,12 +1778,16 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)
 					      va->va_start, va->va_end);
 
 		atomic_long_sub(nr, &vmap_lazy_nr);
+		num_purged_areas++;
 
 		if (atomic_long_read(&vmap_lazy_nr) < resched_threshold)
 			cond_resched_lock(&free_vmap_area_lock);
 	}
 	spin_unlock(&free_vmap_area_lock);
-	return true;
+
+out:
+	trace_purge_vmap_area_lazy(start, end, num_purged_areas);
+	return num_purged_areas > 0 ? true:false;
 }
 
 /*
-- 
2.30.2



  parent reply	other threads:[~2022-10-17 16:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 16:02 [PATCH 0/7] Add basic trace events for vmap/vmalloc Uladzislau Rezki (Sony)
2022-10-17 16:02 ` [PATCH 1/7] mm: vmap: Add alloc_vmap_area trace event Uladzislau Rezki (Sony)
2022-10-18 16:41   ` Steven Rostedt
2022-10-18 16:57     ` Uladzislau Rezki
2022-10-17 16:02 ` [PATCH 2/7] mm: vmap: Add a purge_vmap_area_lazy " Uladzislau Rezki (Sony)
2022-10-17 16:02 ` [PATCH 2/7] mm: vmap: Add " Uladzislau Rezki (Sony)
2022-10-17 16:02 ` [PATCH 3/7] mm: vmap: Add a free_vmap_area_noflush " Uladzislau Rezki (Sony)
2022-10-17 16:02 ` [PATCH 3/7] mm: vmap: Add " Uladzislau Rezki (Sony)
2022-10-17 16:02 ` [PATCH 4/7] mm/vmalloc: Use a trace_alloc_vmap_area event Uladzislau Rezki (Sony)
2022-10-17 19:12   ` kernel test robot
2022-10-18 16:17     ` Uladzislau Rezki
2022-10-18 16:44       ` Steven Rostedt
2022-10-18 16:55         ` Uladzislau Rezki
2022-10-17 16:02 ` Uladzislau Rezki (Sony) [this message]
2022-10-17 16:02 ` [PATCH 6/7] mm/vmalloc: Use a trace_free_vmap_area_noflush event Uladzislau Rezki (Sony)
2022-10-17 16:02 ` [PATCH 7/7] vmalloc: Add reviewers for vmalloc code Uladzislau Rezki (Sony)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017160233.16582-8-urezki@gmail.com \
    --to=urezki@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@gmail.com \
    --cc=oleksiy.avramchenko@sony.com \
    --cc=rostedt@goodmis.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).